From: "Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "wuzhouhui250@gmail.com" <wuzhouhui250@gmail.com>,
"Wodkowski, PawelX" <pawelx.wodkowski@intel.com>,
"gowrishankar.m@linux.vnet.ibm.com"
<gowrishankar.m@linux.vnet.ibm.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal/vfio: share the default container in multi process
Date: Fri, 5 Oct 2018 10:36:49 +0000 [thread overview]
Message-ID: <FBE7E039FA50BF47A673AD0BD3CD56A8462022F6@HASMSX105.ger.corp.intel.com> (raw)
In-Reply-To: <45f61fc2-ee13-e342-6f4d-0178df40c94d@intel.com>
> -----Original Message-----
> From: Burakov, Anatoly
> Sent: Friday, October 5, 2018 10:58 AM
<snip>
>
> > + if (internal_config.process_type == RTE_PROC_PRIMARY) {
> > + /* if we were secondary process we would try requesting
> > + * container fd from the primary, but we're the primary
> > + * process so just exit here
> > + */
> > + return -1;
> > + }
> > +
> > + p->req = SOCKET_REQ_DEFAULT_CONTAINER;
> > + strcpy(mp_req.name, EAL_VFIO_MP);
>
> strlcpy?
Probably, although I admit I only copied this code from SOCKET_REQ_CONTAINER handling in this file. Eventually it should be fixed in all places with a separate patch.
Thanks,
D.
>
> Otherwise,
> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> --
> Thanks,
> Anatoly
next prev parent reply other threads:[~2018-10-05 10:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 12:39 Darek Stojaczyk
2018-10-04 15:52 ` Burakov, Anatoly
2018-10-05 8:52 ` Burakov, Anatoly
2018-10-05 8:57 ` Burakov, Anatoly
2018-10-05 10:36 ` Stojaczyk, Dariusz [this message]
2018-10-05 12:40 ` Ferruh Yigit
2018-10-29 0:17 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FBE7E039FA50BF47A673AD0BD3CD56A8462022F6@HASMSX105.ger.corp.intel.com \
--to=dariusz.stojaczyk@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=gowrishankar.m@linux.vnet.ibm.com \
--cc=pawelx.wodkowski@intel.com \
--cc=stable@dpdk.org \
--cc=wuzhouhui250@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).