From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dariusz.stojaczyk@intel.com> Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id C6C105424; Fri, 26 Oct 2018 10:18:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Oct 2018 01:18:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,427,1534834800"; d="scan'208";a="85749999" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 26 Oct 2018 01:18:44 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 26 Oct 2018 01:18:44 -0700 Received: from hasmsx111.ger.corp.intel.com (10.184.198.39) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 26 Oct 2018 01:18:43 -0700 Received: from hasmsx105.ger.corp.intel.com ([169.254.1.193]) by HASMSX111.ger.corp.intel.com ([169.254.5.130]) with mapi id 14.03.0415.000; Fri, 26 Oct 2018 11:18:41 +0300 From: "Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org> Thread-Topic: [PATCH] eal: fixup hotplugging an already present device Thread-Index: AQHUbFDKc8+PgPuSak2RWH8+QjwaWKUvpqIAgAGFp+A= Date: Fri, 26 Oct 2018 08:18:40 +0000 Message-ID: <FBE7E039FA50BF47A673AD0BD3CD56A846220D84@HASMSX105.ger.corp.intel.com> References: <20181025105101.137701-1-dariusz.stojaczyk@intel.com> <3469600.mFqcC2W9gb@xps> In-Reply-To: <3469600.mFqcC2W9gb@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDVhMzVjNDEtYjE0NC00MTg4LTlmMjEtM2MyZGUwMzc0NWM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQWdcLytaZXlFUkhVU05UeDFtSHQ2QXMzcVpIejAzXC84dytrNWFcL1JXUHVuREorXC9lblwvSDBOYitHU0NockNieWlCIn0= x-ctpclassification: CTP_NT x-originating-ip: [10.252.39.89] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: fixup hotplugging an already present device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 26 Oct 2018 08:18:46 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, October 25, 2018 1:49 PM > To: Stojaczyk, Dariusz <dariusz.stojaczyk@intel.com> > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [PATCH] eal: fixup hotplugging an already present device >=20 > 25/10/2018 12:51, Darek Stojaczyk: > > We were returning rc =3D -1 from a device probing function > > whenever the provided device was already probed before. > > > > This basically broke hotplugging a device in secondary > > process when the same device was already hotplugged in > > the primary. > > > > To fix it, just return 0 instead of -1. I believe this is > > the originally intented behavior. >=20 > The intent was to return the error seen during probing again. > If there is no error, the PMD must return 0. > It means I reject this patch so far. >=20 I see, let's abandon this one. I submitted another patch for PCI that resolves the mentioned hotplug issue= : [PATCH] pci: propagate exact error codes in pci_probe_all_drivers() D.