From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 170F52B91 for ; Fri, 8 Mar 2019 10:18:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2019 01:18:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,455,1544515200"; d="scan'208";a="149765415" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 08 Mar 2019 01:18:16 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 8 Mar 2019 01:18:16 -0800 Received: from HASMSX110.ger.corp.intel.com (10.184.198.28) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 8 Mar 2019 01:18:15 -0800 Received: from hasmsx105.ger.corp.intel.com ([169.254.1.16]) by HASMSX110.ger.corp.intel.com ([169.254.6.18]) with mapi id 14.03.0415.000; Fri, 8 Mar 2019 11:18:12 +0200 From: "Stojaczyk, Dariusz" To: Maxime Coquelin , "dev@dpdk.org" , "Liu, Changpeng" , "Bie, Tiwei" , "i.maximets@samsung.com" Thread-Topic: [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by external backend Thread-Index: AQHUz3rkTtrMKrCnw0i+EM4kzEfDuKYBf2bQ Date: Fri, 8 Mar 2019 09:18:12 +0000 Message-ID: References: <20190228153134.31865-1-maxime.coquelin@redhat.com> <20190228153134.31865-3-maxime.coquelin@redhat.com> In-Reply-To: <20190228153134.31865-3-maxime.coquelin@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.102.11.60] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by external backend X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 09:18:17 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Thursday, February 28, 2019 4:32 PM > To: dev@dpdk.org; Liu, Changpeng ; Bie, Tiwei > ; i.maximets@samsung.com > Cc: Maxime Coquelin > Subject: [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by > external backend >=20 > External backends may have specific requests to handle, and so > we don't want the vhost-user lib to handle these requests as > errors. >=20 > This patch also changes the experimental API by introducing > RTE_VHOST_MSG_RESULT_NOT_HANDLED so that vhost-user lib > can report an error if a message is handled neither by > the vhost-user library nor by the external backend. >=20 > The logic changes a bit so that if the callback returns > with ERR, OK or REPLY, it is considered the message > is handled by the external backend so it won't be > handled by the vhost-user library. > It is still possible for an external backend to listen > to requests that have to be handled by the vhost-user > library like SET_MEM_TABLE, but the callback have to > return NOT_HANDLED in that case. >=20 > Suggested-by: Ilya Maximets > Signed-off-by: Maxime Coquelin > --- Besides the fall-through compilation issue, Tested-by: Darek Stojaczyk Thanks!