From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 32E8E1DBA; Wed, 24 Apr 2019 11:28:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 02:28:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,389,1549958400"; d="scan'208";a="145262927" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 24 Apr 2019 02:28:45 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 24 Apr 2019 02:28:45 -0700 Received: from lcsmsx154.ger.corp.intel.com (10.186.165.229) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 24 Apr 2019 02:28:45 -0700 Received: from hasmsx105.ger.corp.intel.com ([169.254.1.47]) by LCSMSX154.ger.corp.intel.com ([169.254.7.189]) with mapi id 14.03.0415.000; Wed, 24 Apr 2019 12:28:42 +0300 From: "Stojaczyk, Dariusz" To: "Lipiec, Herakliusz" CC: "dev@dpdk.org" , "Lipiec, Herakliusz" , "jianfeng.tan@intel.com" , "stable@dpdk.org" , "Burakov, Anatoly" Thread-Topic: [dpdk-dev] [PATCH v2 1/8] ipc: fix rte_mp_request_sync memleak Thread-Index: AQHU+fwkTvge0b3e406l7tWBp9T6E6ZLC80Q Date: Wed, 24 Apr 2019 09:28:41 +0000 Message-ID: References: <20190417143822.21276-1-herakliusz.lipiec@intel.com> <20190423174334.19612-1-herakliusz.lipiec@intel.com> <20190423174334.19612-2-herakliusz.lipiec@intel.com> In-Reply-To: <20190423174334.19612-2-herakliusz.lipiec@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.102.11.37] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/8] ipc: fix rte_mp_request_sync memleak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2019 09:28:48 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Herakliusz Lipiec > Sent: Tuesday, April 23, 2019 7:43 PM > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > jianfeng.tan@intel.com; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/8] ipc: fix rte_mp_request_sync memleak >=20 > When sending multiple requests, rte_mp_request_sync > can succeed sending a few of those requests, but then > fail on a later one and in the end return with rc=3D-1. > The upper layers - e.g. device hotplug - currently > handles this case as if no messages were sent and no > memory for response buffers was allocated, which is > not true. Fixed by always initializing message buffer > to NULL. > Bugzilla ID: 228 > Fixes: 783b6e54971d ("eal: add synchronous multi-process communication") > Cc: jianfeng.tan@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Herakliusz Lipiec > Acked-by: Anatoly Burakov > --- Acked-by: Darek Stojaczyk Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 84855A05D3 for ; Wed, 24 Apr 2019 11:28:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B1F052BC1; Wed, 24 Apr 2019 11:28:48 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 32E8E1DBA; Wed, 24 Apr 2019 11:28:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 02:28:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,389,1549958400"; d="scan'208";a="145262927" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 24 Apr 2019 02:28:45 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 24 Apr 2019 02:28:45 -0700 Received: from lcsmsx154.ger.corp.intel.com (10.186.165.229) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 24 Apr 2019 02:28:45 -0700 Received: from hasmsx105.ger.corp.intel.com ([169.254.1.47]) by LCSMSX154.ger.corp.intel.com ([169.254.7.189]) with mapi id 14.03.0415.000; Wed, 24 Apr 2019 12:28:42 +0300 From: "Stojaczyk, Dariusz" To: "Lipiec, Herakliusz" CC: "dev@dpdk.org" , "Lipiec, Herakliusz" , "jianfeng.tan@intel.com" , "stable@dpdk.org" , "Burakov, Anatoly" Thread-Topic: [dpdk-dev] [PATCH v2 1/8] ipc: fix rte_mp_request_sync memleak Thread-Index: AQHU+fwkTvge0b3e406l7tWBp9T6E6ZLC80Q Date: Wed, 24 Apr 2019 09:28:41 +0000 Message-ID: References: <20190417143822.21276-1-herakliusz.lipiec@intel.com> <20190423174334.19612-1-herakliusz.lipiec@intel.com> <20190423174334.19612-2-herakliusz.lipiec@intel.com> In-Reply-To: <20190423174334.19612-2-herakliusz.lipiec@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.102.11.37] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/8] ipc: fix rte_mp_request_sync memleak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190424092841.jmnrW5JJUzMRlLLV46sOUAq7Qjd2-Isq1unVZBHexQ0@z> > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Herakliusz Lipiec > Sent: Tuesday, April 23, 2019 7:43 PM > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > jianfeng.tan@intel.com; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/8] ipc: fix rte_mp_request_sync memleak >=20 > When sending multiple requests, rte_mp_request_sync > can succeed sending a few of those requests, but then > fail on a later one and in the end return with rc=3D-1. > The upper layers - e.g. device hotplug - currently > handles this case as if no messages were sent and no > memory for response buffers was allocated, which is > not true. Fixed by always initializing message buffer > to NULL. > Bugzilla ID: 228 > Fixes: 783b6e54971d ("eal: add synchronous multi-process communication") > Cc: jianfeng.tan@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Herakliusz Lipiec > Acked-by: Anatoly Burakov > --- Acked-by: Darek Stojaczyk Thanks!