From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A56EA046B for ; Tue, 23 Jul 2019 05:35:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 943E01BEEF; Tue, 23 Jul 2019 05:35:51 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 8A63C1BEEC for ; Tue, 23 Jul 2019 05:35:49 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2019 20:35:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,297,1559545200"; d="scan'208";a="171047635" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 22 Jul 2019 20:35:47 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 22 Jul 2019 20:35:48 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 22 Jul 2019 20:35:47 -0700 Received: from hasmsx106.ger.corp.intel.com (10.184.198.20) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 22 Jul 2019 20:35:47 -0700 Received: from hasmsx105.ger.corp.intel.com ([169.254.1.231]) by HASMSX106.ger.corp.intel.com ([169.254.10.247]) with mapi id 14.03.0439.000; Tue, 23 Jul 2019 06:35:45 +0300 From: "Stojaczyk, Dariusz" To: Thomas Monjalon , David Marchand , "Burakov, Anatoly" , "jerinj@marvell.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection Thread-Index: AQHVQI0FjDxN6cq+2k2hb+hejqdguKbWl6+AgAD1FnA= Date: Tue, 23 Jul 2019 03:35:44 +0000 Message-ID: References: <1562795329-16652-1-git-send-email-david.marchand@redhat.com> <1563800213-29839-1-git-send-email-david.marchand@redhat.com> <1735440.496QTsyyT4@xps> In-Reply-To: <1735440.496QTsyyT4@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.184.70.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This introduces a regression where uio-bound devies are attached to a DPDK app at runtime. When there are no devices attached at initialization, the only safe default should be RTE_IOVA_PA. With RTE_IOVA_VA we just won't be able to do any DMA to uio-bound PCI devices.=20 Can we revert this patch? D. > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, July 22, 2019 5:53 PM > To: David Marchand ; Burakov, Anatoly > ; jerinj@marvell.com > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection >=20 > 22/07/2019 14:56, David Marchand: > > Following the issues reported by Jerin and the discussion that emerged > > from it, here are fixes to restore and document the behavior of the EAL > > and the pci bus driver. > > > > I pondered all the arguments and tried to have the less changes > > possible. > > I can't find a need for a flag to just announce support of physical > > addresses from the pmd point of view. > > So it ended up with something really close to what Jerin had suggested. > > > > But the problem is that this is still unfinished wrt the documentation. > > I will be offline for 10 days and we need this to move forward, so > > sending > > anyway. > > > > Changelog since v3: > > - fixed typos in patch 2, > > - updated patch 3 title, > > - moved and reworded comments in the note section in patch 4, > > > > Changelog since v2 (Jerin): > > - Patch 2/4 - Remove personal appeals in log messages(Anatoly) > > - Patch 4/4 - Added documentation (Anatoly) > > > > Changelog since v1 (Jerin): > > - Changed RTE_PCI_DRV_IOVA_AS_VA flag name as > RTE_PCI_DRV_NEED_IOVA_AS_VA > > (patch 3/4) > > - Changed IOVA mode as VA for default case(patch 4/4) with > documentation > > - Tested the patch series on octeontx2 platform >=20 > Applied, thanks Jerin, Anatoly and David for converging > on a documented solution together. >=20 >=20