* [dpdk-dev] [pktgen PATCH] Fix dpdk-version.sh on Fedora
@ 2017-07-28 16:08 Timothy Redaelli
2017-07-28 17:32 ` Wiles, Keith
0 siblings, 1 reply; 2+ messages in thread
From: Timothy Redaelli @ 2017-07-28 16:08 UTC (permalink / raw)
To: dev
Fedora and RHEL dpdk-devel package installs rte_version.h inside
$RTE_INCLUDE (/usr/include/dpdk) instead of $RTE_SDK
Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
---
tools/dpdk-version.sh | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/tools/dpdk-version.sh b/tools/dpdk-version.sh
index 0989aa4..75146cf 100755
--- a/tools/dpdk-version.sh
+++ b/tools/dpdk-version.sh
@@ -87,15 +87,19 @@ EOM
exit 1
}
-if [ -z ${RTE_SDK} ] ; then
- echo "*** RTE_SDK is not set, using "${PWD}
- sdk=${PWD}
+if [ -n ${RTE_INCLUDE} ] ; then
+ fpath=${RTE_INCLUDE}/${fname}
else
- sdk=${RTE_SDK}
+ if [ -z ${RTE_SDK} ] ; then
+ echo "*** RTE_SDK is not set, using "${PWD}
+ sdk=${PWD}
+ else
+ sdk=${RTE_SDK}
+ fi
+
+ fpath=${sdk}/lib/librte_eal/common/include/${fname}
fi
-fpath=${sdk}/lib/librte_eal/common/include/${fname}
-
if [ ! -e ${fpath} ]; then
echo "File not found @ "${fpath}
usage
--
2.13.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [pktgen PATCH] Fix dpdk-version.sh on Fedora
2017-07-28 16:08 [dpdk-dev] [pktgen PATCH] Fix dpdk-version.sh on Fedora Timothy Redaelli
@ 2017-07-28 17:32 ` Wiles, Keith
0 siblings, 0 replies; 2+ messages in thread
From: Wiles, Keith @ 2017-07-28 17:32 UTC (permalink / raw)
To: Timothy Redaelli; +Cc: dev
> On Jul 28, 2017, at 11:08 AM, Timothy Redaelli <tredaelli@redhat.com> wrote:
>
> Fedora and RHEL dpdk-devel package installs rte_version.h inside
> $RTE_INCLUDE (/usr/include/dpdk) instead of $RTE_SDK
>
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> tools/dpdk-version.sh | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/tools/dpdk-version.sh b/tools/dpdk-version.sh
> index 0989aa4..75146cf 100755
> --- a/tools/dpdk-version.sh
> +++ b/tools/dpdk-version.sh
> @@ -87,15 +87,19 @@ EOM
> exit 1
> }
>
> -if [ -z ${RTE_SDK} ] ; then
> - echo "*** RTE_SDK is not set, using "${PWD}
> - sdk=${PWD}
> +if [ -n ${RTE_INCLUDE} ] ; then
> + fpath=${RTE_INCLUDE}/${fname}
> else
> - sdk=${RTE_SDK}
> + if [ -z ${RTE_SDK} ] ; then
> + echo "*** RTE_SDK is not set, using "${PWD}
> + sdk=${PWD}
> + else
> + sdk=${RTE_SDK}
> + fi
> +
> + fpath=${sdk}/lib/librte_eal/common/include/${fname}
> fi
>
> -fpath=${sdk}/lib/librte_eal/common/include/${fname}
I applied your patch to my ‘dev’ branch. I had added a file path output as well. I did have to patch your patch to work correctly of non-RTE_INCLUDE usage. It appears the [ -n ${RTE_INCLUDE} ] test had to be converted to a -z as the RTE_INCLUDE path was always executed even if RTE_INCLUDE was not defined.
Please give the new version a try and let me know if it works.
> -
> if [ ! -e ${fpath} ]; then
> echo "File not found @ "${fpath}
> usage
> --
> 2.13.3
>
Regards,
Keith
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-28 17:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-28 16:08 [dpdk-dev] [pktgen PATCH] Fix dpdk-version.sh on Fedora Timothy Redaelli
2017-07-28 17:32 ` Wiles, Keith
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).