From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0283A00C5; Thu, 30 Apr 2020 09:18:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 743AC1D937; Thu, 30 Apr 2020 09:18:19 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id ADE8A1D931 for ; Thu, 30 Apr 2020 09:18:17 +0200 (CEST) IronPort-SDR: qABrnmDyOrPhHaYifFQb7/MQO+mT/7LnAH83cdeHn+qL00t26eXIvAj8WModOy6EDQW+6efuyR srX8BJZAOZ2A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 00:18:16 -0700 IronPort-SDR: V9ZlfjuoPQAk1dlLE+JXSGf3AXWtNwy6Nd7nAEgpuD5vjvK2hiP5MJQjMzpLvt25rWSx5G4PdX gcH/rLzeT1Bg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,334,1583222400"; d="scan'208,217";a="294421578" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by orsmga008.jf.intel.com with ESMTP; 30 Apr 2020 00:18:15 -0700 Received: from pgsmsx110.gar.corp.intel.com (10.221.44.111) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Apr 2020 15:13:46 +0800 Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.217]) by PGSMSX110.gar.corp.intel.com ([169.254.13.190]) with mapi id 14.03.0439.000; Thu, 30 Apr 2020 15:13:45 +0800 From: "Tummala, Sivaprasad" To: Flavio Leitner , Maxime Coquelin CC: "Wang, Zhihong" , "Ye, Xiaolong" , "dev@dpdk.org" Thread-Topic: [PATCH v1] vhost: fix mbuf allocation failures Thread-Index: AQHWHgJI2lFDEqc0BUGvGzaATXPze6iP1yKAgAFec3A= Date: Thu, 30 Apr 2020 07:13:44 +0000 Message-ID: References: <20200428095203.64935-1-Sivaprasad.Tummala@intel.com> <020fd369-6b44-c5fe-c7b1-e33146de4c37@redhat.com> <20200429173553.GG27219@p50.lan> In-Reply-To: <20200429173553.GG27219@p50.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDNlMzdmODItNjBlMC00Njk3LWE0YWUtNjQ5NTQ1NmMwYjVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoianY2cnlNakdsaFBRZkFEUzd0UjgyN0dFVFwvT3hxS0YxbmU0QjJHQzJ6Y2Y5MXY4V05udmR1emlyNGRZaTFOT1AifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1] vhost: fix mbuf allocation failures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Flavio, Thanks for your comments. snipped > > The patch fixes the error scenario by skipping to next descriptor. > > Note: Drop counters are not currently supported. In that case shouldn't we continue to process the ring? Yes, we are updating the loop index and following the required clean-up. Also, don't we have the same issue with copy_desc_to_mbuf() Thank you. Will update in the V2 patch. and get_zmbuf()? This patch is not targeted for zero-copy cases. fbl snipped