From: "Luo, Michael" <michael.luo@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix time sync for 25G
Date: Tue, 12 Mar 2019 01:21:24 +0000 [thread overview]
Message-ID: <FE9A29D05E0F2E4DA4FE2EAD3500D0615BCAA75E@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190311074220.14588-1-qi.z.zhang@intel.com>
Verified the patch on DPDK 18.11.
Best regards,
Michael
-----Original Message-----
From: Zhang, Qi Z
Sent: Monday, March 11, 2019 3:42 PM
To: dev@dpdk.org
Cc: Luo, Michael <michael.luo@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
Subject: [PATCH] net/i40e: fix time sync for 25G
Time sync increment value is not configured for 25G device.
The patch fix this issue by setting the same value as 40G, this aligned with kernel driver's behaviour.
Fixes: 75d133dd3296 ("net/i40e: enable 25G device")
Cc: stable@dpdk.org
Reported-by: Michael Luo <michael.luo@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index dca61f03a..8191a6a73 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -10830,6 +10830,7 @@ i40e_start_timecounters(struct rte_eth_dev *dev)
switch (link.link_speed) {
case ETH_SPEED_NUM_40G:
+ case ETH_SPEED_NUM_25G:
tsync_inc_l = I40E_PTP_40GB_INCVAL & 0xFFFFFFFF;
tsync_inc_h = I40E_PTP_40GB_INCVAL >> 32;
break;
--
2.13.6
next prev parent reply other threads:[~2019-03-12 1:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 7:42 Qi Zhang
2019-03-12 1:21 ` Luo, Michael [this message]
2019-03-12 3:11 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FE9A29D05E0F2E4DA4FE2EAD3500D0615BCAA75E@SHSMSX104.ccr.corp.intel.com \
--to=michael.luo@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).