From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AB08111DE for ; Mon, 20 Mar 2017 08:32:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1489995171; x=1521531171; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qjuy+SN1HDh2wfUs3CeNN/8uHSKyILdn6EAA/a9I4ac=; b=YKd/jheAfWYin7/q4UhnTG9UK4q9xIlwfc+oY/a9xPgwFFakhnW+EXPq YW7uVhQ/S79QPZu+CLnwqMW0ak3Uow==; Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2017 00:32:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,193,1486454400"; d="scan'208";a="946126555" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 20 Mar 2017 00:32:49 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 20 Mar 2017 00:32:49 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 20 Mar 2017 00:32:49 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0248.002; Mon, 20 Mar 2017 15:32:47 +0800 From: "Liu, Changpeng" To: Yuanhan Liu , "dev@dpdk.org" CC: Maxime Coquelin , "Harris, James R" Thread-Topic: [PATCH 13/17] vhost: do not include net specific headers Thread-Index: AQHSlAP3vh4UoYCNc0S5G2AOJ4n7S6Gdaveg Date: Mon, 20 Mar 2017 07:32:45 +0000 Message-ID: References: <1488534682-3494-1-git-send-email-yuanhan.liu@linux.intel.com> <1488534682-3494-14-git-send-email-yuanhan.liu@linux.intel.com> In-Reply-To: <1488534682-3494-14-git-send-email-yuanhan.liu@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2Y1M2I5Y2ItOWVkMC00ODc5LWIxYmItM2M3ZDE0NmEwY2NlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InJqOHRkNnU1T1BmbUNTZGJtd1RBZTJtTUd1dXJwRk81NXNPN2Jnd2xNT0E9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 13/17] vhost: do not include net specific headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2017 07:32:52 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Friday, March 3, 2017 5:51 PM > To: dev@dpdk.org > Cc: Maxime Coquelin ; Harris, James R > ; Liu, Changpeng ; Yua= nhan > Liu > Subject: [PATCH 13/17] vhost: do not include net specific headers >=20 > Include it internally, at vhost.h. >=20 > Signed-off-by: Yuanhan Liu > --- > examples/vhost/main.h | 2 ++ > lib/librte_vhost/rte_virtio_net.h | 4 ---- > lib/librte_vhost/vhost.h | 4 ++++ > 3 files changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/examples/vhost/main.h b/examples/vhost/main.h > index 7a3d251..ddcd858 100644 > --- a/examples/vhost/main.h > +++ b/examples/vhost/main.h > @@ -36,6 +36,8 @@ >=20 > #include >=20 > +#include > + > /* Macros for printing using RTE_LOG */ > #define RTE_LOGTYPE_VHOST_CONFIG RTE_LOGTYPE_USER1 > #define RTE_LOGTYPE_VHOST_DATA RTE_LOGTYPE_USER2 > diff --git a/lib/librte_vhost/rte_virtio_net.h b/lib/librte_vhost/rte_vir= tio_net.h > index fa98d29..e19ebad 100644 > --- a/lib/librte_vhost/rte_virtio_net.h > +++ b/lib/librte_vhost/rte_virtio_net.h > @@ -42,14 +42,10 @@ > #include > #include > #include > -#include > #include > -#include > -#include >=20 > #include > #include > -#include One small nits here, remove net specific headers is good idea, since API rt= e_vhost_dequeue_burst/rte_vhost_enqueue_burst=20 has "struct rte_mbuf" declared parameter, user must include in= their own applications. Can we add extra line "struct rte_mbuf;" before the rte_vhost_dequeue_burst= /rte_vhost_enqueue_burst APIs to avoid such extra includes? >=20 > #define RTE_VHOST_USER_CLIENT (1ULL << 0) > #define RTE_VHOST_USER_NO_RECONNECT (1ULL << 1) > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h > index 829a45b..5bc0ebe 100644 > --- a/lib/librte_vhost/vhost.h > +++ b/lib/librte_vhost/vhost.h > @@ -39,8 +39,12 @@ > #include > #include > #include > +#include > +#include > +#include >=20 > #include > +#include >=20 > #include "rte_virtio_net.h" >=20 > -- > 1.9.0