From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9093F2BFF for ; Fri, 7 Jul 2017 06:54:28 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jul 2017 21:54:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,320,1496127600"; d="scan'208";a="990076134" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 06 Jul 2017 21:54:27 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Jul 2017 21:54:27 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Jul 2017 21:54:26 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002; Fri, 7 Jul 2017 12:54:25 +0800 From: "Liu, Changpeng" To: Yuanhan Liu CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] examples/vhost: introduce a new vhost-user-scsi sample application Thread-Index: AQHS9tUTLXHLmlcBTkm1HuF9TCVEpqJHROUAgACHDmA= Date: Fri, 7 Jul 2017 04:54:24 +0000 Message-ID: References: <1498728512-12728-1-git-send-email-changpeng.liu@intel.com> <1499487291-17053-1-git-send-email-changpeng.liu@intel.com> <20170707044854.GV11626@yliu-home> In-Reply-To: <20170707044854.GV11626@yliu-home> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: introduce a new vhost-user-scsi sample application X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2017 04:54:30 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yliu@fridaylinux.org] > Sent: Friday, July 7, 2017 12:49 PM > To: Liu, Changpeng > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: introduce a new vhost-= user- > scsi sample application >=20 > On Sat, Jul 08, 2017 at 12:14:51PM +0800, Changpeng Liu wrote: > > +.. note:: > > + You must check whether your Qemu can support "vhost-user-scsi" or = not, > > + Qemu v2.9.50 or newer version is required. >=20 > QEMU v2.9.50 looks like a stable version, and I don't think they will > backport new features on it (or, do they?). No backport plans. >=20 > So, it should be "v2.10" here? v2.10 should be fine. >=20 > > + switch (pc) { > > + case SPC_VPD_SUPPORTED_VPD_PAGES: > > + hlen =3D 4; > > + vpage->params[0] =3D SPC_VPD_SUPPORTED_VPD_PAGES; > > + vpage->params[1] =3D SPC_VPD_UNIT_SERIAL_NUMBER; > > + vpage->params[2] =3D SPC_VPD_DEVICE_IDENTIFICATION; > > + len =3D 3; > > + /* PAGE LENGTH */ > > + to_be16(vpage->alloc_len, len); > > + break; >=20 > You didn't resolve my previous comment regarding the "break" > indentation issue. Didn't notice here, will do it with v3. >=20 > Otherwise, this patch looks good to me. >=20 > --yliu