From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <changpeng.liu@intel.com> Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1E4CF2FDD for <dev@dpdk.org>; Wed, 19 Jul 2017 02:20:12 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2017 17:20:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,378,1496127600"; d="scan'208";a="1174155752" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 18 Jul 2017 17:20:11 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Jul 2017 17:20:10 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Jul 2017 17:20:10 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002; Wed, 19 Jul 2017 08:20:08 +0800 From: "Liu, Changpeng" <changpeng.liu@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH v4] examples/vhost: introduce a new vhost-user-scsi sample application Thread-Index: AQHS/HeTCaR3vNa/3kebvt008LpMG6JZJAsAgAEouBA= Date: Wed, 19 Jul 2017 00:20:08 +0000 Message-ID: <FF7FC980937D6342B9D289F5F3C7C2625B59A5D4@SHSMSX103.ccr.corp.intel.com> References: <1499491297-17800-1-git-send-email-changpeng.liu@intel.com> <1500106836-20010-1-git-send-email-changpeng.liu@intel.com> <6467798.dkg9oKoERO@xps> In-Reply-To: <6467798.dkg9oKoERO@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWQxNDEzYzQtZGVlNC00YjllLTk0YTItOThlZTM5NjcxODA5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Im15c3FoVW1Dcm1tMkRRSkNPUmtIdDN0bWxMZ2NLWEFKMmtiREhwREJHN0k9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] examples/vhost: introduce a new vhost-user-scsi sample application X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 19 Jul 2017 00:20:13 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, July 18, 2017 10:24 PM > To: Liu, Changpeng <changpeng.liu@intel.com> > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] examples/vhost: introduce a new vhost-= user- > scsi sample application >=20 > Hi, >=20 > 15/07/2017 11:20, Changpeng Liu: > > --- /dev/null > > +++ b/examples/vhost_scsi/scsi_spec.h > > @@ -0,0 +1,488 @@ > > +/*- > > + * BSD LICENSE > > + * > > + * Copyright (c) Intel Corporation. > > + * All rights reserved. > > + * > > + * Redistribution and use in source and binary forms, with or withou= t > > + * modification, are permitted provided that the following condition= s > > + * are met: > > + * > > + * * Redistributions of source code must retain the above copyrigh= t > > + * notice, this list of conditions and the following disclaimer. > > + * * Redistributions in binary form must reproduce the above copyr= ight > > + * notice, this list of conditions and the following disclaimer = in > > + * the documentation and/or other materials provided with the > > + * distribution. > > + * * Neither the name of Intel Corporation nor the names of its > > + * contributors may be used to endorse or promote products deriv= ed > > + * from this software without specific prior written permission. > > + * > > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND > CONTRIBUTORS > > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND > FITNESS FOR > > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE > COPYRIGHT > > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, > INCIDENTAL, > > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT > NOT > > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF > USE, > > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND > ON ANY > > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TO= RT > > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF > THE USE > > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH > DAMAGE. > > + */ > > + > > +#ifndef _SCSI_SPEC_H > > +#define _SCSI_SPEC_H >=20 > This file is full of specification values. > Ideally it should be included from somewhere else. > If not possible, please add a comment in this file to explain where > it comes from. Is it copied from other projects? As I know, Linux has one library iscsi-devel contains some definition of the SCSI specification, again the library is not good enough, so I reuse the code from SPDK(https://github.com/spdk/spdk, BSD licensed). > Is there a link to the specification? Please find the link to the SCSI Primary Commands 3 and SCSI Block Commands= 3 specifications from the following link: http://www.t10.org/drafts.htm#SPC_Family