From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E6DE047CD for ; Wed, 19 Jul 2017 06:24:17 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2017 21:24:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,379,1496127600"; d="scan'208";a="1197075348" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 18 Jul 2017 21:24:15 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Jul 2017 21:24:15 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Jul 2017 21:24:15 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.94]) with mapi id 14.03.0319.002; Wed, 19 Jul 2017 12:24:12 +0800 From: "Liu, Changpeng" To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4] examples/vhost: introduce a new vhost-user-scsi sample application Thread-Index: AQHS/HeTCaR3vNa/3kebvt008LpMG6JZJAsAgAEouBD//8BZgIAAhy/A Date: Wed, 19 Jul 2017 04:24:12 +0000 Message-ID: References: <1499491297-17800-1-git-send-email-changpeng.liu@intel.com> <6467798.dkg9oKoERO@xps> <6331570.OI5S64Z1KD@xps> In-Reply-To: <6331570.OI5S64Z1KD@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmYxNDYyYjUtZmY4MC00ZTY5LWJmYTgtMmZhMjk4YTY5YzRlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlZOMXViQ3pmYmZBNnhtam1PK1VcL2VEQ2Z3MTlWZjM0MU5HbjFqdk5qVTY0PSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] examples/vhost: introduce a new vhost-user-scsi sample application X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2017 04:24:18 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, July 19, 2017 12:19 PM > To: Liu, Changpeng > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] examples/vhost: introduce a new vhost-= user- > scsi sample application >=20 > 19/07/2017 03:20, Liu, Changpeng: > > > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > Sent: Tuesday, July 18, 2017 10:24 PM > > > To: Liu, Changpeng > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v4] examples/vhost: introduce a new vh= ost- > user- > > > scsi sample application > > > > > > Hi, > > > > > > 15/07/2017 11:20, Changpeng Liu: > > > > --- /dev/null > > > > +++ b/examples/vhost_scsi/scsi_spec.h > > > > @@ -0,0 +1,488 @@ > > > > +/*- > > > > + * BSD LICENSE > > > > + * > > > > + * Copyright (c) Intel Corporation. > > > > + * All rights reserved. > > > > + * > > > > + * Redistribution and use in source and binary forms, with or wi= thout > > > > + * modification, are permitted provided that the following condi= tions > > > > + * are met: > > > > + * > > > > + * * Redistributions of source code must retain the above copy= right > > > > + * notice, this list of conditions and the following disclai= mer. > > > > + * * Redistributions in binary form must reproduce the above c= opyright > > > > + * notice, this list of conditions and the following disclai= mer in > > > > + * the documentation and/or other materials provided with th= e > > > > + * distribution. > > > > + * * Neither the name of Intel Corporation nor the names of it= s > > > > + * contributors may be used to endorse or promote products d= erived > > > > + * from this software without specific prior written permiss= ion. > > > > + * > > > > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND > > > CONTRIBUTORS > > > > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT > NOT > > > > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND > > > FITNESS FOR > > > > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE > > > COPYRIGHT > > > > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, > > > INCIDENTAL, > > > > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT > > > NOT > > > > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS > OF > > > USE, > > > > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED > AND > > > ON ANY > > > > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, O= R > TORT > > > > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT > OF > > > THE USE > > > > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH > > > DAMAGE. > > > > + */ > > > > + > > > > +#ifndef _SCSI_SPEC_H > > > > +#define _SCSI_SPEC_H > > > > > > This file is full of specification values. > > > Ideally it should be included from somewhere else. > > > If not possible, please add a comment in this file to explain where > > > it comes from. Is it copied from other projects? > > > > As I know, Linux has one library iscsi-devel contains some definition > > of the SCSI specification, again the library is not good enough, so I > > reuse the code from SPDK(https://github.com/spdk/spdk, BSD licensed). > > > Is there a link to the specification? > > Please find the link to the SCSI Primary Commands 3 and SCSI Block Comm= ands > 3 > > specifications from the following link: > > http://www.t10.org/drafts.htm#SPC_Family >=20 > Please, add these comments in the file. Okay, also will add SPDK link to document.