From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E1DB31B878 for ; Thu, 1 Feb 2018 01:29:40 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2018 16:29:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,442,1511856000"; d="scan'208";a="14976935" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 31 Jan 2018 16:29:39 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 31 Jan 2018 16:29:38 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.145]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.130]) with mapi id 14.03.0319.002; Thu, 1 Feb 2018 08:29:37 +0800 From: "Liu, Changpeng" To: Stefan Hajnoczi , "dev@dpdk.org" CC: "Chen, Junjie J" , Yuanhan Liu , Maxime Coquelin Thread-Topic: [PATCH] examples/vhost_scsi: drop unimplemented EVENT_IDX feature bit Thread-Index: AQHTmrvNo7K+LloRmEqPq7AYypisQqOOsaOA Date: Thu, 1 Feb 2018 00:29:36 +0000 Message-ID: References: <20180131174828.6936-1-stefanha@redhat.com> In-Reply-To: <20180131174828.6936-1-stefanha@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2JlZGMxYzMtZWFkYy00YjRkLWEwZGItYTdmMjczZDQ3ZmI5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImZUbW9FSzBEN24rRlBWZXJsdWZYVlwvdW9MTVp0ZzVIRjJrdEpXSWMxTUk0PSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/vhost_scsi: drop unimplemented EVENT_IDX feature bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 00:29:41 -0000 > -----Original Message----- > From: Stefan Hajnoczi [mailto:stefanha@redhat.com] > Sent: Thursday, February 1, 2018 1:48 AM > To: dev@dpdk.org > Cc: Chen, Junjie J ; Yuanhan Liu ; > Liu, Changpeng ; Maxime Coquelin > ; Stefan Hajnoczi > Subject: [PATCH] examples/vhost_scsi: drop unimplemented EVENT_IDX featur= e > bit >=20 > The vhost_scsi example application negotiates the > VIRTIO_RING_F_EVENT_IDX feature bit but does not honor it when accessing > vrings. >=20 > In particular, commit e37ff954405addb8ea422426a2d162d00dcad196 ("vhost: > support virtqueue interrupt/notification suppression") broke vring call > because vq->last_used_idx is never updated by vhost_scsi. The > vq->last_used_idx field is not even available via the librte_vhost > public API, so VIRTIO_RING_F_EVENT_IDX is currently only usable by the > built-in virtio_net.c driver in librte_vhost. >=20 > This patch drops VIRTIO_RING_F_EVENT_IDX from vhost_scsi so that vring > call works again. >=20 > Cc: Changpeng Liu > Cc: Junjie Chen > Signed-off-by: Stefan Hajnoczi > --- > examples/vhost_scsi/vhost_scsi.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Changpeng Liu >=20 > diff --git a/examples/vhost_scsi/vhost_scsi.c b/examples/vhost_scsi/vhost= _scsi.c > index da01ad378..3cb4383e9 100644 > --- a/examples/vhost_scsi/vhost_scsi.c > +++ b/examples/vhost_scsi/vhost_scsi.c > @@ -21,7 +21,6 @@ > #include "scsi_spec.h" >=20 > #define VIRTIO_SCSI_FEATURES ((1 << VIRTIO_F_NOTIFY_ON_EMPTY) |\ > - (1 << VIRTIO_RING_F_EVENT_IDX) |\ > (1 << VIRTIO_SCSI_F_INOUT) |\ > (1 << VIRTIO_SCSI_F_CHANGE)) >=20 > -- > 2.14.3