From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85F89424FB; Tue, 5 Sep 2023 05:11:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73D1940A6E; Tue, 5 Sep 2023 05:11:16 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2075.outbound.protection.outlook.com [40.107.14.75]) by mails.dpdk.org (Postfix) with ESMTP id 047744026A for ; Tue, 5 Sep 2023 05:11:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YbIuLNU2WDXQtygfsTzl8xKizROqhTUVdGWugP+PuMaB8KLY7ygOAG99wvyXIusCMXQwRpLnab2ppkN7xcLKV0kGziMpRrcQF7u+jrwvc4J/IAkEaip4o2ZMWZ6w7vGz2XZT4saKdO9heCrbxmdj3DGLLuc4BOGBTChnKvarjDCUFzOjf5S180dIxZ2tUMRU3rFi4uBsDmMXTZMWUIR/xkA+EcynYiWywXGOR6Vv4mGfw7+p/i6WkmOIrfTiCFziVOCAHDkG5+fWyXWxOynFdebsbknEVeZPJE2Wfz3LnDWc3PSjskIdEQbxC4o8yf/dFUODMasF5rRcZidIznV37w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TZhrKEqTBGfE7/loMb3L8R7xN0E5iLCX2JRx32fYaNo=; b=EPHwcc7DU+fSPo5ZvODXyJW99bF2oYtTZ9H7mmBj0e/uXSKDXF8UaN7daxOvB18Giw/YfwmcyyXEPt5OMIIaN1wYhgj0IyzM+dzVWdCEDCs+OrenLxu/Z+Jg5UxZR9Wtg/nuXi7FGxQrOXWxFAQRin44kreTUYdHjOB6E5EZB1KJdN1ClvaOfl+SFQybIMp93NXJJQiB1XxJCe6Py7rqvT8E8Mk88Ol8K2g/cwaZY3lvYde4LCZXdNxkhLy8MCD6+I5aMYf3SMres1dCxu5R3bx2cM2DLcPssErHoDIlQeGmp6B2oW/QKh31RcJaxeAMz3aa7DrXSd36f52mmKNwuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TZhrKEqTBGfE7/loMb3L8R7xN0E5iLCX2JRx32fYaNo=; b=fN7N0mugbU6Js8s8ZYQAR3CcjUMXZOUIUp7dPf3hQRpXT72Uxsz/NjAG4LnEmzq7SnyIHqiCxWYeISFkt68K9bH6bOTfk2YxjqQ0ZttNqre6eNzg05nzoYBqy0RYHOsnJso56opBf7GtAw3QXbdQqXyJlnHCYJDhug1X8gjUmMk= Received: from GV1PR08MB7707.eurprd08.prod.outlook.com (2603:10a6:150:52::8) by AS2PR08MB9739.eurprd08.prod.outlook.com (2603:10a6:20b:605::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.30; Tue, 5 Sep 2023 03:11:12 +0000 Received: from GV1PR08MB7707.eurprd08.prod.outlook.com ([fe80::115c:1c8c:7985:9fe7]) by GV1PR08MB7707.eurprd08.prod.outlook.com ([fe80::115c:1c8c:7985:9fe7%6]) with mapi id 15.20.6745.030; Tue, 5 Sep 2023 03:11:12 +0000 From: Feifei Wang To: Konstantin Ananyev , Konstantin Ananyev CC: "dev@dpdk.org" , nd , Honnappa Nagarahalli , Ruifeng Wang , Yuying Zhang , Beilei Xing , nd , nd , nd , nd , nd Subject: RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode Thread-Topic: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode Thread-Index: AQHZ1Mog0nujzlh9U0CHKeg6D9zv8K/48qdwgAvD0gCAARCtoIAATscAgAQvdqCAABm6gIAAGI7ggAAR5wCAARnCUA== Date: Tue, 5 Sep 2023 03:11:11 +0000 Message-ID: References: <20220420081650.2043183-1-feifei.wang2@arm.com> <20230822072710.1945027-1-feifei.wang2@arm.com> <20230822072710.1945027-3-feifei.wang2@arm.com> <6e3a2b3f24e046358646fa26e19122d0@huawei.com> <09ffb5499f594fa4a5f7312a3c6fb5cd@huawei.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7599284B57061148AC271FEBA3F97310.0 x-checkrecipientchecked: true authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: GV1PR08MB7707:EE_|AS2PR08MB9739:EE_ x-ms-office365-filtering-correlation-id: 120c592d-e433-4061-e455-08dbadbdc20c nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MZ32Uy0GdIT3BpV15494OzyWYRpjxL/jUidsFEuDRVhfkH5HOS9I5Gj68Z9QE401k/gznTgAf5D6a436wEOmZYVRh/HUzJECTdkShw3PL+GzhT0mEi8CG2Sbd/BnVNERchyzhccZ3mR1nu9upZ4mDNICGAXiwjzDa1b0IjjqlgwzhFTFItN0SdWWgOwHCwUwXgA+OWCwA56fZ6KWnzDCvif9bxHYf5hJrUgUZCh6KrhklW1gnNdc8i6Cueh6k6KJ9jPpCJRuSW/Du4hx3ylW5eFCzgUKEKjDGTk8aXyS63/+x3imWLtRHEug/djypJj5U53YOI2g2u9r+eBnN4aDrXK/PM2Obk/O5MJ0A2q7eMLPdj/rGmS3AAYY8x00gHb2TwafodA75qxetC1Rh1YJd3ACr2lcnPNfwVZMMdqKt2tTRg9Yv31A+iUF5nGwVk11BL6Qi94qP6/FMrQhVASTwjTHmf8yqcetnD9tv/thdu3FSV22Wx3HFCyCkuAnr1QGvH+Ma9GdyBX3d8BaTtQo7lnq9B9yxL35YbBhHz7iGBJfEXqu0Q6xYP3kkbbRJCkQZxj4VTem0WvDu8MTXuLEdxbbpjoL0wxGVYEmFwKtOJIV3m/a1PCKGged2xx0eeCPJKKM4pg6EOw3ZSLJiaaK5XGvK+PLbt261pVQBOCP+BoJHbKeD2aO2rTYxVanwQtm x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:GV1PR08MB7707.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(39860400002)(376002)(136003)(366004)(396003)(1800799009)(451199024)(186009)(53546011)(6506007)(9686003)(7696005)(8676002)(4326008)(8936002)(83380400001)(316002)(110136005)(64756008)(66476007)(66556008)(66446008)(66946007)(54906003)(71200400001)(76116006)(478600001)(41300700001)(5660300002)(55016003)(52536014)(33656002)(86362001)(38070700005)(38100700002)(26005)(2906002)(30864003)(122000001)(448954002)(579004)(559001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rG2ULrb4Lr5Wh+k+s61/NhTE0a7b3fGw/1MOc0IGj+UBQz9RJWBL8pEeAG5c?= =?us-ascii?Q?+KIjJceSeecKOaemH90ZL166NvH+ApI7SfUVViOmcVXnwZiOMgJetCaM0lCp?= =?us-ascii?Q?rP14nt5VKZu/Rlfj03p5VpR5JV05UnZIzT0+QUIMNIe8ftCC6VWVAZmeDqrJ?= =?us-ascii?Q?FsMdivWIklWKxB+r9sM+ts2NHXIXU5pQai5jA2iZ+zWSZAGgC0Uot1s5X4Fw?= =?us-ascii?Q?sYJHvAyvFyqELBSs16xP9FTLo2H3p/1XIzpnU0YkRWVz+ZUh6a/4HPzgXAjI?= =?us-ascii?Q?TEKHEr2E7sqk6L3h3B1JI682GstTs24kbfJUo6uo+n8XWwvp5+ruB1VE9c8h?= =?us-ascii?Q?fBA/dt6a2x+7jkW3QmX8+Bj8GO+AhK01wREHYS1PEBrjIfkKD5x5TkZH9x+G?= =?us-ascii?Q?kmiCKh5XYZzR0/Fc+nFu/8XqwYGbiSxGiJ8hfk1nRequmEKqY6xdKiycCBxG?= =?us-ascii?Q?07fXT4ircjXJEFoG5LYsDJOHF92KJJM+21eTrnbaALjNGkvT+AdNwe5Qrb7Y?= =?us-ascii?Q?xCfrbiyIwYBCoPILAvTz0iDIA+/S7mkHQIVRZytzsGPPvciBbImPw1srdofw?= =?us-ascii?Q?ts7iyNZlNOksSkjkxG5wu6YLfN4iW/znX6WHbalUP3Ol/n5NehIZiuYY+sJN?= =?us-ascii?Q?W8gTT6K6YW6DZvVd/BFxYFmu1+F0bmpXXbTKVDEu/VO11VmTPlWWF9RStS6S?= =?us-ascii?Q?aCFzUBew6k1LBDgx0Zc+Ir5p4gj15RgzA9dYEk8+oXqcLgWx00UwQjweC4lA?= =?us-ascii?Q?c4JpDh+JlDLtsWJfyeRdPCmZ4ALJ757xn1ukaA+pUA8AezvvUyv1Ahe2xoF0?= =?us-ascii?Q?r7XBob8xrocQnxzNYhRX+IOIAdpprcGULADbCCiknGyANbinrzkqKqL8rd4/?= =?us-ascii?Q?Ht2YQBJ3VnrU/9RLS8DqHUKiR9vvdfk0Lrd3fzFP8ZC5onlgx+sGviACZWd7?= =?us-ascii?Q?KYgXDdEyw9ergYmQA/dkAnTU0tz9U3/j8Xqu3ja7slNX3DM0g3LX2xqGtDPS?= =?us-ascii?Q?4y/3LgDtN19dZieLWnzXe6niW0vjZFZMnbr26mJkeHQeNooIz2QgXdIrWVmY?= =?us-ascii?Q?Fa1RWtCckWy+ElsMhLmIBET/DA+/UwFP4lr/PZHq5MgBUgFCDPPrK73K1nhy?= =?us-ascii?Q?nKaRtLUArphjSbUHP8dzegEOjHz3v2pxj34CVFeatxPGH+U0JiEgHGMrEJGg?= =?us-ascii?Q?A6En6SxvTNkMa7hG44UZSPkYnhHMg7bWW7EtBAMgqzwIQw6iZfOPlYW4uoEd?= =?us-ascii?Q?gKm9VMiJjKP6EI4M4wlUjUTqmVbIf7q2I3zZ8V7FgCiunwJDNk527NuDlQIt?= =?us-ascii?Q?yQqpBvLHFcGFgAguDTXFaLcRLKdtF5Y6W0OmcjDPHCyMugoCqF9YiUbaGneV?= =?us-ascii?Q?fK5myhMLxhJNutyO+ocUiYazJJFpYijcHSa+h9n2KSrOacSVgHvakLIl74wd?= =?us-ascii?Q?+B3aEksUor1LEm+vvO2zXfSjB6ELYa/8q9L0TdJgJt24k67N+lDVpo4q4miA?= =?us-ascii?Q?300AbBl0qwfZrNULjZN3KKoGYhhdQ0NEO5u4GcPY/yl8ibk5vReu6fOaUjFe?= =?us-ascii?Q?yy7KoAptCHNMJllf9BjVChWVqmdrxPHw/cruKqv8?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: GV1PR08MB7707.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 120c592d-e433-4061-e455-08dbadbdc20c X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2023 03:11:11.8527 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vVO+AT7EHTyDUlBG5X84MSQt5U7MuT6cAyTeuDE7WO8Z3HpN/JzEC/VuXKNezTmHBOjHNloOAWbB8GkwtQB4ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9739 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Konstantin Ananyev > Sent: Monday, September 4, 2023 6:22 PM > To: Feifei Wang ; Konstantin Ananyev > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Ruifeng Wang > ; Yuying Zhang ; Beilei > Xing ; nd ; nd ; nd > ; nd > Subject: RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode >=20 >=20 >=20 > > > > > > > > > Define specific function implementation for i40e driver. > > > > > > > > > Currently, mbufs recycle mode can support 128bit vector > > > > > > > > > path and > > > > > > > > > avx2 > > > > > > > path. > > > > > > > > > And can be enabled both in fast free and no fast free mod= e. > > > > > > > > > > > > > > > > > > Suggested-by: Honnappa Nagarahalli > > > > > > > > > > > > > > > > > > Signed-off-by: Feifei Wang > > > > > > > > > Reviewed-by: Ruifeng Wang > > > > > > > > > Reviewed-by: Honnappa Nagarahalli > > > > > > > > > > > > > > --- > > > > > > > > > drivers/net/i40e/i40e_ethdev.c | 1 + > > > > > > > > > drivers/net/i40e/i40e_ethdev.h | 2 + > > > > > > > > > .../net/i40e/i40e_recycle_mbufs_vec_common.c | 147 > > > > > > > > > ++++++++++++++++++ > > > > > > > > > drivers/net/i40e/i40e_rxtx.c | 32 ++++ > > > > > > > > > drivers/net/i40e/i40e_rxtx.h | 4 + > > > > > > > > > drivers/net/i40e/meson.build | 1 + > > > > > > > > > 6 files changed, 187 insertions(+) create mode 100644 > > > > > > > > > drivers/net/i40e/i40e_recycle_mbufs_vec_common.c > > > > > > > > > > > > > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > > > > > > > > b/drivers/net/i40e/i40e_ethdev.c index > > > > > > > > > 8271bbb394..50ba9aac94 > > > > > > > > > 100644 > > > > > > > > > --- a/drivers/net/i40e/i40e_ethdev.c > > > > > > > > > +++ b/drivers/net/i40e/i40e_ethdev.c > > > > > > > > > @@ -496,6 +496,7 @@ static const struct eth_dev_ops > > > > > > > > > i40e_eth_dev_ops > > > > > > > =3D { > > > > > > > > > .flow_ops_get =3D i40e_dev_flow_ops_get= , > > > > > > > > > .rxq_info_get =3D i40e_rxq_info_get, > > > > > > > > > .txq_info_get =3D i40e_txq_info_get, > > > > > > > > > + .recycle_rxq_info_get =3D i40e_recycle_rxq_info= _get, > > > > > > > > > .rx_burst_mode_get =3D i40e_rx_burst_mode_ge= t, > > > > > > > > > .tx_burst_mode_get =3D i40e_tx_burst_mode_ge= t, > > > > > > > > > .timesync_enable =3D i40e_timesync_enable, > > > > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.h > > > > > > > > > b/drivers/net/i40e/i40e_ethdev.h index > > > > > > > > > 6f65d5e0ac..af758798e1 > > > > > > > > > 100644 > > > > > > > > > --- a/drivers/net/i40e/i40e_ethdev.h > > > > > > > > > +++ b/drivers/net/i40e/i40e_ethdev.h > > > > > > > > > @@ -1355,6 +1355,8 @@ void i40e_rxq_info_get(struct > > > > > > > > > rte_eth_dev *dev, uint16_t queue_id, > > > > > > > > > struct rte_eth_rxq_info *qinfo); void > > > > > > > > > i40e_txq_info_get(struct rte_eth_dev *dev, uint16_t queue= _id, > > > > > > > > > struct rte_eth_txq_info *qinfo); > > > > > > > > > +void i40e_recycle_rxq_info_get(struct rte_eth_dev *dev, > > > > > > > > > +uint16_t > > > > > > > queue_id, > > > > > > > > > + struct rte_eth_recycle_rxq_info *recycle_rxq_info); > > > > > > > > > int i40e_rx_burst_mode_get(struct rte_eth_dev *dev, > > > > > > > > > uint16_t > > > > > queue_id, > > > > > > > > > struct rte_eth_burst_mode *mode); int > > > > > > > > > i40e_tx_burst_mode_get(struct rte_eth_dev *dev, uint16_t > > > > > > > > > queue_id, diff -- git > > > > > > > > > a/drivers/net/i40e/i40e_recycle_mbufs_vec_common.c > > > > > > > > > b/drivers/net/i40e/i40e_recycle_mbufs_vec_common.c > > > > > > > > > new file mode 100644 > > > > > > > > > index 0000000000..5663ecccde > > > > > > > > > --- /dev/null > > > > > > > > > +++ b/drivers/net/i40e/i40e_recycle_mbufs_vec_common.c > > > > > > > > > @@ -0,0 +1,147 @@ > > > > > > > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > > > > > > > + * Copyright (c) 2023 Arm Limited. > > > > > > > > > + */ > > > > > > > > > + > > > > > > > > > +#include > > > > > > > > > +#include > > > > > > > > > + > > > > > > > > > +#include "base/i40e_prototype.h" > > > > > > > > > +#include "base/i40e_type.h" > > > > > > > > > +#include "i40e_ethdev.h" > > > > > > > > > +#include "i40e_rxtx.h" > > > > > > > > > + > > > > > > > > > +#pragma GCC diagnostic ignored "-Wcast-qual" > > > > > > > > > + > > > > > > > > > +void > > > > > > > > > +i40e_recycle_rx_descriptors_refill_vec(void *rx_queue, > > > > > > > > > +uint16_t > > > > > > > > > +nb_mbufs) { > > > > > > > > > + struct i40e_rx_queue *rxq =3D rx_queue; > > > > > > > > > + struct i40e_rx_entry *rxep; > > > > > > > > > + volatile union i40e_rx_desc *rxdp; > > > > > > > > > + uint16_t rx_id; > > > > > > > > > + uint64_t paddr; > > > > > > > > > + uint64_t dma_addr; > > > > > > > > > + uint16_t i; > > > > > > > > > + > > > > > > > > > + rxdp =3D rxq->rx_ring + rxq->rxrearm_start; > > > > > > > > > + rxep =3D &rxq->sw_ring[rxq->rxrearm_start]; > > > > > > > > > + > > > > > > > > > + for (i =3D 0; i < nb_mbufs; i++) { > > > > > > > > > + /* Initialize rxdp descs. */ > > > > > > > > > + paddr =3D (rxep[i].mbuf)->buf_iova + > > > > > > > > > RTE_PKTMBUF_HEADROOM; > > > > > > > > > + dma_addr =3D rte_cpu_to_le_64(paddr); > > > > > > > > > + /* flush desc with pa dma_addr */ > > > > > > > > > + rxdp[i].read.hdr_addr =3D 0; > > > > > > > > > + rxdp[i].read.pkt_addr =3D dma_addr; > > > > > > > > > + } > > > > > > > > > + > > > > > > > > > + /* Update the descriptor initializer index */ > > > > > > > > > + rxq->rxrearm_start +=3D nb_mbufs; > > > > > > > > > + rx_id =3D rxq->rxrearm_start - 1; > > > > > > > > > + > > > > > > > > > + if (unlikely(rxq->rxrearm_start >=3D rxq->nb_rx_desc)) = { > > > > > > > > > + rxq->rxrearm_start =3D 0; > > > > > > > > > + rx_id =3D rxq->nb_rx_desc - 1; > > > > > > > > > + } > > > > > > > > > + > > > > > > > > > + rxq->rxrearm_nb -=3D nb_mbufs; > > > > > > > > > + > > > > > > > > > + rte_io_wmb(); > > > > > > > > > + /* Update the tail pointer on the NIC */ > > > > > > > > > + I40E_PCI_REG_WRITE_RELAXED(rxq->qrx_tail, rx_id); } > > > > > > > > > + > > > > > > > > > +uint16_t > > > > > > > > > +i40e_recycle_tx_mbufs_reuse_vec(void *tx_queue, > > > > > > > > > + struct rte_eth_recycle_rxq_info *recycle_rxq_info) { > > > > > > > > > + struct i40e_tx_queue *txq =3D tx_queue; > > > > > > > > > + struct i40e_tx_entry *txep; > > > > > > > > > + struct rte_mbuf **rxep; > > > > > > > > > + int i, n; > > > > > > > > > + uint16_t nb_recycle_mbufs; > > > > > > > > > + uint16_t avail =3D 0; > > > > > > > > > + uint16_t mbuf_ring_size =3D recycle_rxq_info->mbuf_ring= _size; > > > > > > > > > + uint16_t mask =3D recycle_rxq_info->mbuf_ring_size - 1; > > > > > > > > > + uint16_t refill_requirement =3D recycle_rxq_info- > > > > > >refill_requirement; > > > > > > > > > + uint16_t refill_head =3D *recycle_rxq_info->refill_head= ; > > > > > > > > > + uint16_t receive_tail =3D > > > > > > > > > +*recycle_rxq_info->receive_tail; > > > > > > > > > + > > > > > > > > > + /* Get available recycling Rx buffers. */ > > > > > > > > > + avail =3D (mbuf_ring_size - (refill_head - > > > > > > > > > +receive_tail)) & mask; > > > > > > > > > + > > > > > > > > > + /* Check Tx free thresh and Rx available space. */ > > > > > > > > > + if (txq->nb_tx_free > txq->tx_free_thresh || avail <=3D > > > > > > > > > +txq- > > > > > >tx_rs_thresh) > > > > > > > > > + return 0; > > > > > > > > > + > > > > > > > > > + /* check DD bits on threshold descriptor */ > > > > > > > > > + if ((txq->tx_ring[txq->tx_next_dd].cmd_type_offset_bsz > > > > > > > > > +& > > > > > > > > > + > > > > > > > > > rte_cpu_to_le_64(I40E_TXD_QW1_DTYPE_MASK)) !=3D > > > > > > > > > + > > > > > > > > > rte_cpu_to_le_64(I40E_TX_DESC_DTYPE_DESC_DONE)) > > > > > > > > > + return 0; > > > > > > > > > + > > > > > > > > > + n =3D txq->tx_rs_thresh; > > > > > > > > > + nb_recycle_mbufs =3D n; > > > > > > > > > + > > > > > > > > > + /* Mbufs recycle mode can only support no ring buffer > > > > > wrapping > > > > > > > > > around. > > > > > > > > > + * Two case for this: > > > > > > > > > + * > > > > > > > > > + * case 1: The refill head of Rx buffer ring needs to > > > > > > > > > +be aligned > > > > > with > > > > > > > > > + * mbuf ring size. In this case, the number of Tx freei= ng buffers > > > > > > > > > + * should be equal to refill_requirement. > > > > > > > > > + * > > > > > > > > > + * case 2: The refill head of Rx ring buffer does not > > > > > > > > > +need to be > > > > > aligned > > > > > > > > > + * with mbuf ring size. In this case, the update of > > > > > > > > > +refill head > > > > > can not > > > > > > > > > + * exceed the Rx mbuf ring size. > > > > > > > > > + */ > > > > > > > > > + if (refill_requirement !=3D n || > > > > > > > > > + (!refill_requirement && (refill_head + n > > > > > > mbuf_ring_size))) > > > > > > > > > + return 0; > > > > > > > > > + > > > > > > > > > + /* First buffer to free from S/W ring is at index > > > > > > > > > + * tx_next_dd - (tx_rs_thresh-1). > > > > > > > > > + */ > > > > > > > > > + txep =3D &txq->sw_ring[txq->tx_next_dd - (n - 1)]; > > > > > > > > > + rxep =3D recycle_rxq_info->mbuf_ring; > > > > > > > > > + rxep +=3D refill_head; > > > > > > > > > + > > > > > > > > > + if (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) = { > > > > > > > > > + /* Avoid txq contains buffers from unexpected > > > > > mempool. */ > > > > > > > > > + if (unlikely(recycle_rxq_info->mp > > > > > > > > > + !=3D txep[0].mbuf->pool)) > > > > > > > > > + return 0; > > > > > > > > > + > > > > > > > > > + /* Directly put mbufs from Tx to Rx. */ > > > > > > > > > + for (i =3D 0; i < n; i++) > > > > > > > > > + rxep[i] =3D txep[i].mbuf; > > > > > > > > > + } else { > > > > > > > > > + for (i =3D 0; i < n; i++) { > > > > > > > > > + rxep[i] =3D > > > > > rte_pktmbuf_prefree_seg(txep[i].mbuf); > > > > > > > > > + > > > > > > > > > + /* If Tx buffers are not the last reference or > > > > > from > > > > > > > > > + * unexpected mempool, previous copied > > > > > buffers are > > > > > > > > > + * considered as invalid. > > > > > > > > > + */ > > > > > > > > > + if (unlikely((rxep[i] =3D=3D NULL && > > > > > refill_requirement) || > > > > > > > > [Konstantin] > > > > > > > > Could you pls remind me why it is ok to have rxep[i]=3D=3DN= ULL > > > > > > > > when refill_requirement is not set? > > > > > > > > > > > > > > > > If reill_requirement is not zero, it means each tx freed > > > > > > > > buffer must be valid and can be put into Rx sw_ring. Then > > > > > > > > the refill head of Rx buffer ring can be aligned with mbuf > > > > > > > > ring size. Briefly speaking the number > > > > > > > of Tx valid freed buffer must be equal to Rx refill_requireme= nt. > > > > > > > For example, i40e driver. > > > > > > > > > > > > > > > > If reill_requirement is zero, it means that the refill > > > > > > > > head of Rx buffer ring does not need to be aligned with > > > > > > > > mbuf ring size, thus if Tx have n valid freed buffers, we > > > > > > > > just need to put these n buffers into Rx sw- > > > > > > > ring, and not to be equal to the Rx setting rearm number. > > > > > > > For example, mlx5 driver. > > > > > > > > > > > > > > > > In conclusion, above difference is due to pmd drivers have > > > > > > > > different > > > > > > > strategies to update their Rx rearm(refill) head. > > > > > > > > For i40e driver, if rearm_head exceed 1024, it will be set > > > > > > > > as > > > > > > > > 0 due to the > > > > > > > number of each rearm is a fixed value by default. > > > > > > > > For mlx5 driver. Its rearm_head can exceed 1024, and use > > > > > > > > mask to achieve > > > > > > > real index. Thus its rearm number can be a different value. > > > > > > > > > > > > > > Ok, but if rte_pktmbuf_prefree_seg(txep[i].mbuf), it means > > > > > > > that this mbuf is not free yet and can't be reused. > > > > > > > Shouldn't we then set nb_recycle_mbufs =3D 0 in that case too= ? > > > > > > > Or probably would be enough to skip that mbuf? > > > > > > > Might be something like that: > > > > > > > > > > > > > > for (i =3D 0, j =3D 0; i < n; i++) { > > > > > > > > > > > > > > rxep[j] =3D rte_pktmbuf_prefree_seg(txep[i].mbuf); > > > > > > > if (rxep[j] =3D=3D NULL || recycle_rxq_info->mp !=3D rxep[j]= .mbuf- > >pool)) { > > > > > > > if (refill_requirement) { > > > > > > > nb_recycle_mbufs =3D 0; > > > > > > > break; > > > > > > > } > > > > > > > } else > > > > > > > j++; > > > > > > > } > > > > > > > > > > > > > > /* now j contains actual number of recycled mbufs */ > > > > > > > > > > > > > > ? > > > > > > > > > > > > > > > > > > > > > > > > + recycle_rxq_info->mp !=3D > > > > > txep[i].mbuf- > > > > > > > > > >pool)) > > > > > > > > > + nb_recycle_mbufs =3D 0; > > > > > > > > > + } > > > > > > > > > + /* If Tx buffers are not the last reference or > > > > > > > > > + * from unexpected mempool, all recycled buffers > > > > > > > > > + * are put into mempool. > > > > > > > > > + */ > > > > > > > > > + if (nb_recycle_mbufs =3D=3D 0) > > > > > > > > > + for (i =3D 0; i < n; i++) { > > > > > > > > > + if (rxep[i] !=3D NULL) > > > > > > > > > + rte_mempool_put(rxep[i]- > > > > > >pool, > > > > > > > > > rxep[i]); > > > > > > > > > + } > > > > > > > > > + } > > > > > > > > > + > > > > > > [Konstantin] After another thought, it might be easier and clea= ner > just to: > > > > > > if (rxep[j] =3D=3D NULL || recycle_rxq_info->mp !=3D rxep[j].mb= uf->pool) > > > > > > nb_recycle_mbufs =3D 0; > > > > > > > > > > > > Anyway, from my understanding - if > > > > > > rte_pktmbuf_prefree_seg(mbuf) returns NULL, then we can't recyc= le > that mbuf. > > > > > > > > > > > > [Feifei] Agree with that 'rte_pktmbuf_prefree_seg(mbuf) > > > > > > returns NULL, then > > > > > we can't recycle that mbuf'. > > > > > > > > > > > > Firstly, we should know for i40e driver, the number of free > > > > > > mbufs is fixed, it > > > > > must equal to 'tx_rs_thresh' > > > > > > This means if we start to free Tx mbufs, it cannot be > > > > > > interrupted until the > > > > > given amount of mbufs are freed. > > > > > > In the meanwhile, doing prefree operation for a Tx mbuf can be > > > > > > looked at this mbuf is freed from this TX sw-ring if the API > > > > > > returns NULL. This is due > > > > > to that call 'prefree_seg' function means update the mbuf refcnt. > > > > > > > > > > > > So let's come back our recycle mbuf case. > > > > > > Here we consider that the case if we have 32 mbufs need to be > > > > > > freed, and > > > > > we firstly do the pre-free. > > > > > > And then first 8 mbufs is good and return value is not none. > > > > > > But the 9th > > > > > mbuf is bad, its refcnt is more than 1. > > > > > > So we just update its refcnt and cannot put it into Rx sw-ring. > > > > > > For Tx sw-ring, > > > > > this mbuf has been freed. > > > > > > Then we should continue to do pre-free operation for the next > > > > > > Tx mbufs to ensure the given amount of mbufs are freed. > > > > > > > > > > > > Do a conclusion for this, this is because if we start to do > > > > > > pre-free operation, the Tx mbuf refcnt value maybe changed, > > > > > > so we cannot stop or > > > > > break until finish all the pre-free operation. > > > > > > > > > > > > Finally, in the case that Rx refill_request is not zero, but > > > > > > the valid mbuf amount is less than this value, we must put > > > > > > back this Tx mbufs into > > > > > mempool. > > > > > > > > > > > > Above is the reason why I do not directly jump out of the loop > > > > > > if some mbuf > > > > > return value is NULL. > > > > > > > > > > Yep, I already realized that it is a bit more complicated and we > > > > > need to continue with prefree() for all packets even when we get > > > > > NULL in > > > the middle. > > > > > Anyway the code has to be changed, right? > > > > > > > > > Sorry, I think for the code, it is unnecessary to be changed. > > > > For no fast free path, currently: > > > > 1. We check whether each mbuf is Ok and call pre_free function > > > > ------------------------------------------------------------------ > > > > ---- > > > > -------------------------------------------------------------- > > > > 2.1 For the mbuf return value is not NULL, it is put into Rx sw-rin= g. > > > > 2.2 For the mbuf return value is zero and refill-request, it will > > > > also firstly put into Rx sw-ring, and we set nb_recycle =3D 0 > > > > ------------------------------------------------------------------ > > > > ---- > > > > -------------------------------------------------------------- > > > > 3.1 We check nb_recycle, if it is not 0, we will continue to rearm > > > > Rx descs > > > and update its index by call descs_refill function. > > > > 3.2 if nb_recycle is 0, we will put valid recycle mbufs back into > > > > mempool as general path. This is necessary, because we need to > > > > ensure the freed Tx number is fixed.(Some buffers return is null > > > > can be seen as freed, others need to be put into mempool) > > > > > > > > Or maybe I ignore something? > > > > > > > > > I am talking about the case when both refill_requirement and mbuf > > > return values iare zero: > > > if (unlikely((rxep[i] =3D=3D NULL && refill_requirement) || /= / ??? rxep[i] =3D=3D > 0 > > > AND refill_requirement =3D=3D 0 ??? > > > recycle_rxq_info->mp !=3D txep[i].mbuf->pool)) > > > nb_recycle_mbufs =3D 0; > > > > > > As I can read the code you treat such situation as valid, while I > > > think we should reset nb_recycle_mbufs to zero when rxep[i] =3D=3D NU= LL, > > > no matter what value refill_requirement is. > > > > So this means for maybe MLX5 driver, its refill_request =3D 0. And if > > some mbufs return value is zero, the other mbufs can not be recycled > > into Rx sw-ring? Because nb_recycle=3D0, and they need to be put into > mempool. > > > > I think for such as MLX5 driver, we can allow recycle some valid mbufs = into > Rx ring. > > Because no constraint for its refill number. Is my suggestion reasonabl= e? >=20 > I suppose yes: if refill_request is zero we potentially can skip 'bad' mb= ufs and > continue with recycling for remaining ones. > It would probably require more changes in current code, but sounds ok to = me > in general. That's Ok. Thanks for your careful reviewing. >=20 > > > > > > > > > > > > > > > > > > > > > + /* Update counters for Tx. */ > > > > > > > > > + txq->nb_tx_free =3D (uint16_t)(txq->nb_tx_free + txq- > > > > > >tx_rs_thresh); > > > > > > > > > + txq->tx_next_dd =3D (uint16_t)(txq->tx_next_dd + txq- > > > > > >tx_rs_thresh); > > > > > > > > > + if (txq->tx_next_dd >=3D txq->nb_tx_desc) > > > > > > > > > + txq->tx_next_dd =3D (uint16_t)(txq->tx_rs_thresh - 1); > > > > > > > > > + > > > > > > > > > + return nb_recycle_mbufs; } > > > > > > > > > diff --git a/drivers/net/i40e/i40e_rxtx.c > > > > > > > > > b/drivers/net/i40e/i40e_rxtx.c index > > > > > > > > > b4f65b58fa..a9c9eb331c > > > > > > > > > 100644 > > > > > > > > > --- a/drivers/net/i40e/i40e_rxtx.c > > > > > > > > > +++ b/drivers/net/i40e/i40e_rxtx.c > > > > > > > > > @@ -3199,6 +3199,30 @@ i40e_txq_info_get(struct > > > > > > > > > rte_eth_dev *dev, uint16_t queue_id, > > > > > > > > > qinfo->conf.offloads =3D txq->offloads; } > > > > > > > > > > > > > > > > > > +void > > > > > > > > > +i40e_recycle_rxq_info_get(struct rte_eth_dev *dev, > > > > > > > > > +uint16_t > > > > > queue_id, > > > > > > > > > + struct rte_eth_recycle_rxq_info *recycle_rxq_info) { > > > > > > > > > + struct i40e_rx_queue *rxq; > > > > > > > > > + struct i40e_adapter *ad =3D > > > > > > > > > + I40E_DEV_PRIVATE_TO_ADAPTER(dev->data- > > > > > >dev_private); > > > > > > > > > + > > > > > > > > > + rxq =3D dev->data->rx_queues[queue_id]; > > > > > > > > > + > > > > > > > > > + recycle_rxq_info->mbuf_ring =3D (void *)rxq->sw_ring; > > > > > > > > > + recycle_rxq_info->mp =3D rxq->mp; > > > > > > > > > + recycle_rxq_info->mbuf_ring_size =3D rxq->nb_rx_desc; > > > > > > > > > + recycle_rxq_info->receive_tail =3D &rxq->rx_tail; > > > > > > > > > + > > > > > > > > > + if (ad->rx_vec_allowed) { > > > > > > > > > + recycle_rxq_info->refill_requirement =3D > > > > > > > > > RTE_I40E_RXQ_REARM_THRESH; > > > > > > > > > + recycle_rxq_info->refill_head =3D &rxq->rxrearm_start; > > > > > > > > > + } else { > > > > > > > > > + recycle_rxq_info->refill_requirement =3D rxq- > > > > > >rx_free_thresh; > > > > > > > > > + recycle_rxq_info->refill_head =3D &rxq->rx_free_trigge= r; > > > > > > > > > + } > > > > > > > > > +} > > > > > > > > > + > > > > > > > > > #ifdef RTE_ARCH_X86 > > > > > > > > > static inline bool > > > > > > > > > get_avx_supported(bool request_avx512) @@ -3293,6 > > > > > > > > > +3317,8 > > > @@ > > > > > > > > > i40e_set_rx_function(struct rte_eth_dev *dev) > > > > > > > > > dev->rx_pkt_burst =3D ad- > > > >rx_use_avx2 ? > > > > > > > > > > > > i40e_recv_scattered_pkts_vec_avx2 : > > > > > > > > > i40e_recv_scattered_pkts_vec; > > > > > > > > > + dev->recycle_rx_descriptors_refill =3D > > > > > > > > > + > > > > > i40e_recycle_rx_descriptors_refill_vec; > > > > > > > > > } > > > > > > > > > } else { > > > > > > > > > if (ad->rx_use_avx512) { @@ -3311,9 +3337,12 > @@ > > > > > > > > > i40e_set_rx_function(struct rte_eth_dev > > > > > *dev) > > > > > > > > > dev->rx_pkt_burst =3D ad- > > > >rx_use_avx2 ? > > > > > > > > > i40e_recv_pkts_vec_avx2 : > > > > > > > > > i40e_recv_pkts_vec; > > > > > > > > > + dev->recycle_rx_descriptors_refill =3D > > > > > > > > > + > > > > > i40e_recycle_rx_descriptors_refill_vec; > > > > > > > > > } > > > > > > > > > } > > > > > > > > > #else /* RTE_ARCH_X86 */ > > > > > > > > > + dev->recycle_rx_descriptors_refill =3D > > > > > > > > > +i40e_recycle_rx_descriptors_refill_vec; > > > > > > > > > if (dev->data->scattered_rx) { > > > > > > > > > PMD_INIT_LOG(DEBUG, > > > > > > > > > "Using Vector Scattered Rx > > > (port %d).", @@ > > > > > > > > > -3481,15 +3510,18 @@ i40e_set_tx_function(struct > > > > > > > > > rte_eth_dev > > > *dev) > > > > > > > > > dev->tx_pkt_burst =3D ad- > > > >tx_use_avx2 ? > > > > > > > > > > > > i40e_xmit_pkts_vec_avx2 : > > > > > > > > > > > > i40e_xmit_pkts_vec; > > > > > > > > > + dev->recycle_tx_mbufs_reuse =3D > > > > > > > > > i40e_recycle_tx_mbufs_reuse_vec; > > > > > > > > > } > > > > > > > > > #else /* RTE_ARCH_X86 */ > > > > > > > > > PMD_INIT_LOG(DEBUG, "Using Vector Tx > > > (port %d).", > > > > > > > > > dev->data->port_id); > > > > > > > > > dev->tx_pkt_burst =3D i40e_xmit_pkts_vec; > > > > > > > > > + dev->recycle_tx_mbufs_reuse =3D > > > > > > > > > i40e_recycle_tx_mbufs_reuse_vec; #endif /* RTE_ARCH_X86 = */ > > > > > > > > > } else { > > > > > > > > > PMD_INIT_LOG(DEBUG, "Simple tx finally be > > > used."); > > > > > > > > > dev->tx_pkt_burst =3D i40e_xmit_pkts_simple; > > > > > > > > > + dev->recycle_tx_mbufs_reuse =3D > > > > > > > > > i40e_recycle_tx_mbufs_reuse_vec; > > > > > > > > > } > > > > > > > > > dev->tx_pkt_prepare =3D i40e_simple_prep_pkts; > > > > > > > > > } else { > > > > > > > > > diff --git a/drivers/net/i40e/i40e_rxtx.h > > > > > > > > > b/drivers/net/i40e/i40e_rxtx.h index > > > > > > > > > a8686224e5..b191f23e1f > > > > > > > > > 100644 > > > > > > > > > --- a/drivers/net/i40e/i40e_rxtx.h > > > > > > > > > +++ b/drivers/net/i40e/i40e_rxtx.h > > > > > > > > > @@ -236,6 +236,10 @@ uint32_t > > > > > > > > > i40e_dev_rx_queue_count(void *rx_queue); int > > > > > > > > > i40e_dev_rx_descriptor_status(void *rx_queue, uint16_t > > > > > > > > > offset); int i40e_dev_tx_descriptor_status(void > > > > > > > > > *tx_queue, uint16_t offset); > > > > > > > > > > > > > > > > > > +uint16_t i40e_recycle_tx_mbufs_reuse_vec(void *tx_queue, > > > > > > > > > + struct rte_eth_recycle_rxq_info *recycle_rxq_info); > > > > > void > > > > > > > > > +i40e_recycle_rx_descriptors_refill_vec(void *rx_queue, > > > > > > > > > +uint16_t nb_mbufs); > > > > > > > > > + > > > > > > > > > uint16_t i40e_recv_pkts_vec(void *rx_queue, struct > > > > > > > > > rte_mbuf > > > > > **rx_pkts, > > > > > > > > > uint16_t nb_pkts); uint16_t > > > > > > > > > i40e_recv_scattered_pkts_vec(void *rx_queue, diff --git > > > > > > > > > a/drivers/net/i40e/meson.build > > > > > > > > > b/drivers/net/i40e/meson.build index > > > > > > > > > 8e53b87a65..3b1a233c84 100644 > > > > > > > > > --- a/drivers/net/i40e/meson.build > > > > > > > > > +++ b/drivers/net/i40e/meson.build > > > > > > > > > @@ -34,6 +34,7 @@ sources =3D files( > > > > > > > > > 'i40e_tm.c', > > > > > > > > > 'i40e_hash.c', > > > > > > > > > 'i40e_vf_representor.c', > > > > > > > > > + 'i40e_recycle_mbufs_vec_common.c', > > > > > > > > > 'rte_pmd_i40e.c', > > > > > > > > > ) > > > > > > > > > > > > > > > > > > -- > > > > > > > > > 2.25.1