From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <nipun.gupta@nxp.com> Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0058.outbound.protection.outlook.com [104.47.0.58]) by dpdk.org (Postfix) with ESMTP id 7BD401041 for <dev@dpdk.org>; Fri, 15 Sep 2017 08:14:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EVzk354EaXwMY+CyVuXrqZromThLFt9m3Hzblo71tQo=; b=b9q8BfXxYDLlNkeGBsYNqdD790RVNgZP/VsM72VLWKSdZpS+2JkSS61s90O81iwsDXRLDGBpCt36nz7uVSVIuNdDM9e5vp6u5IooGcDUk27/DtfF7aEtZrdWZv4tdJtgrtKxKErhy5MvLxtsvTgtiqe+cv198nCcUyYW4qSE2DQ= Received: from HE1PR0401MB2425.eurprd04.prod.outlook.com (10.168.33.22) by HE1PR0401MB1929.eurprd04.prod.outlook.com (10.166.122.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Fri, 15 Sep 2017 06:14:26 +0000 Received: from HE1PR0401MB2425.eurprd04.prod.outlook.com ([fe80::a1f9:523b:383c:d454]) by HE1PR0401MB2425.eurprd04.prod.outlook.com ([fe80::a1f9:523b:383c:d454%18]) with mapi id 15.20.0056.010; Fri, 15 Sep 2017 06:14:26 +0000 From: Nipun Gupta <nipun.gupta@nxp.com> To: Harry van Haaren <harry.van.haaren@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com> Thread-Topic: [dpdk-dev] [PATCH v4 0/4] eventdev: add attribute based get APIs Thread-Index: AQHTLXPDC2OsJSgglE2Ll+WorqLbh6K1a+dA Date: Fri, 15 Sep 2017 06:14:26 +0000 Message-ID: <HE1PR0401MB2425C53CC73B6820B197B535E66C0@HE1PR0401MB2425.eurprd04.prod.outlook.com> References: <1504885015-44642-1-git-send-email-harry.van.haaren@intel.com> <1505405343-18234-1-git-send-email-harry.van.haaren@intel.com> In-Reply-To: <1505405343-18234-1-git-send-email-harry.van.haaren@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=nipun.gupta@nxp.com; x-originating-ip: [192.88.169.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0401MB1929; 6:+5n47/jFR1KqUpXsm4fmqWF9ukxOZlDBPqPCiweNNAGOUpsqGXYHP1FKj6FxG9HxSdPL3pXp9KOFkQTiRjUXZstnG9VH/vqUWsUvIhFjfXvcRK0X5jVgiIjWCw7zu1sY8xr1og4QuLuMVL+94lu4f1w4oeAxyd1auQJx8Z/SUaWRx6JKu+ksUgSCiauMmS3qRXwDT5DSOdlweGjzYUZmRVEBf5y25A5isZ4p7xzU2PD6PeXlazDBLbkIswciQFehA2mmsFnqMLr+V+OLADEYJtuovUR/0keYZaGN4fa2am38zmCaHZju1ISHq0j3MLiXlYoZZNfalmp+QJTgOAjNbw==; 5:R+vaPetJL29mwN3V7oreou4S6Wv9D8Z06TsZ9TVZfgj4tD5iz0wz2y3ChZHC8gyEIVSaRr86BLi0Unwfa9xF+I7FGg8WZHIHa8qxMcgvZS5DO24d9hdPpOh5ir7YEgeHv0C6+smnCEFE0VOlvjCr7A==; 24:028jkwPteT9zMAlpnhLzS3jEoFpsLlDR7eNvG/XsH38EXfqPwUcTZPTAmTykPv7L439G4Dk2dsQyTZsZ7oBIdnkPpbW07buT4/PvRnu5US4=; 7:+PuplYWON1jdjexBRBzKQEBjO6RRKYMMngtCZ7tM9DelzWHD48VoRR6VoZyTzX+3X1ir7yj2IPTCmeyzaMjs3Dw9ylSDhn5PaulG6J5bLQQJ7S94tCNstLZrfMS2N8pS2tw3by7PgNfgbpTTQWY/V0AHzN9EdUIAR/1ylP1gZrvJye61pVyK+MfYWcvIaGgo7TQbzWLH4V65E8YDFICRIIn/OpmYvNqDh6n996vJqLg= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 83a7a0a7-9c0b-459c-943a-08d4fc0104ad x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:HE1PR0401MB1929; x-ms-traffictypediagnostic: HE1PR0401MB1929: x-exchange-antispam-report-test: UriScan:(185117386973197)(211171220733660)(228905959029699); x-microsoft-antispam-prvs: <HE1PR0401MB192996CCA12B60A45EA6D286E66C0@HE1PR0401MB1929.eurprd04.prod.outlook.com> x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123558100)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR0401MB1929; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR0401MB1929; x-forefront-prvs: 0431F981D8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(189002)(199003)(13464003)(189998001)(53546010)(229853002)(6506006)(2900100001)(7736002)(66066001)(305945005)(7696004)(478600001)(966005)(5250100002)(5660300001)(74316002)(316002)(6436002)(55016002)(99286003)(9686003)(2501003)(2950100002)(68736007)(6116002)(3846002)(102836003)(6306002)(3660700001)(8676002)(81156014)(81166006)(3280700002)(8936002)(25786009)(86362001)(53936002)(6246003)(4326008)(76176999)(50986999)(2906002)(14454004)(101416001)(53376002)(54356999)(106356001)(105586002)(97736004)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0401MB1929; H:HE1PR0401MB2425.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2017 06:14:26.8640 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB1929 Subject: Re: [dpdk-dev] [PATCH v4 0/4] eventdev: add attribute based get APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 15 Sep 2017 06:14:28 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren > Sent: Thursday, September 14, 2017 21:39 > To: dev@dpdk.org > Cc: jerin.jacob@caviumnetworks.com; Harry van Haaren > <harry.van.haaren@intel.com> > Subject: [dpdk-dev] [PATCH v4 0/4] eventdev: add attribute based get APIs >=20 > This patchset refactors the eventdev API to be more flexible > and capable. In particular, the API is capable of returning an > error value if an invalid device, port or attribute ID is passed > in, which was not possible with the previous APIs. >=20 > The implementation of this patchset is based on a v1 patch[1], > and after some discussion this API was seen as the best solution. >=20 > In terms of flexibility, the attribute id allows addition of new > common eventdev layer attributes without breaking ABI or adding > new functions. Note that these attributes are not data-path, and > that PMDs should continue to use the xstats API for reporting any > unique PMD statistics that are available. >=20 > Regarding API/ABI compatibility, I have removed the functions from > the .map files - please review the .map file changes for ABI issues > carefully. >=20 > The last patch of this series adds a started attribute to the device, > allowing the application to query if a device is currently running. >=20 > -Harry >=20 > [1] http://dpdk.org/dev/patchwork/patch/27152/ >=20 > --- >=20 > v4: > - Rework based on review by Jerin > - default: cases into switches > - Remove old functions from .map file > - Remove /* out */ parameters > - Rework header file definitions to match logical order > - Rework patch split > - Cleaner removal of queue_count() function >=20 > v3: > - Fix checkpatch issues... somehow I broke my checkpatch script :/ >=20 > v2: > - New APIs design based on discussion of initial patch. >=20 >=20 >=20 > Harry van Haaren (4): > eventdev: add port attribute function > eventdev: add dev attribute get function > eventdev: add queue attribute function > eventdev: add device started attribute >=20 > lib/librte_eventdev/rte_eventdev.c | 97 ++++++++++++------ > lib/librte_eventdev/rte_eventdev.h | 115 +++++++++++---------- > lib/librte_eventdev/rte_eventdev_version.map | 14 ++- > test/test/test_eventdev.c | 132 +++++++++++++++++++--= ---- > test/test/test_eventdev_octeontx.c | 143 ++++++++++++++++++++-= ------ > 5 files changed, 345 insertions(+), 156 deletions(-) >=20 > -- > 2.7.4 Changes look good. Series Acked-by: Nipun Gupta <Nipun.gupta@nxp.com>