From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20045.outbound.protection.outlook.com [40.107.2.45]) by dpdk.org (Postfix) with ESMTP id 1679C2BBD for ; Thu, 29 Mar 2018 20:02:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=J76IizekVW404pzQ/lI3DnpowjX3gN4MZL+JzwZs1Rg=; b=S44bxgzZkXj44MEZiPy4BKc/ofXufAn1CgI0Adz8+2tZ+xdoXQDZ07IQjalgRt9lUpKx5CDuLcA4hQUVwxenjCHh2pwSqY/zUUs9XEkX9hgLVpizYAKGtJC0a8Oq2cvjGf694H3/AJEL16sHIJxXGIeiBDCj1aJYJpoSiGRxzAk= Received: from HE1PR0402MB2780.eurprd04.prod.outlook.com (10.175.29.14) by HE1PR0402MB2761.eurprd04.prod.outlook.com (10.175.29.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.609.10; Thu, 29 Mar 2018 18:02:05 +0000 Received: from HE1PR0402MB2780.eurprd04.prod.outlook.com ([fe80::cd9:8128:3f1d:710e]) by HE1PR0402MB2780.eurprd04.prod.outlook.com ([fe80::cd9:8128:3f1d:710e%14]) with mapi id 15.20.0631.010; Thu, 29 Mar 2018 18:02:05 +0000 From: Shreyansh Jain To: Thomas Monjalon CC: "dev@dpdk.org" , "ferruh.yigit@intel.com" , Hemant Agrawal , Nipun Gupta , Akhil Goyal Thread-Topic: [dpdk-dev] [PATCH v3 3/7] net/dpaa2: change into dynamic logging Thread-Index: AQHTwp0rJXxcnsmqf0mH62p/jfEdoqPnX3AAgAAqhBA= Date: Thu, 29 Mar 2018 18:01:39 +0000 Deferred-Delivery: Thu, 29 Mar 2018 18:01:08 +0000 Message-ID: References: <20180313054431.19556-1-shreyansh.jain@nxp.com> <20180323120456.16920-1-shreyansh.jain@nxp.com> <20180323120456.16920-4-shreyansh.jain@nxp.com> <2107185.outpdSVCPl@xps> In-Reply-To: <2107185.outpdSVCPl@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.177.118.103] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0402MB2761; 7:ttqrU5bNHotVWcRNMiNH3SgVdJmcZUmn66nJ12Z5N8fYnn+GCFUCr7ZIaqeXhZ7N64xJBhYej9UUy7Dpm/LrzkJkRl+AjQqFH5tUtUaglCqbTLEQJBVEXm5QgMeEv1NwYqYUg0j0EFPEW07dqXNLCFPVbz1VguGf8rJxkQnI9N1+Xi3SefDezbLcAYWeIITiDoojyjMrDK+99I71auKtcFovAW1pFBLtNSGz2KWb7KWNvvCoPw4NE6hZmKcRC6Fi x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 52ee2c5f-01ad-4f41-062c-08d5959f2e76 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0402MB2761; x-ms-traffictypediagnostic: HE1PR0402MB2761: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231221)(944501327)(52105095)(6055026)(6041310)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:HE1PR0402MB2761; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0402MB2761; x-forefront-prvs: 0626C21B10 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(376002)(396003)(366004)(346002)(189003)(199004)(13464003)(11346002)(81156014)(86362001)(3280700002)(2906002)(3660700001)(7696005)(97736004)(229853002)(76176011)(53936002)(6246003)(6916009)(6116002)(55016002)(3846002)(9686003)(476003)(316002)(74316002)(54906003)(68736007)(55236004)(6506007)(5250100002)(486005)(99286004)(486005)(5660300001)(8676002)(6666003)(53546011)(8936002)(81166006)(446003)(106356001)(93886005)(186003)(105586002)(14454004)(26005)(6346003)(33656002)(305945005)(478600001)(2900100001)(66066001)(6436002)(7736002)(102836004)(4326008)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0402MB2761; H:HE1PR0402MB2780.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-microsoft-antispam-message-info: RAUeWkc7RniIh1mCp1vz/Rw5mBivaJrkYV5KzXS5QC6M1ucDowD2Y0T24tvwWBqu/DCQLfPAgOPvXo5XBOAz5sGaGnLMAyRTcHDfL7jg7+W5LLoAmtdt/1oUAQ5tVfpyOeR2AErJFZoPhCRAcVgR6IQ+gFotmJEahVNVJWMinityxNLMlG/uYshLzdtmnWA9bTnc+bU9WujLRfD0TuXpTnLFrzOi+OwunfIA5KqbJXAbCF7vXvoXfoQQ4f6mBCcVeicqEhkirOW1W8/kwE+mW08zjgco1hRLEVVfuwcPAxnZyJI5kHeCaguLfWcQ+piv8Xve3Z+Kq+ZI5x0d9P4XfA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52ee2c5f-01ad-4f41-062c-08d5959f2e76 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2018 18:02:05.3212 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2761 Subject: Re: [dpdk-dev] [PATCH v3 3/7] net/dpaa2: change into dynamic logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 18:02:08 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, March 29, 2018 8:57 PM > To: Shreyansh Jain > Cc: dev@dpdk.org; ferruh.yigit@intel.com; Hemant Agrawal > ; Nipun Gupta ; Akhil Goyal > > Subject: Re: [dpdk-dev] [PATCH v3 3/7] net/dpaa2: change into dynamic > logging >=20 > 23/03/2018 13:04, Shreyansh Jain: > > --- a/config/common_base > > +++ b/config/common_base > > @@ -189,11 +189,6 @@ CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=3Dy > > # Compile burst-oriented NXP DPAA2 PMD driver > > # > > CONFIG_RTE_LIBRTE_DPAA2_PMD=3Dn > > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=3Dn > > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=3Dn > > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_RX=3Dn > > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX=3Dn > > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX_FREE=3Dn > [...] > > --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc > > +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc > > @@ -26,15 +26,7 @@ CONFIG_RTE_LIBRTE_VHOST_NUMA=3Dn > > # Compile Support Libraries for DPAA2 > > # > > CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=3Dn > > - > > -# > > -# Compile burst-oriented NXP DPAA2 PMD driver > > -# > > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=3Dn > > CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=3Dn > > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_RX=3Dn > > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX=3Dn > > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX_FREE=3Dn >=20 >=20 > CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER should be in config/common_base. >=20 > All options should be in config/common_base. > Other files should be used only to overwrite config/common_base. >=20 OK. I explicitly didn't put it in common_base because this is not a general= option. It should be limited to only those who wish to debug/develop on th= is. It is not something an end-user should worry about. Anyways, I will send another version. - Shreyansh