From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <shreyansh.jain@nxp.com> Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01hn0200.outbound.protection.outlook.com [104.47.2.200]) by dpdk.org (Postfix) with ESMTP id 130582BBF for <dev@dpdk.org>; Sat, 5 May 2018 21:09:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LpCIO5DoWn81p/k9aRG6mZI5D4qR9F06kQYSdLmE++Y=; b=YSaE7xkmY+wdbzaqMXsPPtLWGzeUSgJJ8kPtJH2PFwcmK851VIbtRo3WDxYUBysFLLVuuM9tEeJpY/XX2Ia5X+OWQhsFBaAdTeg3SK2pxdJhYHc4sl5E6DdE9oJE4F1AqgBPcbbiwPUbeakaKyHZaHWtlQC8p+PtxEGVGGLXmCY= Received: from HE1PR0402MB2780.eurprd04.prod.outlook.com (10.175.29.14) by HE1PR0402MB3626.eurprd04.prod.outlook.com (10.167.126.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.18; Sat, 5 May 2018 19:09:42 +0000 Received: from HE1PR0402MB2780.eurprd04.prod.outlook.com ([fe80::8d97:47e4:52b9:2040]) by HE1PR0402MB2780.eurprd04.prod.outlook.com ([fe80::8d97:47e4:52b9:2040%14]) with mapi id 15.20.0735.016; Sat, 5 May 2018 19:09:42 +0000 From: Shreyansh Jain <shreyansh.jain@nxp.com> To: "Xu, Rosen" <rosen.xu@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "declan.doherty@intel.com" <declan.doherty@intel.com>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>, "tianfei.zhang@intel.com" <tianfei.zhang@intel.com>, "song.liu@intel.com" <song.liu@intel.com>, "hao.wu@intel.com" <hao.wu@intel.com>, "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>, Yanglong Wu <yanglong.wu@intel.com> Thread-Topic: [PATCH v7 3/5] iFPGA: Add Intel FPGA BUS Rawdev Driver Thread-Index: AQHT47GY0MJEDKQIGk+RCUT9+nzeb6QhgGvQ Date: Sat, 5 May 2018 19:09:32 +0000 Deferred-Delivery: Sat, 5 May 2018 19:08:32 +0000 Message-ID: <HE1PR0402MB2780B1D18469A54512FB3A7D90850@HE1PR0402MB2780.eurprd04.prod.outlook.com> References: <1521553556-62982-1-git-send-email-rosen.xu@intel.com> <1525443062-43231-1-git-send-email-rosen.xu@intel.com> <1525443062-43231-4-git-send-email-rosen.xu@intel.com> In-Reply-To: <1525443062-43231-4-git-send-email-rosen.xu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [14.142.187.166] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0402MB3626; 7:tNkA29cuNsB+umlPVUIfoXy/kRTuBXo3pmBwAaSNzk8Iz5eT2R3orX05liGoJIFsD41HZ6p9ClOfo68+o9i3aLw3fnmX+Ii0NxTnPV+arW4T7GYQYDlSpIH0wJ2VxBvFjIsIHvjbHSDYl88D36G3gMOicOL3b8JzNDI/upCc1cepD1+xDx8eiYiXCnjzrmFo9rRSn3ez3LZkr36KWkTn6lI2lSPe8TKUAofiGW6hReZi0gRWeaqBpV6UiunupFaL x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0402MB3626; x-ms-traffictypediagnostic: HE1PR0402MB3626: x-microsoft-antispam-prvs: <HE1PR0402MB36265F015402842337B8824390850@HE1PR0402MB3626.eurprd04.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(185117386973197)(66839620246622)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231254)(2232076)(944501410)(52105095)(93006095)(93001095)(6055026)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:HE1PR0402MB3626; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0402MB3626; x-forefront-prvs: 0663390E1B x-forefront-antispam-report: SFV:SPM; SFS:(10009020)(376002)(346002)(366004)(39860400002)(39380400002)(396003)(189003)(199004)(13464003)(8676002)(6246003)(3660700001)(8936002)(478600001)(3846002)(6116002)(81156014)(81166006)(55016002)(68736007)(9686003)(106356001)(110136005)(86362001)(54906003)(575784001)(53936002)(105586002)(316002)(14454004)(7736002)(5660300001)(6666003)(97736004)(66066001)(74316002)(7416002)(305945005)(2900100001)(25786009)(2906002)(6436002)(4326008)(33656002)(3280700002)(229853002)(476003)(11346002)(2501003)(7696005)(76176011)(5250100002)(446003)(186003)(53546011)(99286004)(6506007)(26005)(486006)(55236004)(102836004)(44832011)(59010400001)(217873001); DIR:OUT; SFP:1501; SCL:5; SRVR:HE1PR0402MB3626; H:HE1PR0402MB2780.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: VQNnkWU9G1vi4Yvia9Nzdvi+J34k60cBI3PnZ3JHtTgGQ9OJ/aRFwNTh9QUzhEaHNuxNp4tkQE2LgE26n/zZmCxb8O4L9gw/+vEWebR/KJQ4+vxLp54+deYDBXl5D+9U/yVXadfQUeiQ/42meZhH3iVAaP21W0jjjFFFX07MxcEfDnf1GO2Ff62Coey2eaOpCFQY1f+JYSVAlW39UJ44nuEGl8esdgTClXbIcDtQguBcwplSU+QHFhZQmU0RJz9I0dcMh77V5jF3MnFaJ+rDpa2UgkjYIcdexoXGxrR/qi8s/TYnvUEQOPoNJKOO3nCfnDzN8kE5iLdTrksDbXYB6M1pUwqtiEiCCc5aWwzsUpazjWuNxCHUlrsdQN7YMp9R06AmRndl7GWc93ZIgJOECqcIfxOn2LpUSZWe/4D5GLrwYk/NqfS4hiLHyW2g+kbWEQz0f1ELpw32v5diDidAK2WrfRKW/gP3SLW8c3g+eF9lKQa28bTmDG0eys4AhdSoH1Da1fEVnzUXzmLtmAj5MQ5xQ3yM4tK2771kA1UAgk0= spamdiagnosticoutput: 1:22 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 21388b91-c836-4e69-7ba5-08d5b2bbc1f5 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21388b91-c836-4e69-7ba5-08d5b2bbc1f5 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2018 19:09:42.4106 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3626 Subject: Re: [dpdk-dev] [PATCH v7 3/5] iFPGA: Add Intel FPGA BUS Rawdev Driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sat, 05 May 2018 19:09:47 -0000 Though I had already acked this, I had a quick comment: > -----Original Message----- > From: Xu, Rosen [mailto:rosen.xu@intel.com] > Sent: Friday, May 4, 2018 7:41 PM > To: dev@dpdk.org > Cc: rosen.xu@intel.com; declan.doherty@intel.com; > bruce.richardson@intel.com; Shreyansh Jain <shreyansh.jain@nxp.com>; > ferruh.yigit@intel.com; konstantin.ananyev@intel.com; > tianfei.zhang@intel.com; song.liu@intel.com; hao.wu@intel.com; > gaetan.rivet@6wind.com; Yanglong Wu <yanglong.wu@intel.com> > Subject: [PATCH v7 3/5] iFPGA: Add Intel FPGA BUS Rawdev Driver >=20 > From: Rosen Xu <rosen.xu@intel.com> >=20 > Add Intel FPGA BUS Rawdev Driver which is based on > librte_rawdev library. >=20 > Signed-off-by: Rosen Xu <rosen.xu@intel.com> > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com> > Signed-off-by: Figo zhang <tianfei.zhang@intel.com> > --- [...] > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index f47bbe8..b0a994f 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -253,6 +253,7 @@ endif # CONFIG_RTE_LIBRTE_EVENTDEV >=20 > ifeq ($(CONFIG_RTE_LIBRTE_RAWDEV),y) > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV) +=3D - > lrte_pmd_skeleton_rawdev > +_LDLIBS-$(CONFIG_RTE_LIBRTE_IFPGA_RAWDEV) +=3D -lrte_ifpga_rawdev > endif # CONFIG_RTE_LIBRTE_RAWDEV This driver is dependent on CONFIG_RTE_LIBRTE_IFPGA_BUS and if someone disa= bles that, it would lead to build issues. I think you should enclose the IF= PGA_RAWDEV compilation into conditional for CONFIG_RTE_LIBRTE_IFPGA_BUS=3Dy= . Though, I do faintly remember a discussion in past that such thing should/c= an be left to individual environment configuration and it can be safely ass= umed that such erroneous configuration would be user-responsibility (at lea= st until a dependency based configuration system is available in DPDK). So,= it is a good-to-have rather a necessity. >=20 >=20 > -- > 1.8.3.1