From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50046.outbound.protection.outlook.com [40.107.5.46]) by dpdk.org (Postfix) with ESMTP id 234DB5F21 for ; Wed, 28 Mar 2018 09:19:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=acxq4dz4Z8b7KIcR9U07oT29lJktlw7PpVmGcSF8MSU=; b=F7FrQMxoWo6al8DVToSk+W2oiF5V3dGSTJ1Chr9nQmmNAd8JWr0AfT34MZsI/5FKwYE5NEesMVC8kNPSu6cp/Qr9FY2btuGVyr1M6lIOCv62IWvXWhNs07RaMT0BcIUrCK96ImqYvrKVt2UCrfC8M1a9/ksg+Ui8KPWx5IPWghU= Received: from HE1PR0402MB2780.eurprd04.prod.outlook.com (10.175.29.14) by HE1PR0402MB3625.eurprd04.prod.outlook.com (10.167.126.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.609.10; Wed, 28 Mar 2018 07:19:12 +0000 Received: from HE1PR0402MB2780.eurprd04.prod.outlook.com ([fe80::cd9:8128:3f1d:710e]) by HE1PR0402MB2780.eurprd04.prod.outlook.com ([fe80::cd9:8128:3f1d:710e%14]) with mapi id 15.20.0631.010; Wed, 28 Mar 2018 07:19:12 +0000 From: Shreyansh Jain To: Remy Horton , "dev@dpdk.org" CC: John McNamara , Wenzhuo Lu , Jingjing Wu , Qi Zhang , Beilei Xing , Thomas Monjalon Thread-Topic: [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters Thread-Index: AQHTwSDRoWEca/fmyky+0S5GnWI2K6PlReug Date: Wed, 28 Mar 2018 07:18:53 +0000 Deferred-Delivery: Wed, 28 Mar 2018 07:17:59 +0000 Message-ID: References: <20180321142749.27520-1-remy.horton@intel.com> <20180321142749.27520-5-remy.horton@intel.com> In-Reply-To: <20180321142749.27520-5-remy.horton@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [92.121.36.198] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0402MB3625; 7:4bczYPyQnuuPwPPdsbS934f3mD1V452AxJxe7bhjRxnG812r8zTPGo7G4jxXLUTE8sMLeLxydISwKu1lYAeCRK0h3OGu2B502RoYgAZXk6E//oM3Gt4V4BWgu4AsWczsVpcOy4xbB+gMURhM29erEmw38jfXB5LDPpuaSkcaw7VANg/2bShHGlTicxcvHsL3jSM4W8BdgRS7paux6dpsOh5Hnc2CODLU7sQ9AI29UtQPXtlpOHrfsk8dfkKPSPbo x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 95214371-464a-4cf1-b2f7-08d5947c3498 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0402MB3625; x-ms-traffictypediagnostic: HE1PR0402MB3625: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231221)(944501327)(52105095)(6055026)(6041310)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(6072148)(201708071742011); SRVR:HE1PR0402MB3625; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0402MB3625; x-forefront-prvs: 06259BA5A2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6029001)(366004)(376002)(346002)(396003)(39380400002)(39860400002)(199004)(189003)(13464003)(2900100001)(76176011)(33656002)(99286004)(5660300001)(81156014)(53936002)(66066001)(97736004)(7696005)(106356001)(2906002)(575784001)(3660700001)(2501003)(105586002)(9686003)(5250100002)(86362001)(8676002)(25786009)(6666003)(6436002)(6506007)(4326008)(26005)(54906003)(81166006)(316002)(3280700002)(3846002)(53546011)(11346002)(6346003)(74316002)(186003)(476003)(8936002)(305945005)(110136005)(55016002)(102836004)(14454004)(7736002)(229853002)(6246003)(478600001)(68736007)(446003)(6116002)(486005)(486005); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0402MB3625; H:HE1PR0402MB2780.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-microsoft-antispam-message-info: qdApgkAnUsD0xV5on9uyBRb9+Zrx/+QDtgkBt23ogiKyF0BRgrNL53QpExuPAV7GHpSIKCqe0H5A/KjBJrWhnaOYodM5nH3xOgg+xOqyy8Yx67j1qATSLCtA7ksqOriquIEdq0aU+CLVy0CyOjK/brsy/XoCsmyqfSEkwGEPznjB4FQvwzDsvQzXI008D3K65LK4fbDXl+yfbCH226lxRdYcQdlVF/9Fp40KhkQBfw5r7vLAyQTZstHr1mQKF2sUzJ9i3qoXSQI99V5oJz3WFBJy8mAKIaGGRYhCXJLc6TuQ+v8phCdbmMNMzo7riKfKO5zUlul6xoZLb7UdT4UuiA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95214371-464a-4cf1-b2f7-08d5947c3498 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2018 07:19:12.0665 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3625 Subject: Re: [dpdk-dev] [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 07:19:14 -0000 Hello Remy, > -----Original Message----- > From: Remy Horton [mailto:remy.horton@intel.com] > Sent: Wednesday, March 21, 2018 7:58 PM > To: dev@dpdk.org > Cc: John McNamara ; Wenzhuo Lu > ; Jingjing Wu ; Qi Zhang > ; Beilei Xing ; Shreyansh > Jain ; Thomas Monjalon > Subject: [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters >=20 > The optimal values of several transmission & reception related > parameters, such as burst sizes, descriptor ring sizes, and number > of queues, varies between different network interface devices. This > patch allows testpmd to make use of per-PMD tuned parameter values. >=20 > Signed-off-by: Remy Horton > --- > app/test-pmd/testpmd.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 4c0e258..82eb197 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -210,9 +210,10 @@ queueid_t nb_txq =3D 1; /**< Number of TX queues per > port. */ >=20 > /* > * Configurable number of RX/TX ring descriptors. > + * Defaults are supplied by drivers via ethdev. > */ > -#define RTE_TEST_RX_DESC_DEFAULT 1024 > -#define RTE_TEST_TX_DESC_DEFAULT 1024 > +#define RTE_TEST_RX_DESC_DEFAULT 0 > +#define RTE_TEST_TX_DESC_DEFAULT 0 > uint16_t nb_rxd =3D RTE_TEST_RX_DESC_DEFAULT; /**< Number of RX > descriptors. */ > uint16_t nb_txd =3D RTE_TEST_TX_DESC_DEFAULT; /**< Number of TX > descriptors. */ Can the change for burst size too be accommodated in this patch? I looked through them and they might not be as trivial as the change above = - but if that is incorporated in this, it might serve as example for other = applications. Or, I am also OK sending a separate patch for that change (maybe for iofwd = case, at least) Either way: Acked-by: Shreyansh Jain