From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0064.outbound.protection.outlook.com [104.47.1.64]) by dpdk.org (Postfix) with ESMTP id D245B1B642 for ; Wed, 9 May 2018 15:53:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MzuDfKOsKKA8H62BEfT/0igYjVAXOhyKMPvrINGBlpE=; b=IteCNlWAtu4S9qr/5QF96PvYdtXqCwA16QyjQ/1B4KtyS9Du9gR1Z4MFsGSrvJOgm7mG1PH3kAflvNaKPkfabdV7Vm6XcLxANyRJoQ9jtUt5a5OJ6ZSrmH9mnW/lZrwvOqNnmJ0CJRfMVTrg+2dcMuhK9i4xG22e7kYkqMYmuKM= Received: from HE1PR0501MB2314.eurprd05.prod.outlook.com (10.168.34.19) by HE1PR0501MB3593.eurprd05.prod.outlook.com (10.166.196.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.17; Wed, 9 May 2018 13:53:24 +0000 Received: from HE1PR0501MB2314.eurprd05.prod.outlook.com ([fe80::1071:70d0:eac1:5d97]) by HE1PR0501MB2314.eurprd05.prod.outlook.com ([fe80::1071:70d0:eac1:5d97%18]) with mapi id 15.20.0735.021; Wed, 9 May 2018 13:53:24 +0000 From: Ophir Munk To: =?iso-8859-1?Q?Ga=EBtan_Rivet?= CC: "dev@dpdk.org" , Thomas Monjalon , "Olga Shern" , Shahaf Shuler Thread-Topic: [PATCH v1] net/failsafe: report on supported RSS functions Thread-Index: AQHT5vbIGjVFr0fXw0KAtIKWkrot7KQnTKKAgAAeeUA= Date: Wed, 9 May 2018 13:53:24 +0000 Message-ID: References: <1525802561-9011-1-git-send-email-ophirmu@mellanox.com> <20180509120011.oyftrzgm74tmbwhk@bidouze.vm.6wind.com> In-Reply-To: <20180509120011.oyftrzgm74tmbwhk@bidouze.vm.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0501MB3593; 7:0P12/Cu44Mn3l6oj5KhdnD7SCbYDxA+K3Lggqvv40oqcKotz96xbX4HgdGxbbxT5abAtIi9+UKgwe8F4aUsHAxyGhBAMQx0T/F/C4k8Gs9azucYTXnUwEBhq+Sjx0NJGTjoNLIgGJlGwRkoZ+qdV6H8ubNuR/VxUc6cH9/YsPQKjAltxczamVOBgYTD26XrbhZNj3R2vPDS5sK0oeIPntAhxaqm9Ty8r41NApgNsIiwRaHh6KX0biuvLDT4KKxyQ x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB3593; x-ms-traffictypediagnostic: HE1PR0501MB3593: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:HE1PR0501MB3593; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB3593; x-forefront-prvs: 0667289FF8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(376002)(39380400002)(366004)(396003)(189003)(13464003)(199004)(14454004)(6246003)(107886003)(305945005)(316002)(81156014)(81166006)(8676002)(25786009)(4326008)(53936002)(5660300001)(446003)(478600001)(11346002)(2906002)(68736007)(476003)(3280700002)(74316002)(2900100001)(3660700001)(86362001)(105586002)(33656002)(186003)(9686003)(7696005)(5250100002)(106356001)(26005)(99286004)(486006)(55016002)(54906003)(6116002)(3846002)(7736002)(102836004)(66066001)(6916009)(229853002)(6436002)(76176011)(97736004)(6506007)(8936002)(53546011); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB3593; H:HE1PR0501MB2314.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 33f0kHhzXx+Qb1ASKiLIcoMtzXK6hYdjlsJaa0OHA9g7wqXv31UtpSDkoU9zAxMwSvU7sLA65DdFNiDJKulv8/Yw2Ap3VQjry9zYlL1xkHmjlklF2fnLfsVmIKzYP/FYttfMklWnw7xorIhwDxTk8uuSX+yxCNzwRFtXpxwJj3x6iFNL9E7gMle9XjHoks4N spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: fd315051-7300-4452-21f2-08d5b5b43be2 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd315051-7300-4452-21f2-08d5b5b43be2 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2018 13:53:24.4959 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB3593 Subject: Re: [dpdk-dev] [PATCH v1] net/failsafe: report on supported RSS functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 13:53:27 -0000 Hi, PATCH v2 was sent=20 > -----Original Message----- > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > Sent: Wednesday, May 09, 2018 3:00 PM > To: Ophir Munk > Cc: dev@dpdk.org; Thomas Monjalon ; Olga Shern > ; Shahaf Shuler > Subject: Re: [PATCH v1] net/failsafe: report on supported RSS functions >=20 > Hi Ophir, >=20 > The commit title could read: >=20 > net/failsafe: advertize supported RSS functions >=20 > Some nitpicks in the commit log: >=20 > On Tue, May 08, 2018 at 06:02:41PM +0000, Ophir Munk wrote: > > Report on failsafe supported RSS functions as part of dev_infos_get > ^^^^^^^^^ > Advertize >=20 > > callback. Set failsafe default RSS hash functions to be: ETH_RSS_IP, > > ETH_RSS_UDP and ETH_RSS_TCP. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ >=20 > Better on its own line: >=20 > ETH_RSS_IP, ETH_RSS_UDP, and ETH_RSS_TCP. >=20 >=20 > > The net result of failsafe RSS hash functions is the logical AND of > ^^^ > should be removed >=20 > > the RSS hash functions among all failsafe sub_devices and failsafe own > > defaults. > > > > Previous to this commit RSS support was reported as none. Since the > > introduction of [1] it is required that all RSS configurations will be > ^^^^ > should b= e > removed > > verified. > > > > [1] commit 8863a1fbfc66 ("ethdev: add supported hash function check") > > > > Signed-off-by: Ophir Munk > > --- > > drivers/net/failsafe/failsafe_ops.c | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/failsafe/failsafe_ops.c > > b/drivers/net/failsafe/failsafe_ops.c > > index 6d44884..d18b793 100644 > > --- a/drivers/net/failsafe/failsafe_ops.c > > +++ b/drivers/net/failsafe/failsafe_ops.c > > @@ -83,7 +83,10 @@ static struct rte_eth_dev_info default_infos =3D { > > DEV_TX_OFFLOAD_UDP_CKSUM | > > DEV_TX_OFFLOAD_TCP_CKSUM | > > DEV_TX_OFFLOAD_TCP_TSO, > > - .flow_type_rss_offloads =3D 0x0, > > + .flow_type_rss_offloads =3D > > + ETH_RSS_IP | > > + ETH_RSS_UDP | > > + ETH_RSS_TCP, > > }; > > > > static int > > @@ -805,26 +808,29 @@ fs_dev_infos_get(struct rte_eth_dev *dev, > > } else { > > uint64_t rx_offload_capa; > > uint64_t rxq_offload_capa; > > + uint64_t rss_offloads_hf; >=20 > The name would read better as rss_hf_offload_capa. >=20 > rss_hash_function_offload_capa is easier to understand than > rss_offloads_hash_function. >=20 > > > > rx_offload_capa =3D default_infos.rx_offload_capa; > > rxq_offload_capa =3D default_infos.rx_queue_offload_capa; > > + rss_offloads_hf =3D default_infos.flow_type_rss_offloads; > > FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) { > > rte_eth_dev_info_get(PORT_ID(sdev), > > &PRIV(dev)->infos); > > rx_offload_capa &=3D PRIV(dev)- > >infos.rx_offload_capa; > > rxq_offload_capa &=3D > > PRIV(dev)- > >infos.rx_queue_offload_capa; > > + rss_offloads_hf &=3D > > + PRIV(dev)- > >infos.flow_type_rss_offloads; > > } > > sdev =3D TX_SUBDEV(dev); > > rte_eth_dev_info_get(PORT_ID(sdev), &PRIV(dev)->infos); > > PRIV(dev)->infos.rx_offload_capa =3D rx_offload_capa; > > PRIV(dev)->infos.rx_queue_offload_capa =3D > rxq_offload_capa; > > + PRIV(dev)->infos.flow_type_rss_offloads =3D rss_offloads_hf; > > PRIV(dev)->infos.tx_offload_capa &=3D > > default_infos.tx_offload_capa; > > PRIV(dev)->infos.tx_queue_offload_capa &=3D > > > default_infos.tx_queue_offload_capa; > > - PRIV(dev)->infos.flow_type_rss_offloads &=3D > > - > default_infos.flow_type_rss_offloads; > > } > > rte_memcpy(infos, &PRIV(dev)->infos, sizeof(*infos)); } > > -- > > 2.7.4 > > >=20 > With those nitpicks fixed, > Acked-by: Gaetan Rivet >=20 > -- > Ga=EBtan Rivet > 6WIND