From: Ophir Munk <ophirmu@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Olga Shern <olgas@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
Date: Wed, 9 May 2018 10:31:51 +0000 [thread overview]
Message-ID: <HE1PR0501MB2314DBD7C0C2C656EE92BD7AD1990@HE1PR0501MB2314.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <DB7PR05MB4426821A96E6F95698AB7436C3990@DB7PR05MB4426.eurprd05.prod.outlook.com>
Sure. Agreed.
Regards,
Ophir
> -----Original Message-----
> From: Shahaf Shuler
> Sent: Wednesday, May 09, 2018 1:07 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Ophir Munk
> <ophirmu@mellanox.com>
> Cc: dev@dpdk.org; Adrien Mazarguil <adrien.mazarguil@6wind.com>; Olga
> Shern <olgas@mellanox.com>
> Subject: RE: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
>
> Tuesday, May 8, 2018 3:34 PM, Thomas Monjalon:
> > Subject: Re: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
> >
> > 08/05/2018 14:30, Ophir Munk:
> > > +Limitations
> > > +-----------
> > > +
> > > +- CRC stripping is supported by default and this capability is always
> > reported
> > > + as "true". The ability to enable/disable CRC stripping requires OFED
> > version
> > > + 4.3-1.5.0.0 or rdma-core version v18.
> >
> > I think it is better to merge this patch with the one fixing the capability.
> > So we will be able to refer to one atomic commit in the history.
> >
>
> If you agree Ophir I will squash the two patch into one and merge it on mlx4.
> OK?
next prev parent reply other threads:[~2018-05-09 10:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 12:30 Ophir Munk
2018-05-08 12:34 ` Thomas Monjalon
2018-05-09 10:07 ` Shahaf Shuler
2018-05-09 10:31 ` Ophir Munk [this message]
2018-05-09 11:12 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HE1PR0501MB2314DBD7C0C2C656EE92BD7AD1990@HE1PR0501MB2314.eurprd05.prod.outlook.com \
--to=ophirmu@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).