From: Olga Shern <olgas@mellanox.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc : update guide and release notes for mlx5
Date: Wed, 27 Jul 2016 09:41:04 +0000 [thread overview]
Message-ID: <HE1PR0501MB252475599A7BA3BDBE69B0F9D30F0@HE1PR0501MB2524.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2025A815F@IRSMSX103.ger.corp.intel.com>
Thanks John
Sent fixed patch including your comments
Best Regards,
Olga
-----Original Message-----
From: Mcnamara, John [mailto:john.mcnamara@intel.com]
Sent: Wednesday, July 27, 2016 11:18 AM
To: Olga Shern <olgas@mellanox.com>; dev@dpdk.org
Subject: RE: [dpdk-dev] [PATCH] doc : update guide and release notes for mlx5
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olga Shern
> Sent: Tuesday, July 26, 2016 5:29 PM
> To: dev@dpdk.org
> Cc: Olga Shern <olgas@mellanox.com>
> Subject: [dpdk-dev] [PATCH] doc : update guide and release notes for
> mlx5
>
> ...
>
> +* **Updated the mlx5 driver.**
> +
> + The mlx5 driver was updated with changes including the following:
> +
> + * Data path was refactored to bypass Verbs to improve RX and TX
> performance.
> + * Removed compilation parameters for inline send, MLX5_MAX_INLINE, and
> + added command line parameter instead, txq_inline.
> + * Improved TX scatter gather support:
> + Removed compilation parameter MLX5_PMD_SGE_WR_N.
> + Scatter-gather elements is set to the maximum value the NIC supports.
> + Removed linearization logic, this decreases the memory
> + consumption of
> the PMD.
> + * Improved jumbo frames support, by dynamically setting RX scatter
> gather elements
> + according to the MTU and mbuf size,
> + no need for compilation parameter MLX5_PMD_SGE_WR_N.
> +
Hi,
There are 2 whitespace warnings in the patch. If you resubmit can you also put the MLX5 variables in ```` fixed width quotes.
Apart from that:
Acked-by: John McNamara <john.mcnamara@intel.com>
next prev parent reply other threads:[~2016-07-27 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 16:29 Olga Shern
2016-07-27 8:17 ` Mcnamara, John
2016-07-27 9:41 ` Olga Shern [this message]
2016-07-27 9:27 ` [dpdk-dev] [PATCH v2] doc: " Olga Shern
2016-07-27 9:34 ` Nélio Laranjeiro
2016-07-27 10:55 ` Mcnamara, John
2016-07-28 15:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HE1PR0501MB252475599A7BA3BDBE69B0F9D30F0@HE1PR0501MB2524.eurprd05.prod.outlook.com \
--to=olgas@mellanox.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).