From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50041.outbound.protection.outlook.com [40.107.5.41]) by dpdk.org (Postfix) with ESMTP id BE0281B286 for ; Mon, 30 Oct 2017 19:12:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=877YFnPWLb4JFLuTYrSYhahjSToc/SVyHA5px2UA9zo=; b=XrnNvGaQlBFkLs7fj1Mq5u6rNUZPfmvkW/vcoXcBJLIR+3aiSZ4TgelSj5vym+b63FHB2q6kXqGcnb6gBlolYN2fWp0Jfm5M29STBn/eDiepvn1lHMTPWs9MmDYPzlORn8ypoKriAFPqkQaXLQ6QMXY264CLAXF9qq6djW9Aons= Received: from HE1PR0502MB3659.eurprd05.prod.outlook.com (10.167.127.17) by AM3PR05MB1252.eurprd05.prod.outlook.com (10.163.7.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Mon, 30 Oct 2017 18:12:22 +0000 Received: from HE1PR0502MB3659.eurprd05.prod.outlook.com ([fe80::c524:908c:b99c:3f4b]) by HE1PR0502MB3659.eurprd05.prod.outlook.com ([fe80::c524:908c:b99c:3f4b%13]) with mapi id 15.20.0178.012; Mon, 30 Oct 2017 18:12:22 +0000 From: Matan Azrad To: Adrien Mazarguil CC: "dev@dpdk.org" , Ophir Munk Thread-Topic: [PATCH v3 3/7] net/mlx4: merge Tx path functions Thread-Index: AQHTUYqwFEo246UsIE+oaeX/Q4/QnaL8sgWg Date: Mon, 30 Oct 2017 18:12:22 +0000 Message-ID: References: <1508768520-4810-1-git-send-email-ophirmu@mellanox.com> <1509358049-18854-1-git-send-email-matan@mellanox.com> <1509358049-18854-4-git-send-email-matan@mellanox.com> <20171030142330.GZ26782@6wind.com> In-Reply-To: <20171030142330.GZ26782@6wind.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [85.64.136.190] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM3PR05MB1252; 6:MMJ5vofvHcYmLrwJ7gZ9BtN37EBcJ0dtkkDyxIm4aYGPKvKjmiG2WtstolT9wegACPm15xCpgHCMWggRQXtA1QnG5sN7/lXRs3gIUhGe7V5FOj7aiI/SGTEiQQJeR8hIro/xIpdDwWlVAJoqyOTVOj3pbV1rHq6GF9hAeoXOXKhS4dpwmK/LpJJUn6EvVgUrjOT9tFa5jsQCUGR+n/nPXzP3CJz7ZF2ylStRwpBL2Ky426IEb9n8Ed/LxHBBNEsrqQPUUa239YtYwDMqDi374Ggpi1XQKJBi1JlKn5M7RJ3ALnLCC7zuQy7y/WFkca4mccsKTQfAuiGh362bgmCbN+BOz6OSYxzinMFd2J0byjY=; 5:qPIM5p+kkHEwAeWjKHnihXt7ujdat6i96w/SQE73Is4HblhPYWo0kmTWwQQzH7NYQ+toEBlHtTlmF/b+bQ9TTT1LDpEiC/78dnB8l3m7bScgGHy4DGW2Eb0crKy8veTa6PJ3rieQjL8V/wSQBbKagi9vduh1+HyBKDQ3IUq7eGg=; 24:u65aFZGHHUQkiTxrgWBy4iwaEJSSrCGRROvcdsIJoJAg7Rec9Hv8J16+bVRgr/AQ67W/O3/O7ilx0GkuoRJlrhXeja/+kvpBpirqQJ9kyRI=; 7:8F2/J31QT/wIGQSpjs0HHJvh77oi92ZCFDAKumXqG2LmuHjGhmPtsq+rW1cjw7EbFggkNLNdWJMua0b22ekX/+/IGwug3IOc44dW59Bd3bO3MtVwL/7O30Vr+Ay6pyFPZ5L8+GJCTMTrmW/lKfkwlMtQfCn+2zREWV6T7zJLOY+9BTS9U7qEmDw4dXoABVzPrkV/JW8AlSY6wHl+fXB4FMF568ZlYNelxEGpQG+g0XBGRVqWgxgrufAsjgLrArVW x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 849dc72f-8abb-499e-e078-08d51fc1c424 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(2017052603199); SRVR:AM3PR05MB1252; x-ms-traffictypediagnostic: AM3PR05MB1252: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231020)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM3PR05MB1252; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM3PR05MB1252; x-forefront-prvs: 0476D4AB88 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(39860400002)(376002)(24454002)(199003)(189002)(13464003)(9686003)(4326008)(2900100001)(3846002)(229853002)(189998001)(6116002)(102836003)(76176999)(54356999)(6246003)(101416001)(66066001)(50986999)(53546010)(107886003)(53936002)(478600001)(3280700002)(33656002)(8676002)(3660700001)(5250100002)(81166006)(5660300001)(81156014)(8936002)(7696004)(2906002)(25786009)(68736007)(97736004)(54906003)(6506006)(74316002)(106356001)(305945005)(6916009)(93886005)(14454004)(2950100002)(55016002)(99286003)(7736002)(316002)(86362001)(6436002)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR05MB1252; H:HE1PR0502MB3659.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 849dc72f-8abb-499e-e078-08d51fc1c424 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2017 18:12:22.1443 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR05MB1252 Subject: Re: [dpdk-dev] [PATCH v3 3/7] net/mlx4: merge Tx path functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 18:12:23 -0000 Ok, thanks! > -----Original Message----- > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > Sent: Monday, October 30, 2017 4:24 PM > To: Matan Azrad > Cc: dev@dpdk.org; Ophir Munk > Subject: Re: [PATCH v3 3/7] net/mlx4: merge Tx path functions >=20 > On Mon, Oct 30, 2017 at 10:07:25AM +0000, Matan Azrad wrote: > > Merge tx_burst and mlx4_post_send functions to prevent double asking > > about WQ remain space. > > > > Signed-off-by: Matan Azrad >=20 > Except for one nit below, >=20 > Acked-by: Adrien Mazarguil >=20 > > --- > > drivers/net/mlx4/mlx4_rxtx.c | 357 > > +++++++++++++++++++++---------------------- > > 1 file changed, 172 insertions(+), 185 deletions(-) > > > > diff --git a/drivers/net/mlx4/mlx4_rxtx.c > > b/drivers/net/mlx4/mlx4_rxtx.c > > > @@ -477,18 +314,168 @@ struct pv { > > } while (tmp !=3D NULL); > > } > > RTE_MBUF_PREFETCH_TO_FREE(elt_next->buf); > > - /* Post the packet for sending. */ > > - err =3D mlx4_post_send(txq, buf); > > - if (unlikely(err)) { > > + >=20 > Extra empty line. >=20 > -- > Adrien Mazarguil > 6WIND