From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0045.outbound.protection.outlook.com [104.47.0.45]) by dpdk.org (Postfix) with ESMTP id CAE9F1D8E; Thu, 14 Dec 2017 11:40:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=d8ttGCccTohERsR+5wKKWi3GOYBNra/nXWj4SUphs6A=; b=pnIy6wy4RZtjPftG7IDv7q0Ra631MJ7+hFmkZJRvVYmKMcmTbWuZbh1Xora1RheX7Sv9luEeqys4pRsQ3Pw4zqiQLAjtJPEDMlzYxqOwh0a97WKTTkWlG6RaHXKcICEGgqWLQKq3V96wsGa+RfaQvrt9epqV9INkpQ8DgYlt9YQ= Received: from HE1PR0502MB3659.eurprd05.prod.outlook.com (10.167.127.17) by HE1PR0502MB3658.eurprd05.prod.outlook.com (10.167.127.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Thu, 14 Dec 2017 10:40:40 +0000 Received: from HE1PR0502MB3659.eurprd05.prod.outlook.com ([fe80::982e:2dce:9449:6891]) by HE1PR0502MB3659.eurprd05.prod.outlook.com ([fe80::982e:2dce:9449:6891%13]) with mapi id 15.20.0282.012; Thu, 14 Dec 2017 10:40:40 +0000 From: Matan Azrad To: Thomas Monjalon , =?iso-8859-1?Q?Ga=EBtan_Rivet?= CC: Adrien Mazarguil , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2 4/4] net/failsafe: fix removed device handling Thread-Index: AQHTdCVqeFZYAzJ0Kk2VOrfpqCAdSKNBZw+wgAAKGACAABDKgIABJa8w Date: Thu, 14 Dec 2017 10:40:40 +0000 Message-ID: References: <1509637324-13525-1-git-send-email-matan@mellanox.com> <20171213160916.e3rmxmhfhqz72wco@bidouze.vm.6wind.com> <302650745.DN0YeEHu4l@xps> In-Reply-To: <302650745.DN0YeEHu4l@xps> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0502MB3658; 6:Df8Cp+88IwK603b90MqB+5THI+AwgXk/KOtG1mboyqQRTFATPzndR2rvBTb/VZaScqtRNf6o/mH/cykjC69Mq1Ohy6n+HrMx6L06geDiNlJqc6I8wCz/Eqn9B8LdQg4OnDTjaeC9c6GPhNXc/qWF9elvS9I/Zm7CGragn7Uaf2m6rmUsCac6ZavXtA+ZCK6VPK0nmaEeRwFvNcoYFFDie8/nCdqYRThvefWvMoEGv25uPuTsGcy9pQT/KULT+Q2Mtk9eClpOkNLtynmEnqoyDJBhA0vtlcCpXKgh6TsqbnNcCuDMnsWXWYuamPQuui7lFqYr1aCVCqX4m16/SJAyqQnm5y8HHZ+kZk27VEomYRA=; 5:cuyjM3uTdxFC1I7/XtbxfVzLIwBpsyClAShFxsCTE5MJ3xJlMZqLnoSIpkiejcP95BzkO5XiWQXJUCB+BP5NzhlB+AJiVU2rUYJ/giT2PgxVNvgBQXuUJvWE19oiF4f0/BTfxd6EQOpzTnbTxYj7DYzKzoWqbc2wD2i4Hi2toOs=; 24:z8rIzsV77KbVn+iWR4MW6kPb7H3Ahfjun2TRW6IBpbKYfD7cg5xTYvTeNtGo+0me2njN4qzJCBzeLWeA/lIWjKc6vgUTpLvDk3hM4/TjrQY=; 7:vAAKDvfeqDeNc44UoAe2gVzCaOamSnpiZiI6IwbF4rbahK41FdgDhKdRWGtT2hUkpT9ycOoxfT+GgbBIck89hFSZPSUsICSwtASKaIdMtEbsWT6X7FXluMuFbpSbsPFpnQI+WfgIfqli9jNB5yvGDvcUuagdVj5FQK44Xz3ybZsPXsIIUJ67OPeCpnCAavkRJ0wcLsUrH8A0dMJHRT7cVqZDeb3MElk5/PY06BX+lRy8x6H5v5lqgKXRtgi5DgGH x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 13500c16-4347-4705-57d0-08d542df1ee5 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307); SRVR:HE1PR0502MB3658; x-ms-traffictypediagnostic: HE1PR0502MB3658: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231023)(6055026)(6041248)(20161123555025)(20161123562025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011); SRVR:HE1PR0502MB3658; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:HE1PR0502MB3658; x-forefront-prvs: 05214FD68E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(376002)(366004)(346002)(199004)(13464003)(76104003)(24454002)(189003)(229853002)(5660300001)(66066001)(6436002)(6246003)(25786009)(53936002)(68736007)(106356001)(5250100002)(55016002)(53546011)(6506007)(105586002)(3846002)(54906003)(110136005)(102836003)(4326008)(8936002)(2950100002)(316002)(86362001)(93886005)(2900100001)(81156014)(3660700001)(6116002)(97736004)(2906002)(8676002)(14454004)(81166006)(7696005)(3280700002)(305945005)(74316002)(9686003)(478600001)(76176011)(99286004)(7736002)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0502MB3658; H:HE1PR0502MB3659.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13500c16-4347-4705-57d0-08d542df1ee5 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2017 10:40:40.4405 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0502MB3658 Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2017 10:40:42 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, December 13, 2017 7:09 PM > To: Ga=EBtan Rivet ; Matan Azrad > > Cc: Adrien Mazarguil ; dev@dpdk.org; > stable@dpdk.org > Subject: Re: [PATCH v2 4/4] net/failsafe: fix removed device handling >=20 > 13/12/2017 17:09, Ga=EBtan Rivet: > > On Wed, Dec 13, 2017 at 03:48:46PM +0000, Matan Azrad wrote: > > > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > > > > > Fixes: a46f8d5 ("net/failsafe: add fail-safe PMD") > > > > > Fixes: b737a1e ("net/failsafe: support flow API") > > > > > Cc: stable@dpdk.org > > > > > > > > > > > > > This patch is not a fix. > > > > It relies on an eth_dev API evolution. Without this evolution, > > > > this patch is meaningless and would break compilation if backported= in > stable branch. > > > > > > > > > > It is a fix because the bug is finally solved by this patch. > > > I agree that it cannot be backported itself, but maybe all the series= should > be backported. > > > Other idea: > > > Add new patch which documents the bug and backport it. > > > Remove it in this patch and remove cc stable from it. > > > What do you think? > > > > > > > I think you could write a crude version that would not rely on the > > ethdev evolution (checking sdev->remove only), which would be > > incomplete but still better than nothing. > > And why not in this patch document the issue. > > Without any dependency outside failsafe, this could be backported. > > > > Then complete the fix with the API evolution if the new devops is > > accepted. >=20 > I think it is not worth the effort. > It is a limitation in earlier releases and will be properly fixed with th= e new op. > Please just remove the Cc:stable@dpdk.org. OK.