From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0075.outbound.protection.outlook.com [104.47.2.75]) by dpdk.org (Postfix) with ESMTP id 987851D8E for ; Sun, 3 Dec 2017 14:46:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lJ5vbZnilcnrIVi8VuI0CrLhCUpF3iMb5D694+k568o=; b=S6OfHg0mukMAY7U0vcIRjlfZvAmd+knDQknrspDl7LXmbbvS8PczM+euyCxNOQFTeBFQvQB6BttbfJy73akn0mWbGgC5yKuT6piI5mhDVsSOMKfx20dzi/9+4784SFNS2StKLtThYhHDKEeFQPiCXqZu5c5FoCfGoPYAmr/NFM4= Received: from HE1PR0502MB3659.eurprd05.prod.outlook.com (10.167.127.17) by HE1PR0502MB3660.eurprd05.prod.outlook.com (10.167.127.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Sun, 3 Dec 2017 13:46:50 +0000 Received: from HE1PR0502MB3659.eurprd05.prod.outlook.com ([fe80::982e:2dce:9449:6891]) by HE1PR0502MB3659.eurprd05.prod.outlook.com ([fe80::982e:2dce:9449:6891%13]) with mapi id 15.20.0282.007; Sun, 3 Dec 2017 13:46:49 +0000 From: Matan Azrad To: "Ananyev, Konstantin" , Neil Horman , =?iso-8859-1?Q?Ga=EBtan_Rivet?= CC: Thomas Monjalon , "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership Thread-Index: AQHTaEBDeXaioloFskiHncvIK1YNTKMs3xqAgAANj4CAAX1kAIAC1eJggAA+JgCAABoCUA== Date: Sun, 3 Dec 2017 13:46:49 +0000 Message-ID: References: <1511870281-15282-1-git-send-email-matan@mellanox.com> <1511870281-15282-3-git-send-email-matan@mellanox.com> <20171130123611.GA20914@hmswarspite.think-freely.org> <20171130132443.4htutb5gpktcshgh@bidouze.vm.6wind.com> <20171201120946.GA23598@hmswarspite.think-freely.org> <2601191342CEEE43887BDE71AB9772585FAC3E77@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772585FAC3E77@irsmsx105.ger.corp.intel.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0502MB3660; 6:4jj3993GqWZYrQS7xAf/vo85DrE5eHUO7VYLqEFKlrDQCX9/Xs6btfEWq2JEksNwXwhtK6uuwgj2MZmOx1UPZmS6ZPxQr9uZqz2K/F//Eto0yVCFSknBARUFpnYGK/q6GAQ1xeGeLdwjLIFm3OkAerXaet73ewv5itfMH8Jfj94KZ+hllKYJ9TtIKNkux09JKcOhtUGFvicxNvoS9oW+gZnsFPx8lvGZPSDhh0K1wtglZDm1kcq+fiaW40CUsLC748ZOxR406s99rzkD3ps9dMBK1Jg0I/XKtZrKzEkj3Zqilub35fKWjS/3Dwcr/7g9QH0H00s/35BXpzrCBDd/cqeA46nQfccBFYpKsIn5O1U=; 5:liYceYcwSN5olc3fjyF3OyrNcfoWNu3SOKfXJe4ktjoKeFOlcCQMFBBN+Lkxt0UORPPUjHqaTqLA5BVpzNFJXqNHjL3OkNZcpnqUI1heIuoHu8eXw/r7oP2tp2bwCo+d14m0/gI8r0LNH8fHmOiiGX8EuzzrNdocqxb3dTzKeSA=; 24:VLqz1UKjjMaKHqbaghjtycxYzHMRGzfO5ZGSfINkCI1KqcrgiY8k0T+bEmSkkSWUEhFHcdEKGE/ELBGTPGEWcfCYvWtcLQqBY3TsRZriZl0=; 7:ECBJvfGeZ7RoR2wpsZvcIUbEeolk4yaalfQ/vqeg1WmcdGVcyqIyGTogiLxF16ZKNLnQo0iRv695acQHzG373tm5C/wttngd6Fs4IKKpBHnphCnbmIzKaY1lGoE2MyRwCuhC6lfaqSwEKtAV1veFBmm01FylWHssiLkVCS+MaT5IYe1CfkNc1of4SQKrNCBSlWYbPlKpn/+nfS65n+macgh7fDNYyJrZ6IjkfZvh4JIFN0aax19tdRY2seLZUL12 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 9ad0c7fa-f2d8-4545-758f-08d53a544dcf x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603286); SRVR:HE1PR0502MB3660; x-ms-traffictypediagnostic: HE1PR0502MB3660: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(60795455431006)(278428928389397)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3231022)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123562025)(20161123560025)(6072148)(201708071742011); SRVR:HE1PR0502MB3660; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:HE1PR0502MB3660; x-forefront-prvs: 05102978A2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(366004)(39860400002)(199003)(24454002)(189002)(13464003)(54075001)(68736007)(86362001)(575784001)(97736004)(4326008)(5890100001)(25786009)(3846002)(102836003)(55016002)(110136005)(6436002)(478600001)(189998001)(9686003)(6116002)(316002)(53946003)(6246003)(14454004)(53936002)(74316002)(33656002)(2950100002)(7736002)(81166006)(81156014)(53546010)(99286004)(2900100001)(5660300001)(6506006)(66066001)(3660700001)(8676002)(54906003)(93886005)(229853002)(305945005)(105586002)(5250100002)(3280700002)(101416001)(106356001)(2906002)(8936002)(7696005)(54356011)(76176011)(579004); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0502MB3660; H:HE1PR0502MB3659.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ad0c7fa-f2d8-4545-758f-08d53a544dcf X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2017 13:46:49.9117 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0502MB3660 Subject: Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Dec 2017 13:46:52 -0000 Hi Konstantine > -----Original Message----- > From: Ananyev, Konstantin [mailto:konstantin.ananyev@intel.com] > Sent: Sunday, December 3, 2017 1:10 PM > To: Matan Azrad ; Neil Horman > ; Ga=EBtan Rivet > Cc: Thomas Monjalon ; Wu, Jingjing > ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership >=20 >=20 >=20 > Hi Matan, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matan Azrad > > Sent: Sunday, December 3, 2017 8:05 AM > > To: Neil Horman ; Ga=EBtan Rivet > > > > Cc: Thomas Monjalon ; Wu, Jingjing > > ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership > > > > Hi > > > > > -----Original Message----- > > > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > > Sent: Friday, December 1, 2017 2:10 PM > > > To: Ga=EBtan Rivet > > > Cc: Matan Azrad ; Thomas Monjalon > > > ; Jingjing Wu ; > > > dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership > > > > > > On Thu, Nov 30, 2017 at 02:24:43PM +0100, Ga=EBtan Rivet wrote: > > > > Hello Matan, Neil, > > > > > > > > I like the port ownership concept. I think it is needed to clarify > > > > some operations and should be useful to several subsystems. > > > > > > > > This patch could certainly be sub-divided however, and your > > > > current > > > > 1/5 should probably come after this one. > > > > > > > > Some comments inline. > > > > > > > > On Thu, Nov 30, 2017 at 07:36:11AM -0500, Neil Horman wrote: > > > > > On Tue, Nov 28, 2017 at 11:57:58AM +0000, Matan Azrad wrote: > > > > > > The ownership of a port is implicit in DPDK. > > > > > > Making it explicit is better from the next reasons: > > > > > > 1. It may be convenient for multi-process applications to know > which > > > > > > process is in charge of a port. > > > > > > 2. A library could work on top of a port. > > > > > > 3. A port can work on top of another port. > > > > > > > > > > > > Also in the fail-safe case, an issue has been met in testpmd. > > > > > > We need to check that the user is not trying to use a port > > > > > > which is already managed by fail-safe. > > > > > > > > > > > > Add ownership mechanism to DPDK Ethernet devices to avoid > > > > > > multiple management of a device by different DPDK entities. > > > > > > > > > > > > A port owner is built from owner id(number) and owner > > > > > > name(string) while the owner id must be unique to distinguish > > > > > > between two identical entity instances and the owner name can b= e > any name. > > > > > > The name helps to logically recognize the owner by different > > > > > > DPDK entities and allows easy debug. > > > > > > Each DPDK entity can allocate an owner unique identifier and > > > > > > can use it and its preferred name to owns valid ethdev ports. > > > > > > Each DPDK entity can get any port owner status to decide if it > > > > > > can manage the port or not. > > > > > > > > > > > > The current ethdev internal port management is not affected by > > > > > > this feature. > > > > > > > > > > > > > > The internal port management is not affected, but the external > > > > interface is, however. In order to respect port ownership, > > > > applications are forced to modify their port iterator, as shown by > > > > your > > > testpmd patch. > > > > > > > > I think it would be better to modify the current > > > > RTE_ETH_FOREACH_DEV to call RTE_FOREACH_DEV_OWNED_BY, and > > > > introduce a default owner that would represent the application > > > > itself (probably with the ID 0 and an owner string ""). Only with > > > > specific additional configuration should this default subset of eth= dev be > divided. > > > > > > > > This would make this evolution seamless for applications, at no > > > > cost to the complexity of the design. > > > > > > > > > > Signed-off-by: Matan Azrad > > > > > > > > > > > > > > > This seems fairly racy. What if one thread attempts to set > > > > > ownership on a port, while another is checking it on another cpu > > > > > in parallel. It doesn't seem like it will protect against that a= t all. > > > > > It also doesn't protect against the possibility of multiple > > > > > threads attempting to poll for rx in parallel, which I think was > > > > > part of Thomas's origional statement regarding port ownership > > > > > (he noted that the lockless design implied only a single thread > > > > > should be allowed to poll > > > for receive or make configuration changes at a time. > > > > > > > > > > Neil > > > > > > > > > > > > > Isn't this race already there for any configuration operation / > > > > polling function? The DPDK arch is expecting applications to solve = it. > > > > Why should port ownership be designed differently from other DPDK > > > components? > > > > > > > Yes, but that doesn't mean it should exist in purpituity, nor does > > > it mean that your new api should contain it as well. > > > > > > > Embedding checks for port ownership within operations will force > > > > everyone to bear their costs, even those not interested in using > > > > this API. These checks should be kept outside, within the entity > > > > claiming ownership of the port, in the form of using the proper > > > > port iterator IMO. > > > > > > > No. At the very least, you need to make the API itself exclusive. > > > That is to say, you should at least ensure that a port ownership get > > > call doesn't race with a port ownership set call. It seems > > > rediculous to just leave that sort of locking as an exercize to the u= ser. > > > > > > Neil > > > > > Neil, > > As Thomas mentioned, a DPDK port is designed to be managed by only one > > thread (or synchronized DPDK entity). > > So all the port management includes port ownership shouldn't be > > synchronized, i.e. locks are not needed. > > If some application want to do dual thread port management, the > > responsibility to synchronize the port ownership or any other port > > management is on this application. > > Port ownership doesn't come to allow synchronized management of the > > port by two DPDK entities in parallel, it is just nice way to answer ne= xt > questions: > > 1. Is the port already owned by some DPDK entity(in early control > path)? > > 2. If yes, Who is the owner? > > If the answer to the first question is no, the current entity can take > > the ownership without any lock(1 thread). > > If the answer to the first question is yes, you can recognize the > > owner and take decisions accordingly, sometimes you can decide to use > > the port because you logically know what the current owner does and > > you can be logically synchronized with it, sometimes you can just > > leave this port because you have not any deal with this owner. >=20 > If the goal is just to have an ability to recognize is that device is man= aged by > another device (failsafe, bonding, etc.), then I think all we need is a = pointer > to rte_eth_dev_data of the owner (NULL would mean no owner). I think string is better than a pointer from the next reasons: 1. It is more human friendly than pointers for debug and printing. 2. it is flexible and allows to forward logical owner message to other DPDK= entities.=20 > Also I think if we'd like to introduce that mechanism, then it needs to b= e > - mandatory (control API just don't allow changes to the device configura= tion > if caller is not an owner). But what if 2 DPDK entities should manage the same port \ using it and they= are synchronized? > - transparent to the user (no API changes). For now, there is not API change but new suggested API to use for port iter= ation. > - set/get owner ops need to be atomic if we want this mechanism to be > usable for MP. But also without atomic this mechanism is usable in MP. For example: PRIMARY application can set its owner with string "primary A". SECONDARY process (which attach to the ports only after the primary created= them )is not allowed to set owner(As you can see in the code) but it can r= ead the owner string and see that the port owner is the primary application= . The "A" can just sign specific port type to the SECONDARY that this port wo= rks with logic A which means, for example, primary should send the packets = and secondary should receive the packets. > Konstantin >=20 >=20 >=20 >=20 >=20 > > > > > > > > --- > > > > > > doc/guides/prog_guide/poll_mode_drv.rst | 12 +++- > > > > > > lib/librte_ether/rte_ethdev.c | 121 > > > ++++++++++++++++++++++++++++++++ > > > > > > lib/librte_ether/rte_ethdev.h | 86 > +++++++++++++++++++++++ > > > > > > lib/librte_ether/rte_ethdev_version.map | 12 ++++ > > > > > > 4 files changed, 230 insertions(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/doc/guides/prog_guide/poll_mode_drv.rst > > > > > > b/doc/guides/prog_guide/poll_mode_drv.rst > > > > > > index 6a0c9f9..af639a1 100644 > > > > > > --- a/doc/guides/prog_guide/poll_mode_drv.rst > > > > > > +++ b/doc/guides/prog_guide/poll_mode_drv.rst > > > > > > @@ -156,7 +156,7 @@ concurrently on the same tx queue without > > > > > > SW lock. This PMD feature found in som > > > > > > > > > > > > See `Hardware Offload`_ for ``DEV_TX_OFFLOAD_MT_LOCKFREE`` > > > capability probing details. > > > > > > > > > > > > -Device Identification and Configuration > > > > > > +Device Identification, Ownership and Configuration > > > > > > --------------------------------------- > > > > > > > > > > > > Device Identification > > > > > > @@ -171,6 +171,16 @@ Based on their PCI identifier, NIC ports > > > > > > are > > > assigned two other identifiers: > > > > > > * A port name used to designate the port in console messages= , for > > > administration or debugging purposes. > > > > > > For ease of use, the port name includes the port index. > > > > > > > > > > > > +Port Ownership > > > > > > +~~~~~~~~~~~~~ > > > > > > +The Ethernet devices ports can be owned by a single DPDK > > > > > > +entity > > > (application, library, PMD, process, etc). > > > > > > +The ownership mechanism is controlled by ethdev APIs and > > > > > > +allows to > > > set/remove/get a port owner by DPDK entities. > > > > > > +Allowing this should prevent any multiple management of > > > > > > +Ethernet > > > port by different entities. > > > > > > + > > > > > > +.. note:: > > > > > > + > > > > > > + It is the DPDK entity responsibility either to check the > > > > > > + port owner > > > before using it or to set the port owner to prevent others from using= it. > > > > > > + > > > > > > Device Configuration > > > > > > ~~~~~~~~~~~~~~~~~~~~ > > > > > > > > > > > > diff --git a/lib/librte_ether/rte_ethdev.c > > > > > > b/lib/librte_ether/rte_ethdev.c index 2d754d9..836991e 100644 > > > > > > --- a/lib/librte_ether/rte_ethdev.c > > > > > > +++ b/lib/librte_ether/rte_ethdev.c > > > > > > @@ -71,6 +71,7 @@ > > > > > > static const char *MZ_RTE_ETH_DEV_DATA =3D "rte_eth_dev_data"; > > > > > > struct rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS]; > > > > > > static struct rte_eth_dev_data *rte_eth_dev_data; > > > > > > +static uint16_t rte_eth_next_owner_id =3D > RTE_ETH_DEV_NO_OWNER > > > + 1; > > > > > > static uint8_t eth_dev_last_created_port; > > > > > > > > > > > > /* spinlock for eth device callbacks */ @@ -278,6 +279,7 @@ > > > > > > struct rte_eth_dev * > > > > > > if (eth_dev =3D=3D NULL) > > > > > > return -EINVAL; > > > > > > > > > > > > + memset(ð_dev->data->owner, 0, sizeof(struct > > > > > > +rte_eth_dev_owner)); > > > > > > eth_dev->state =3D RTE_ETH_DEV_UNUSED; > > > > > > return 0; > > > > > > } > > > > > > @@ -293,6 +295,125 @@ struct rte_eth_dev * > > > > > > return 1; > > > > > > } > > > > > > > > > > > > +static int > > > > > > +rte_eth_is_valid_owner_id(uint16_t owner_id) { > > > > > > + if (owner_id =3D=3D RTE_ETH_DEV_NO_OWNER || > > > > > > + (rte_eth_next_owner_id !=3D RTE_ETH_DEV_NO_OWNER > && > > > > > > + rte_eth_next_owner_id <=3D owner_id)) { > > > > > > + RTE_LOG(ERR, EAL, "Invalid owner_id=3D%d.\n", > owner_id); > > > > > > + return 0; > > > > > > + } > > > > > > + return 1; > > > > > > +} > > > > > > + > > > > > > +uint16_t > > > > > > +rte_eth_find_next_owned_by(uint16_t port_id, const uint16_t > > > > > > +owner_id) { > > > > > > + while (port_id < RTE_MAX_ETHPORTS && > > > > > > + (rte_eth_devices[port_id].state !=3D > RTE_ETH_DEV_ATTACHED || > > > > > > + rte_eth_devices[port_id].data->owner.id !=3D owner_id)= ) > > > > > > + port_id++; > > > > > > + > > > > > > + if (port_id >=3D RTE_MAX_ETHPORTS) > > > > > > + return RTE_MAX_ETHPORTS; > > > > > > + > > > > > > + return port_id; > > > > > > +} > > > > > > + > > > > > > +int > > > > > > +rte_eth_dev_owner_new(uint16_t *owner_id) { > > > > > > + if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) { > > > > > > + RTE_PMD_DEBUG_TRACE("Not primary process > cannot own > > > ports.\n"); > > > > > > + return -EPERM; > > > > > > + } > > > > > > + if (rte_eth_next_owner_id =3D=3D RTE_ETH_DEV_NO_OWNER) { > > > > > > + RTE_PMD_DEBUG_TRACE("Reached maximum > number of > > > Ethernet port owners.\n"); > > > > > > + return -EUSERS; > > > > > > + } > > > > > > + *owner_id =3D rte_eth_next_owner_id++; > > > > > > + return 0; > > > > > > +} > > > > > > + > > > > > > +int > > > > > > +rte_eth_dev_owner_set(const uint16_t port_id, > > > > > > + const struct rte_eth_dev_owner *owner) { > > > > > > + struct rte_eth_dev_owner *port_owner; > > > > > > + int ret; > > > > > > + > > > > > > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > > > > > > + if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) { > > > > > > + RTE_PMD_DEBUG_TRACE("Not primary process > cannot own > > > ports.\n"); > > > > > > + return -EPERM; > > > > > > + } > > > > > > + if (!rte_eth_is_valid_owner_id(owner->id)) > > > > > > + return -EINVAL; > > > > > > + port_owner =3D &rte_eth_devices[port_id].data->owner; > > > > > > + if (port_owner->id !=3D RTE_ETH_DEV_NO_OWNER && > > > > > > + port_owner->id !=3D owner->id) { > > > > > > + RTE_LOG(ERR, EAL, > > > > > > + "Cannot set owner to port %d already owned > by > > > %s_%05d.\n", > > > > > > + port_id, port_owner->name, port_owner- > >id); > > > > > > + return -EPERM; > > > > > > + } > > > > > > + ret =3D snprintf(port_owner->name, > > > RTE_ETH_MAX_OWNER_NAME_LEN, "%s", > > > > > > + owner->name); > > > > > > + if (ret < 0 || ret >=3D RTE_ETH_MAX_OWNER_NAME_LEN) { > > > > > > + memset(port_owner->name, 0, > > > RTE_ETH_MAX_OWNER_NAME_LEN); > > > > > > + RTE_LOG(ERR, EAL, "Invalid owner name.\n"); > > > > > > + return -EINVAL; > > > > > > + } > > > > > > + port_owner->id =3D owner->id; > > > > > > + RTE_PMD_DEBUG_TRACE("Port %d owner is %s_%05d.\n", > port_id, > > > > > > + owner->name, owner->id); > > > > > > + return 0; > > > > > > +} > > > > > > + > > > > > > +int > > > > > > +rte_eth_dev_owner_remove(const uint16_t port_id, const > > > > > > +uint16_t > > > > > > +owner_id) { > > > > > > + struct rte_eth_dev_owner *port_owner; > > > > > > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > > > > > > + if (!rte_eth_is_valid_owner_id(owner_id)) > > > > > > + return -EINVAL; > > > > > > + port_owner =3D &rte_eth_devices[port_id].data->owner; > > > > > > + if (port_owner->id !=3D owner_id) { > > > > > > + RTE_LOG(ERR, EAL, > > > > > > + "Cannot remove port %d owner %s_%05d by > > > different owner id %5d.\n", > > > > > > + port_id, port_owner->name, port_owner- > >id, > > > owner_id); > > > > > > + return -EPERM; > > > > > > + } > > > > > > + RTE_PMD_DEBUG_TRACE("Port %d owner %s_%05d has > > > removed.\n", port_id, > > > > > > + port_owner->name, port_owner->id); > > > > > > + memset(port_owner, 0, sizeof(struct rte_eth_dev_owner)); > > > > > > + return 0; > > > > > > +} > > > > > > + > > > > > > +void > > > > > > +rte_eth_dev_owner_delete(const uint16_t owner_id) { > > > > > > + uint16_t p; > > > > > > + > > > > > > + if (!rte_eth_is_valid_owner_id(owner_id)) > > > > > > + return; > > > > > > + RTE_ETH_FOREACH_DEV_OWNED_BY(p, owner_id) > > > > > > + memset(&rte_eth_devices[p].data->owner, 0, > > > > > > + sizeof(struct rte_eth_dev_owner)); > > > > > > + RTE_PMD_DEBUG_TRACE("All port owners owned by " > > > > > > + "%05d identifier has removed.\n", > owner_id); } > > > > > > + > > > > > > +const struct rte_eth_dev_owner * rte_eth_dev_owner_get(const > > > > > > +uint16_t port_id) { > > > > > > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, NULL); > > > > > > + if (rte_eth_devices[port_id].data->owner.id =3D=3D > > > RTE_ETH_DEV_NO_OWNER) > > > > > > + return NULL; > > > > > > + return &rte_eth_devices[port_id].data->owner; > > > > > > +} > > > > > > + > > > > > > int > > > > > > rte_eth_dev_socket_id(uint16_t port_id) { diff --git > > > > > > a/lib/librte_ether/rte_ethdev.h > > > > > > b/lib/librte_ether/rte_ethdev.h index 341c2d6..f54c26d 100644 > > > > > > --- a/lib/librte_ether/rte_ethdev.h > > > > > > +++ b/lib/librte_ether/rte_ethdev.h > > > > > > @@ -1760,6 +1760,15 @@ struct rte_eth_dev_sriov { > > > > > > > > > > > > #define RTE_ETH_NAME_MAX_LEN RTE_DEV_NAME_MAX_LEN > > > > > > > > > > > > +#define RTE_ETH_DEV_NO_OWNER 0 > > > > > > + > > > > > > +#define RTE_ETH_MAX_OWNER_NAME_LEN 64 > > > > > > + > > > > > > +struct rte_eth_dev_owner { > > > > > > + uint16_t id; /**< The owner unique identifier. */ > > > > > > + char name[RTE_ETH_MAX_OWNER_NAME_LEN]; /**< The > owner > > > name. */ > > > > > > +}; > > > > > > + > > > > > > /** > > > > > > * @internal > > > > > > * The data part, with no function pointers, associated with > > > > > > each > > > ethernet device. > > > > > > @@ -1810,6 +1819,7 @@ struct rte_eth_dev_data { > > > > > > int numa_node; /**< NUMA node connection */ > > > > > > struct rte_vlan_filter_conf vlan_filter_conf; > > > > > > /**< VLAN filter configuration. */ > > > > > > + struct rte_eth_dev_owner owner; /**< The port owner. */ > > > > > > }; > > > > > > > > > > > > /** Device supports link state interrupt */ @@ -1846,6 > > > > > > +1856,82 @@ struct rte_eth_dev_data { > > > > > > > > > > > > > > > > > > /** > > > > > > + * Iterates over valid ethdev ports owned by a specific owner. > > > > > > + * > > > > > > + * @param port_id > > > > > > + * The id of the next possible valid owned port. > > > > > > + * @param owner_id > > > > > > + * The owner identifier. > > > > > > + * RTE_ETH_DEV_NO_OWNER means iterate over all valid > > > > > > + ownerless > > > ports. > > > > > > + * @return > > > > > > + * Next valid port id owned by owner_id, RTE_MAX_ETHPORTS if > > > there is none. > > > > > > + */ > > > > > > +uint16_t rte_eth_find_next_owned_by(uint16_t port_id, const > > > > > > +uint16_t owner_id); > > > > > > + > > > > > > +/** > > > > > > + * Macro to iterate over all enabled ethdev ports owned by a > > > > > > +specific > > > owner. > > > > > > + */ > > > > > > +#define RTE_ETH_FOREACH_DEV_OWNED_BY(p, o) \ > > > > > > + for (p =3D rte_eth_find_next_owned_by(0, o); \ > > > > > > + (unsigned int)p < (unsigned int)RTE_MAX_ETHPORTS; \ > > > > > > + p =3D rte_eth_find_next_owned_by(p + 1, o)) > > > > > > + > > > > > > +/** > > > > > > + * Get a new unique owner identifier. > > > > > > + * An owner identifier is used to owns Ethernet devices by > > > > > > +only one DPDK entity > > > > > > + * to avoid multiple management of device by different entitie= s. > > > > > > + * > > > > > > + * @param owner_id > > > > > > + * Owner identifier pointer. > > > > > > + * @return > > > > > > + * Negative errno value on error, 0 on success. > > > > > > + */ > > > > > > +int rte_eth_dev_owner_new(uint16_t *owner_id); > > > > > > + > > > > > > +/** > > > > > > + * Set an Ethernet device owner. > > > > > > + * > > > > > > + * @param port_id > > > > > > + * The identifier of the port to own. > > > > > > + * @param owner > > > > > > + * The owner pointer. > > > > > > + * @return > > > > > > + * Negative errno value on error, 0 on success. > > > > > > + */ > > > > > > +int rte_eth_dev_owner_set(const uint16_t port_id, > > > > > > + const struct rte_eth_dev_owner *owner); > > > > > > + > > > > > > +/** > > > > > > + * Remove Ethernet device owner to make the device ownerless. > > > > > > + * > > > > > > + * @param port_id > > > > > > + * The identifier of port to make ownerless. > > > > > > + * @param owner > > > > > > + * The owner identifier. > > > > > > + * @return > > > > > > + * 0 on success, negative errno value on error. > > > > > > + */ > > > > > > +int rte_eth_dev_owner_remove(const uint16_t port_id, const > > > > > > +uint16_t owner_id); > > > > > > + > > > > > > +/** > > > > > > + * Remove owner from all Ethernet devices owned by a specific > > > owner. > > > > > > + * > > > > > > + * @param owner > > > > > > + * The owner identifier. > > > > > > + */ > > > > > > +void rte_eth_dev_owner_delete(const uint16_t owner_id); > > > > > > + > > > > > > +/** > > > > > > + * Get the owner of an Ethernet device. > > > > > > + * > > > > > > + * @param port_id > > > > > > + * The port identifier. > > > > > > + * @return > > > > > > + * NULL when the device is ownerless, else the device owner > pointer. > > > > > > + */ > > > > > > +const struct rte_eth_dev_owner *rte_eth_dev_owner_get(const > > > > > > +uint16_t port_id); > > > > > > + > > > > > > +/** > > > > > > * Get the total number of Ethernet devices that have been > > > successfully > > > > > > * initialized by the matching Ethernet driver during the PCI > > > > > > probing > > > phase > > > > > > * and that are available for applications to use. These > > > > > > devices must be diff --git > > > > > > a/lib/librte_ether/rte_ethdev_version.map > > > > > > b/lib/librte_ether/rte_ethdev_version.map > > > > > > index e9681ac..7d07edb 100644 > > > > > > --- a/lib/librte_ether/rte_ethdev_version.map > > > > > > +++ b/lib/librte_ether/rte_ethdev_version.map > > > > > > @@ -198,6 +198,18 @@ DPDK_17.11 { > > > > > > > > > > > > } DPDK_17.08; > > > > > > > > > > > > +DPDK_18.02 { > > > > > > + global: > > > > > > + > > > > > > + rte_eth_find_next_owned_by; > > > > > > + rte_eth_dev_owner_new; > > > > > > + rte_eth_dev_owner_set; > > > > > > + rte_eth_dev_owner_remove; > > > > > > + rte_eth_dev_owner_delete; > > > > > > + rte_eth_dev_owner_get; > > > > > > + > > > > > > +} DPDK_17.11; > > > > > > + > > > > > > EXPERIMENTAL { > > > > > > global: > > > > > > > > > > > > -- > > > > > > 1.8.3.1 > > > > > > > > > > > > > > > > > > > > -- > > > > Ga=EBtan Rivet > > > > 6WIND > > > >