From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C0B5A04F1; Wed, 11 Dec 2019 02:36:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 681F237A2; Wed, 11 Dec 2019 02:36:26 +0100 (CET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10071.outbound.protection.outlook.com [40.107.1.71]) by dpdk.org (Postfix) with ESMTP id 9DD4C23D for ; Wed, 11 Dec 2019 02:36:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OSG/aN7pH06sYQStkfFu6EfnRrfwY1XHyowwb6uvCSHRhR1j8f36OID3ui4hn2mhJ/Acdhb9ijbDWm0IjVjtsaWjCUWmitutBbgkJjzxn4rNxt4jQ79OuvNJ9LaQj5dwN4U/YsNqm0zuHVJJWuj7AEqpE3+QfOxlRF5DBlIdApVmQ/ZSo1CtDOM48tmME6Eewjcmre+xmlN4+rpW1RiqxUBp5ajIUvKoB5T6Vbx0nNwC2YkES0r1hICyFPPfOCcuiAx2e88AyhdPsWILmA+CVXkwfChEOi4pv71+3fUTiIO39Xx4Px8jTeDjaxOqpUvDfSRNCAvT2pAH1nroBWLOyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LqvwhzxMWQhlbMNyk6q0sSNETfCuAGLiwwVz3zc/myI=; b=nyAhfKVUnNw6rJGxJkS8WW+wJ7NnI7Xcs4gZ4eo0Ma5PGaBGCIUu1ujG14+3WU5KVyPE9E4GaambHwn7FA66gENbdYCS+PRb1isBoWRolqgmUdiouPeDM/gK7C4SMUW6fXaN3qKF7iy8CubeWt+Q5cAJd+rU8eqGC0HwFQo6NhH7YNm1M0n2ej/n7N4f+BZlc1DLmREdGU+pdZ2JDdL5+ag0zjzHyGFtsD68/fYzj8WDIYG4gvzRCpv1gjsgpqqedcaaKaiK5wyQrZ+0eOFQviYr2xqJvCGbfhIel7iIsZ3HZDgBtztVcr4r/rx7ntqrSkd2P2pVo9cRz2wao4YgEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LqvwhzxMWQhlbMNyk6q0sSNETfCuAGLiwwVz3zc/myI=; b=TMYbEkBHimJSP5fVqcezCnBwQAtoCzYdutqIg5g7xVdic5y3W3ILwCUvMivyUJgm/wm7lladPQnrhc1BbjLUYB5I85nKi6qmifTk535HEcqqaAJtcCme4GwK2ioLijbX804DON8d100zu+xzDZ6Nhd/k+UmWDbUTOK3sAFy1v48= Received: from HE1PR05MB3484.eurprd05.prod.outlook.com (10.170.246.12) by HE1PR05MB4777.eurprd05.prod.outlook.com (20.176.167.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.13; Wed, 11 Dec 2019 01:36:22 +0000 Received: from HE1PR05MB3484.eurprd05.prod.outlook.com ([fe80::d44c:cf38:cfac:b253]) by HE1PR05MB3484.eurprd05.prod.outlook.com ([fe80::d44c:cf38:cfac:b253%3]) with mapi id 15.20.2538.012; Wed, 11 Dec 2019 01:36:22 +0000 From: Suanming Mou To: Stephen Hemminger , Andrew Rybchenko CC: Adrien Mazarguil , John McNamara , Marko Kovacevic , Thomas Monjalon , Ferruh Yigit , "dev@dpdk.org" , Shahaf Shuler , Ori Kam , Matan Azrad , Slava Ovsiienko Thread-Topic: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action Thread-Index: AQHVrywoKWy873kgR0u4QCsKS0/c9aezsb+AgABv8AA= Date: Wed, 11 Dec 2019 01:36:22 +0000 Message-ID: References: <1575955386-6672-1-git-send-email-suanmingm@mellanox.com> <322fb1d5-c629-5f67-59d4-c38df67f0c9b@solarflare.com> <20191210103133.12ec7fe7@shemminger-XPS-13-9360> In-Reply-To: <20191210103133.12ec7fe7@shemminger-XPS-13-9360> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=suanmingm@mellanox.com; x-originating-ip: [115.206.77.138] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 58cb373f-f78d-42e2-f6f0-08d77dda8784 x-ms-traffictypediagnostic: HE1PR05MB4777:|HE1PR05MB4777: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 024847EE92 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(13464003)(189003)(199004)(64756008)(66446008)(26005)(66556008)(81156014)(81166006)(2906002)(66476007)(54906003)(9686003)(53546011)(110136005)(71200400001)(8936002)(6506007)(316002)(86362001)(5660300002)(33656002)(186003)(66946007)(4326008)(55016002)(8676002)(52536014)(107886003)(478600001)(76116006)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR05MB4777; H:HE1PR05MB3484.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +KokB7Usgn/G324y/OOGU1sYe9dIjayB3Zc3hHVw/x7gSA0ymAQVbmbAm2F7pxw2x4O6qanNXpuO1pAYC3JeCpSzPHREwNDe050ZChUcdUkI5heEYDhqUi+IComhJU/V7/0XNHvf/L7E9nyQZ7JGcb5OuTrFvGlr+d2fk7yjuMwUKRd1OP9ORhBJ0rSvpvPdgtt4kaDcwGi9nRcmDqJCBO8ZH+ZbmjL1hs3kqLKOfoQinm8ak8cbnM4mR2JkiPEDEQArYpaBGWE7VUbWbIoJ9wCJjwslzelsMqYKLVsTTt7a5JziGc1WFWy84bUMzlKrViKtA52Y60fB0Fte9BbNU8kZBpH6Tz32a4m6E5HwQJjU4lGKE2EJ5rbg6uuC3L2IxOf1ytpXvbie2qPY9TpiIGspdsG25kGizpqRwiju9DhkvhgpTrNJPW0KSkLi2O84ZbD5RRkAAc/mHVipnnn96EDLYJWDdfinaaZ37HvZJDLeBAE3Hp2ZFYpm/3EH1plc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58cb373f-f78d-42e2-f6f0-08d77dda8784 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2019 01:36:22.3307 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: p1AfUccQ9gqSabT0qx/87/jcAsJjplhpqqybVymhvikV4ysDC6fmYm7jqTnEGE0cx17LIBnXtZPqkMrZwssiPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB4777 Subject: Re: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, December 11, 2019 2:32 AM > To: Andrew Rybchenko > Cc: Suanming Mou ; Adrien Mazarguil > ; John McNamara ; > Marko Kovacevic ; Thomas Monjalon > ; Ferruh Yigit ; dev@dpdk.or= g; > Shahaf Shuler ; Ori Kam ; > Matan Azrad ; Slava Ovsiienko > > Subject: Re: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action >=20 > On Tue, 10 Dec 2019 10:33:28 +0300 > Andrew Rybchenko wrote: >=20 > > > For some overlay network, such as VXLAN, the DSCP field in the new > > > outer IP header after VXLAN decapsulation may need to be updated > accordingly. > > > > > > This commit introduce the DSCP modify action for IPv4 and IPv6. > > > > > > Signed-off-by: Suanming Mou > > > > Acked-by: Andrew Rybchenko > > > > as usual it requires testpmd support and a driver which supports it (I > > understand that it may be omitted in RFC). >=20 > And it requires documentation and a software implementation in the flow > classifier. Could you please give the previous example code which add to both of them? >=20 >=20 > Plus you conveniently exclude defining what happens to reserved bits. > "What ever our hardware does is correct" is not a useful answer. > You need to be precise and limited in what is allowed to make this usable= . Sorry, I feel a little confused. The DSCP only use 6 bits both in IPv4 and IPv6 header. The data struct is d= efined by the IP protocol, it is not defined by the hardware. And the rest bits will be ignored as only 6 bits in the header. It is also = added in the code comments. The action is to apply the 6 bits DSCP value to the 6 bits DSCP field in IP= v4 or IPv6 header. Could you please point out the not precise part much more detail? Thank you for the comments. Will try to make it better. >=20 > Sorry, to be so negative. This feature is fine in itself and a useful inc= remental > improvement. But nobody has stepped up to address the usability of rte_fl= ow. It's hard to say, it's just like some people like meat and some like veget= ables.=20