From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94FE1A0613 for ; Thu, 29 Aug 2019 05:47:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CED1C1BFD0; Thu, 29 Aug 2019 05:47:04 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50061.outbound.protection.outlook.com [40.107.5.61]) by dpdk.org (Postfix) with ESMTP id DE6631BFCD for ; Thu, 29 Aug 2019 05:47:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hlCTP+mUSnaZ6DcEcMd+5hmQWzao2vLGopdpXPKyq16h9MYS/RNbYuXS6AOm+IkJ0AXKRb01KInkLaSgapq7Lc+tvgWmq7LKMJAh1D+r6wmvi1fq6zYXGT9U79KcKY79ymZf5C6+Ic8fGl8BF6B9/0uZN6h5dQeGaO48N2ZmyHY8GFqs27sZdzD5uTd3VBlvcdnvvu0Oe0BRYVyDBwO4g1zb8TAUwFnr0wodb+np7FnORlcEY4/vvFFAD9lgAPbOq+4fQNFVzMgwYaPIruCh/OuEKsibT815OE+tROtga51qeMzAUfh/PV7FgrEnC12QnblO73Zo8Qb0WMclep+eAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aC9YNzovCPJ40ijS5/Glc62d/i+kbhcyzoanddfxNtA=; b=CxOXHnNfQZTts+rMt0LdZyAUf90acWJuW6UrdFYz3/nnURd4kB210xpCm4+QncwCOyO9XvUsbg6xMQkKZyZWrf4brAZMk9bVSbmUAM6JOPDxdMYqq4kRyRff14tQx1fDeR6xB76WFbUV0u4waZv61Xh96dxXuTA667LVXgY/iIdjPlKAj1klacVA0EsdklidVme3TofIyGon4SmCIayIgh9wS4jWi4fsxJSitH3FBn+DJBDG3eAishNhmkVlrWGRQghuBVbFlil7Vb0FY2Dz5VNWICFQfU6ZcwicE6YVFNooiAulN3qxKPnaLcil+f0URVyUbAC0Llz189CX+t91Hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aC9YNzovCPJ40ijS5/Glc62d/i+kbhcyzoanddfxNtA=; b=XDPOMwE7U4qP+Bn+aFdmMO03hRM3FRpsl+M3wKDjSxmvtxkIeiImuEHhXLNui6hgIKUVmZwk295i/c31kZuxc7L2GWy3ZMNQnNzXy2Rae25sIG31yfFGPIVNs0Z1Bc0MYar45gzkAppMXrpTgyjLC2a/Ad5s+uLY+/afazCXimE= Received: from HE1PR0702MB3626.eurprd07.prod.outlook.com (52.133.6.24) by HE1PR0702MB3529.eurprd07.prod.outlook.com (52.133.5.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.10; Thu, 29 Aug 2019 03:47:02 +0000 Received: from HE1PR0702MB3626.eurprd07.prod.outlook.com ([fe80::4d1d:84eb:7442:a47d]) by HE1PR0702MB3626.eurprd07.prod.outlook.com ([fe80::4d1d:84eb:7442:a47d%6]) with mapi id 15.20.2220.013; Thu, 29 Aug 2019 03:47:02 +0000 From: Nitin Katiyar To: Stephen Hemminger CC: "dev@dpdk.org" , Venkatesan Pradeep Thread-Topic: [dpdk-dev] [PATCH 1/2] bus/pci: Fail rte_pci_probe if probing all whitelisted devices fail. Thread-Index: AQHVXMrVW+xBBkHoj0eArJAOfsGjiKcPbe2AgAIPSlA= Date: Thu, 29 Aug 2019 03:47:02 +0000 Message-ID: References: <1566934217-23824-1-git-send-email-nitin.katiyar@ericsson.com> <20190827161231.6c2313c7@xps13> In-Reply-To: <20190827161231.6c2313c7@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=nitin.katiyar@ericsson.com; x-originating-ip: [125.16.128.122] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e01a4c73-7f35-46d7-18d7-08d72c338dc4 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:HE1PR0702MB3529; x-ms-traffictypediagnostic: HE1PR0702MB3529: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:178; x-forefront-prvs: 0144B30E41 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(396003)(346002)(39860400002)(136003)(366004)(13464003)(199004)(189003)(53936002)(55016002)(71190400001)(71200400001)(107886003)(9686003)(6116002)(4326008)(6246003)(54906003)(81166006)(8676002)(81156014)(305945005)(316002)(74316002)(7736002)(3846002)(8936002)(25786009)(76176011)(7696005)(5660300002)(2906002)(52536014)(99286004)(6916009)(33656002)(66946007)(446003)(66556008)(64756008)(66446008)(66476007)(66066001)(26005)(186003)(44832011)(14444005)(53546011)(102836004)(6506007)(478600001)(256004)(55236004)(11346002)(86362001)(476003)(486006)(6436002)(14454004)(229853002)(76116006); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0702MB3529; H:HE1PR0702MB3626.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: U1QBTNMQ4aa8S1jXzdAhU0c6ywHvOU6cZCnW8DNGOjYC2GbCKx70FggM5yGhU2PedTxuvdsLTABKnLF0a2qQh8b1gdziUFRTRQnUj6virXL/jBIdQQXM2XF5Q+7jACjIdSNeI/RZCZuvNvRg+y1mXIpqXjAFtrtrqqRPT2kXZC6TQiDPqvZb+s+Ts7RbRXYSzmVJqritx4AjEnSQvhMGTC0MIywlqEEc9AeDozrs7j5UijUA38DelXamRWJArp9U3oS2Igu9l1yp7sS4hIcocS4Flm4TT+aAoLwNzFpt8gk10WkTOIfhCC/p2OwDwaJgdX8dEeDNVOEk+5pJLATP10ZTXlxvymofS8fbha1ebTvqIzKLI1PbljWtxcmOHAmH3pdEJlEHHUQxpQh9e/aEvkl446RA1MrC3zVqgoyuWPI= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-Network-Message-Id: e01a4c73-7f35-46d7-18d7-08d72c338dc4 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2019 03:47:02.7938 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W8miU7fiI2w1Gb30qv8D8ArojBX95IgFLqKSIhs6+2J3r8aARRiJr9kk0YHl3AbN+hvq/Jgg2OZtxt9oj8spHF465cva8Nug64avKh3BEcM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0702MB3529 Subject: Re: [dpdk-dev] [PATCH 1/2] bus/pci: Fail rte_pci_probe if probing all whitelisted devices fail. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Wednesday, August 28, 2019 1:43 AM > To: Nitin Katiyar > Cc: dev@dpdk.org; Venkatesan Pradeep > > Subject: Re: [dpdk-dev] [PATCH 1/2] bus/pci: Fail rte_pci_probe if probin= g all > whitelisted devices fail. >=20 > On Wed, 28 Aug 2019 01:00:16 +0530 > Nitin Katiyar wrote: >=20 > > Even if whitelist of devices is provided, rte_pci_probe() increments > > the probed counter for all the devices present in the system. If probe > > fails for all the whitelisted devices it still return success because > > failed and probed counts don't match. > > > > This patch increments probed count only when devices are actually > > probed. > > > > Signed-off-by: Nitin Katiyar > > Signed-off-by: Venkatesan Pradeep >=20 > There are two differing interpretations of this. > The simple case which is what your patch fixes is where user gives bad > arguments and no devices are present. >=20 > But the more complex case is where the devices show up later via hotplug = or > other discovery mechanism. For example, on Hyper-V/Azure SRIOV PCI > devices can show up after application is started. Your patch might break= the > use case of where an application is started before the VF is available. >=20 > More detailed example: >=20 > 1. VM is started. > 2. VF is take offline for maintenance or migration. > 3. DPDK application is started with whitelist option (no usable PCI found= ). > 4. VF becomes available after maintenance. >=20 > Yes, this a somewhat made up order which is unlikely to happen in real li= fe. > But there is nothing stopping it from happening. >=20 > I often recommend to customers using whitelist because the typical applia= nce > scenario has a management interface, and you don't want the DPDK > interacting with the VF of the management interface. >=20 > Therefore, from my point of view, this patch is a NO. Hi, Thanks for your comments. I am sorry I couldn't understand the scenario you= mentioned. If we are not probing the device then why should we be incrementing the pro= bed counter. If current implementation doesn't handle the scenario where al= l the devices in concern failed in probe (as per the whitelist) and code fa= ils to catch that case. Application like OVS using DPDK comes up successful= ly although it doesn't have any physical device in usable state. Best regards, Nitin