From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B612DA0093; Thu, 21 May 2020 09:52:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E964B1D634; Thu, 21 May 2020 09:52:50 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00048.outbound.protection.outlook.com [40.107.0.48]) by dpdk.org (Postfix) with ESMTP id 1018F1C211 for ; Thu, 21 May 2020 09:52:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=05+gWfwXv98sTbPNEJ6drr2eIsw7vePGk1MmscXHXYg=; b=Odw464anOWXLmX06lkhk6Ed4IH72IAiQpGuK/vBRFzGJ+oj3911CS3gdO3QymxmjqlbSPPkOX+bWAAHMQUMR4GZrZnX0jRVsT9GW6eC/X/lLV3DuHWqib7qbxuCEQCMK34OMtYHK1X9dZ9uW8IcoXIow0cX1zLmfvHDPePzWPoI= Received: from MR2P264CA0034.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::22) by DB6PR0802MB2309.eurprd08.prod.outlook.com (2603:10a6:4:86::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.27; Thu, 21 May 2020 07:52:48 +0000 Received: from VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:0:cafe::9c) by MR2P264CA0034.outlook.office365.com (2603:10a6:500::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23 via Frontend Transport; Thu, 21 May 2020 07:52:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT019.mail.protection.outlook.com (10.152.18.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23 via Frontend Transport; Thu, 21 May 2020 07:52:48 +0000 Received: ("Tessian outbound 9eabd37e4fee:v57"); Thu, 21 May 2020 07:52:48 +0000 X-CR-MTA-TID: 64aa7808 Received: from aedf8233aa4b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1615F4B9-5A89-4077-A85F-4D8242C80614.1; Thu, 21 May 2020 07:52:42 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id aedf8233aa4b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 May 2020 07:52:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mDI/sPbDPln9wJ+rPiW/VJwDQQH/1xN4pIp2JD/mlKyFgkAAFbrAjdqI1cc4dBf0JdazCgJSqE/IXu/3BsOQXG7lfP57DUJHpFehq9CgH01LGayTpKvmoX8qwkIBwBg57/cMqA7gRDdvp0t75YPYjO0q9ngKD4uqORHNwFwMrVu1AeH+xb4k22nPYFiZgnCidKDepKYY+0av+Xymkw289a5P385gPWRFFPpw/NTV6vj1CTquQWpYP49RUH0QPkI4K6Uc50W6vxwoypjWqktfCShSZVc1/gEhSmzL+GZ+57pAHcn5syltGVncXywCbrZjzGG8i9u2fvTeft5iYY5aww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=05+gWfwXv98sTbPNEJ6drr2eIsw7vePGk1MmscXHXYg=; b=gffCcXzkBxwB6rScpQ4lJfe4iZCP3cvZTrSoXDiPFNtPr0DjZzDYvks+EiiIZUxjEGlqKTfrlJg3MGG2MqDvdjTaEoFQ05Z8hudpvcM6f04r0ac9ZNHmTYgpiI57S+qL/9k544MKMaJSpYQWl1Ht5bubnwvdZAUwM+EIFmoZ4+RflFPD21bvfofwFTeqlJ8b7GjOMcQiPYnU5MfVpkby+/twbrk/9vpf1X4m1I1RnLOGxSLblTKFCoGSGCqinnM6VzvsDUVIHPKmBJQFC/WNa6pNnSk5T1Ay3uokoC9fwRnVKLHOQpNyAXBKHCkx6QzCVcwt9GjM9PXIa+tlh+ZofA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=05+gWfwXv98sTbPNEJ6drr2eIsw7vePGk1MmscXHXYg=; b=Odw464anOWXLmX06lkhk6Ed4IH72IAiQpGuK/vBRFzGJ+oj3911CS3gdO3QymxmjqlbSPPkOX+bWAAHMQUMR4GZrZnX0jRVsT9GW6eC/X/lLV3DuHWqib7qbxuCEQCMK34OMtYHK1X9dZ9uW8IcoXIow0cX1zLmfvHDPePzWPoI= Received: from HE1PR0801MB2025.eurprd08.prod.outlook.com (2603:10a6:3:50::14) by HE1PR0801MB2010.eurprd08.prod.outlook.com (2603:10a6:3:4b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.26; Thu, 21 May 2020 07:52:40 +0000 Received: from HE1PR0801MB2025.eurprd08.prod.outlook.com ([fe80::646e:c258:7269:f4b2]) by HE1PR0801MB2025.eurprd08.prod.outlook.com ([fe80::646e:c258:7269:f4b2%11]) with mapi id 15.20.3021.020; Thu, 21 May 2020 07:52:40 +0000 From: Ruifeng Wang To: "Akhil.goyal@nxp.com" , "dev@dpdk.org" CC: "declan.doherty@intel.com" , "asomalap@amd.com" , "anoobj@marvell.com" , "roy.fan.zhang@intel.com" , "fiona.trahe@intel.com" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , "jianjay.zhou@huawei.com" , "pablo.de.lara.guarch@intel.com" , "adamx.dybkowski@intel.com" , "Akhil.goyal@nxp.com" Thread-Topic: [PATCH] test/crypto: skip unsupported cases Thread-Index: AQHWLrt1BR75Pa9FJUGstpTiCBC+/KiyKqGQ Date: Thu, 21 May 2020 07:52:39 +0000 Message-ID: References: <20200520152612.2920-1-akhil.goyal@nxp.com> In-Reply-To: <20200520152612.2920-1-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 146fb8b5-fa8b-48af-b066-5fdf48b3f598.0 x-checkrecipientchecked: true Authentication-Results-Original: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 50499669-bbc2-46f4-229b-08d7fd5bf481 x-ms-traffictypediagnostic: HE1PR0801MB2010:|DB6PR0802MB2309: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:1051;OLM:4125; x-forefront-prvs: 041032FF37 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: h1QahdH+ZHKcNQ1cKx0b1/Yt49rg3g9JqkMKj1YyegkfkaqnEuFpjaU9aMZWpspX/yT3A+c/fR7JQsFMXig59PAw8ivRXfXK0ZXpD8xBVFEoxSAm6b05SHJiOOqGO5vX7XhNyFsEjMAgeUrLjW5yYmOQcQ9s2WN4+9z3EGryT+D5nzDhC+TyzjlLG/jVas1MJq371xXdrmaAHg4ikzu/skuCix+FwxRbunBxivXE60LkUKVD+Ox+HElf+Yo/jL0wG5Ya26CmykkYWU3iTUctf9h4Qddru9LGfl3AYSoWzfFQVODkrH1Lj2FWpa0muDpVgC3b5hOdMG00pSMdzU4Cx+ESvDd5wNU2YCcioxtT+14ixZXZW18g0zbc0iuoxLktVHdIhOQd+c0GjjuaMB4qv591/AG2vgEk6YT6VobeTthHkHkvEt1vJQcG0rsFTlSn X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR0801MB2025.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(366004)(39860400002)(346002)(376002)(136003)(55236004)(53546011)(2906002)(71200400001)(4326008)(7416002)(6506007)(7696005)(54906003)(110136005)(52536014)(478600001)(33656002)(86362001)(8676002)(66946007)(55016002)(5660300002)(66476007)(26005)(9686003)(76116006)(8936002)(186003)(316002)(66556008)(64756008)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: WsEZZIscY6egENBbBc3ywnW6KxD0vDVVF/WSYDlA3h5sj9Xo7uVA4bHiYMjJ7zVgyS1sEJsSk8KildgohsOwTeo6U1sXxBAvzcFclPlMJh1PkVhTtc6Z0EUNsNUMrkLPNI0SfC2WylybEKq2ji5cCStZ8AIrtnhW250rZclv/cTo5NsUTyF+cTrVd1D9oAd3pqQFMw9wCsZhcCENAK3v8m0FIJouGhW8zf209aG4Exbtw8/AOk3Y05wxCDzY/C7y0uiyTZvwhtVsz4feQ7XrdgI6IGGKckvoNKEbLsFee4ZJokKE4rLaW98DiiS4ud3r4qE8wfl0bqamfFCRQUA2A7wg/A06nrI34DevP+9OpB3r+rMLyx6S996h90ojnPKsb487vDx6SQiyQ8Trjs42HMoxbagpXUaFzfsWieCCexLtbmJtPHBZPzey+9eKjAYBeV4+mBn5yMBj+mYIZWg2Xj78853CKBPkC1X6uSarP00= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2010 Original-Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39860400002)(376002)(346002)(396003)(46966005)(110136005)(316002)(356005)(6506007)(53546011)(86362001)(82310400002)(7696005)(70206006)(36906005)(336012)(52536014)(26005)(70586007)(81166007)(8936002)(82740400003)(55016002)(186003)(33656002)(9686003)(8676002)(54906003)(4326008)(5660300002)(478600001)(47076004)(2906002); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 2e4728af-b75c-41ff-99ec-08d7fd5befb0 X-Forefront-PRVS: 041032FF37 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QosFsWAKwd/R3a2ZHJAtv5ZBYQrJswsVwYyemw4JvhAzsG5ac1MGTVEPMcFSqryAKflF8TUWxGP7BD6P+ahC7qtqnoNg4ByXruFALOrMAzJQNLRNm3OehV+pbS1YyW9oLdwA+q8eX75AH+pvP4Wu15yP+E1Pfga9evTHDSNHMXzOWm/CF1Wa8ENmR7/jpXBjtrMdoSA73IawsTvt5coMzsJ956dAMD49RFh9I5j2l1A5qXjRHC3dKhAWtiAkr/iDPtgsGCxPubjpR09tNqL3fdDz3zQsHRi8SXagi1Au2Q6tuJ86x/B2o4H+wYZtk/wVZfzx6Qz7Ty96Ttm14ZL9THNS1rLgTF/hhI2wqUv7y0H9sP66iTQoLMH/pWtQx5drMiuuPRLRmWL/iRPw+GHLNOsmSWWGlDxXQwo+QuzPKUVHviQ7nDJ0pQQqVXeaGNsUhFiEiGmyqR/Msxk4Y2JIWB6Aho/9GIk7Zeqpw2H8V7OV7W962Wm4++ZJYB2h9Qp+iKAJoYOzcGIBWJFS5OI8jw== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2020 07:52:48.1066 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 50499669-bbc2-46f4-229b-08d7fd5bf481 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2309 Subject: Re: [dpdk-dev] [PATCH] test/crypto: skip unsupported cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: akhil.goyal@nxp.com > Sent: Wednesday, May 20, 2020 11:26 PM > To: dev@dpdk.org > Cc: Ruifeng Wang ; declan.doherty@intel.com; > asomalap@amd.com; anoobj@marvell.com; roy.fan.zhang@intel.com; > fiona.trahe@intel.com; rnagadheeraj@marvell.com; adwivedi@marvell.com; > jianjay.zhou@huawei.com; pablo.de.lara.guarch@intel.com; > adamx.dybkowski@intel.com; Akhil.goyal@nxp.com > Subject: [PATCH] test/crypto: skip unsupported cases > > From: Akhil Goyal > > blockcipher cases are either returning TEST_SUCCESS or TEST_FAILED as > status, but the test may not be supported by the PMD which is also a succ= ess > case for the PMD. Hence checking for status =3D=3D TEST_FAILED for settin= g the > overall status as failed. > > Signed-off-by: Akhil Goyal > --- > app/test/test_cryptodev_blockcipher.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/app/test/test_cryptodev_blockcipher.c > b/app/test/test_cryptodev_blockcipher.c > index 642b549717..d033350659 100644 > --- a/app/test/test_cryptodev_blockcipher.c > +++ b/app/test/test_cryptodev_blockcipher.c > @@ -107,7 +107,7 @@ test_blockcipher_one_case(const struct > blockcipher_test_case *t, > "Test Skipped.\n"); > snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, > "SKIPPED"); > -return 0; > +return TEST_SKIPPED; > } > } > if (t->feature_mask & BLOCKCIPHER_TEST_FEATURE_SG) { @@ - > 120,7 +120,7 @@ test_blockcipher_one_case(const struct > blockcipher_test_case *t, > "Test Skipped.\n"); > snprintf(test_msg, > BLOCKCIPHER_TEST_MSG_LEN, > "SKIPPED"); > -return 0; > +return TEST_SKIPPED; > } > } else { > if (!(feat_flags & > RTE_CRYPTODEV_FF_IN_PLACE_SGL)) { @@ -129,7 +129,7 @@ > test_blockcipher_one_case(const struct blockcipher_test_case *t, > "Test Skipped.\n"); > snprintf(test_msg, > BLOCKCIPHER_TEST_MSG_LEN, > "SKIPPED"); > -return 0; > +return TEST_SKIPPED; > } > } > > @@ -146,7 +146,7 @@ test_blockcipher_one_case(const struct > blockcipher_test_case *t, > "Test Skipped.\n"); > snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, > "SKIPPED"); > -return 0; > +return TEST_SKIPPED; > } > } > > @@ -163,7 +163,7 @@ test_blockcipher_one_case(const struct > blockcipher_test_case *t, > "Device does not support this algorithm." > "Test Skipped.\n"); > snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, > "SKIPPED"); > -return 0; > +return TEST_SKIPPED; > } > > /* preparing data */ > @@ -435,6 +435,7 @@ test_blockcipher_one_case(const struct > blockcipher_test_case *t, > init_xform, sess_priv_mpool); > if (status =3D=3D -ENOTSUP) { > snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, > "UNSUPPORTED"); > +status =3D TEST_SKIPPED; > goto error_exit; > } > if (!sess || status < 0) { > @@ -780,7 +781,7 @@ test_blockcipher_all_tests(struct rte_mempool > *mbuf_pool, > printf(" %u) TestCase %s %s\n", test_index ++, > tc->test_descr, test_msg); > > -if (status !=3D TEST_SUCCESS) { > +if (status =3D=3D TEST_FAILED) { > if (overall_status =3D=3D TEST_SUCCESS) We can remove this line and overwrite overall_status unconditionally. WDYT? Thanks /Ruifeng > overall_status =3D status; > > -- > 2.17.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.