From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0045.outbound.protection.outlook.com [104.47.1.45]) by dpdk.org (Postfix) with ESMTP id DF725532C for ; Wed, 19 Jul 2017 10:21:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=j2w9xMJLU/AJmDBK7chd4gAWPU/VjbkeRZPLAPCoogE=; b=B51qaHPp0aPyoIIP8VjdST/EisSuUt3YktB7Cv6635uzQzSz4dTPAwGtIKOgjQ33ICoYBJi4afB1yun8qi1NldymSvfxpx6ttx0vYGrEXFSaTQ2wl0FVOb/7GSdv7amVRN7zhqtPsyGGFld0cIqESrGyaxlm2HodUfqhNlbVm1M= Received: from HE1PR08MB2809.eurprd08.prod.outlook.com (10.170.246.148) by HE1PR08MB2809.eurprd08.prod.outlook.com (10.170.246.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.13; Wed, 19 Jul 2017 08:21:08 +0000 Received: from HE1PR08MB2809.eurprd08.prod.outlook.com ([fe80::7c9e:1746:de24:6484]) by HE1PR08MB2809.eurprd08.prod.outlook.com ([fe80::7c9e:1746:de24:6484%13]) with mapi id 15.01.1261.022; Wed, 19 Jul 2017 08:21:08 +0000 From: Herbert Guan To: Thomas Monjalon CC: "dev@dpdk.org" , "jianbo.liu@linaro.org" , "jerin.jacob@caviumnetworks.com" , "nelio.laranjeiro@6wind.com" Thread-Topic: [dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue in old GCC(<4.9.0) Thread-Index: AQHS+34fFVRiSDygZE2HAnyNbQ1I6qJZsbgAgAEkQOA= Date: Wed, 19 Jul 2017 08:21:08 +0000 Message-ID: References: <1499856619-21007-1-git-send-email-herbert.guan@arm.com> <1499912202-22117-1-git-send-email-herbert.guan@arm.com> <11032881.QA85Xq1nMD@xps> In-Reply-To: <11032881.QA85Xq1nMD@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR08MB2809; 7:hJcF2LZ17A7vDazoyOGy44NeLxPBqDzXcy/6rzT+jGCVvBtY77gOZ2cSqp6KTCvX/lTr7ks0n2ft6V+WldrUXjZTM2dH44C697oiPm2pNp1v8k1/erc7g1UKhzZfw3lZrBdZ2AUYfsiSO3THme6uN30fbcHWt1LudoS+GFod4dIXJ0zyUmqIp155bPktnJ0OIa6pgtK/+K0rHBPqLEel1kfx7OOO1xk9NP1S+dwFDcCZZKHqRDNpzSFhtORYgC8yCYkB6iFzfEN2bD8BD0UMsTQ+UmRjfUkq4qOBgajJzJqXXna3T30faYbme7js6js5XGLfKluipZK4MxI3xyblrPcWeMrYv3cXMm5z6VNlOXE/uKxcNGNMxsa2bypAdeHYLzMHUTSa2rFSR/ehxzI5LFQ8V2VbPEj8gwakvwNvMhucX7Aok34X59/LB4ANUllf1g61F53kxcwixUempT0tQKi/QrswoDG1SS0ViS9QHWTuLDJjvF3rAJb9phd5intiJ8fIXmfwtdl7M7zVk2RL2NJXcaHLxZEa6kZqN+loTvLUunVHQ1IeUeXQ9Sx95Fozvu7lSPXZ+k+DPAKb84tRSTexKZYOFikJNWJ07Gz+vOeGS1GlhWL2doPHJ9745SPywnewlkJyDC69ePRzdcOaqSsDRpua/3jrKAPK8VmUItVyR6OjrSLa765rDdGnjj2aTjyQW3MLEWM5gtRIbyzfhL0ZEgl+rDZjwWKdu7UYR3LZGQkPMcmYim7Mp770+FMhokdh9WFBo5bQm64Fw+qvtlakkUXPhzlsOh557KuuhAQ= x-ms-office365-filtering-correlation-id: 88753fef-f97d-47cf-736f-08d4ce7f1bb1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:HE1PR08MB2809; x-ms-traffictypediagnostic: HE1PR08MB2809: x-exchange-antispam-report-test: UriScan:(180628864354917)(236129657087228)(48057245064654)(209349559609743); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(2017060910075)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123555025)(20161123560025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR08MB2809; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR08MB2809; x-forefront-prvs: 0373D94D15 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39850400002)(39400400002)(39450400003)(39410400002)(39840400002)(13464003)(40434004)(5660300001)(38730400002)(110136004)(189998001)(229853002)(6916009)(478600001)(2950100002)(14454004)(74316002)(6506006)(3660700001)(76176999)(50986999)(54356999)(25786009)(7696004)(72206003)(3280700002)(5890100001)(5250100002)(6116002)(102836003)(3846002)(66066001)(6246003)(55016002)(2900100001)(8676002)(99286003)(9686003)(33656002)(53546010)(2906002)(54906002)(8936002)(305945005)(53936002)(81166006)(86362001)(7736002)(4326008)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR08MB2809; H:HE1PR08MB2809.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2017 08:21:08.3740 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2809 Subject: Re: [dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue in old GCC(<4.9.0) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2017 08:21:10 -0000 Thomas, Thanks a lot for your review and comment. But I have some concern in this = approach. "poly128_t" is for ARM64 platform only and in fact it's more lik= ely that rte_v128u8_t (generic DPDK data type) could be defined from poly12= 8_t (ARM data type) which seems more reasonable. Best regards, Herbert -----Original Message----- From: Thomas Monjalon [mailto:thomas@monjalon.net] Sent: Tuesday, July 18, 2017 22:44 To: Herbert Guan Cc: dev@dpdk.org; jianbo.liu@linaro.org; jerin.jacob@caviumnetworks.com; ne= lio.laranjeiro@6wind.com Subject: Re: [dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue = in old GCC(<4.9.0) 13/07/2017 05:16, Herbert Guan: > --- a/lib/librte_eal/common/include/arch/arm/rte_vect.h > +++ b/lib/librte_eal/common/include/arch/arm/rte_vect.h > +#if (GCC_VERSION < 40900) > +typedef uint64_t poly64_t; > +typedef uint64x2_t poly64x2_t; > +typedef uint8_t poly128_t __attribute__((vector_size(16), aligned(16))); > +#endif I think a better fix would be to switch to DPDK types like rte_v128u8_t. IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.