From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF7E2A04F5; Thu, 12 Dec 2019 10:55:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 843622BD3; Thu, 12 Dec 2019 10:55:35 +0100 (CET) Received: from APC01-HK2-obe.outbound.protection.outlook.com (mail-eopbgr1300139.outbound.protection.outlook.com [40.107.130.139]) by dpdk.org (Postfix) with ESMTP id 19A0323D; Mon, 9 Dec 2019 22:29:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N5ARPOOtAS9mZZ8ZqijqZzFATSBa4m7ILvfrffHapLfqg7hWLLPGbTq3GUtlao183d1mDIwE/q50Ls8lH3DRA27WZoyMvO1z1/d4x1m6qh1f8r3krx/GjB9Y/KfoCT12zn6jHyLOaSodjYdPnnlQtBVJj3HOIG2c6ZRWxSVe494vQNnelEeL0DWRI+Ngo9+iAS4wB1bjW4vMXZtKtXxfCBP5xDdAsyGV3UhM1ORJBdRW/4aK0gsxK8fSW1DEzjS8ClurPeHlvw++WUOG/kCbVNi7+tPTV3P/rspwQX5E2rm4B8ZeYPcxDG1GGSamkkMLuq/mOaf2JjiWbZWtyjd7/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DxV5DnybgrlTVd0wsKQk2hVdPCsc94MN+BJAD2kZNOc=; b=d7rVKgscAhQgaWdkmdHftnW8KIp2S59wxP1fmhnGMElkKU65ZIB3l7tbYw/tnQLuxLZP68Xmm/5tsyFk491daviYh8MClZrDORNJmmPvJMTiJcdFANX8NDBiZ/mok2nhTc3y6wru1u8lEwcb38BdzQE6H8Nqp3wFZYfD9zwW5Ibec0ZqI4I8V9XXInliVKAQGSafGseYt2XU25RqCD/98ySL7pOwEZJPR7W8MTDyKvST1LYz9SQW2bEmiVVOq90hc/Bt8amXBuN3mEZ6VmxG85BMszx7ys/p8hxII/2s8FgcT2raV8kpoHDCQU7BlObK938kLRPw7ja04fQg7vw+Sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DxV5DnybgrlTVd0wsKQk2hVdPCsc94MN+BJAD2kZNOc=; b=gpAHqQVkoaP8lmEsqxXoREcnt64RlsNgzCmAaSbG9gsov+B4ZS19dCwnVRyMrz7MLGJDdIJME5+QOSV2qSLxOIfee06SLWSz0j3RV5ZlwZxxYjH747S1dz/shmfs5KtEc96XT3cYSN6krYMON0JXmPoDNRGP9vA05m7GbTkHPXA= Received: from HK0P153MB0148.APCP153.PROD.OUTLOOK.COM (52.133.156.139) by HK0P153MB0162.APCP153.PROD.OUTLOOK.COM (52.133.156.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.1; Mon, 9 Dec 2019 21:29:26 +0000 Received: from HK0P153MB0148.APCP153.PROD.OUTLOOK.COM ([fe80::a5bb:f459:f4f2:1b94]) by HK0P153MB0148.APCP153.PROD.OUTLOOK.COM ([fe80::a5bb:f459:f4f2:1b94%7]) with mapi id 15.20.2559.007; Mon, 9 Dec 2019 21:29:26 +0000 From: Dexuan Cui To: Stephen Hemminger , "dev@dpdk.org" , "Donald Lee (RD-TW)" , Ferruh Yigit CC: "stable@dpdk.org" Thread-Topic: [PATCH] net/netvsc: disable before changing RSS parameters Thread-Index: AdWkCZCSRBa3Z8IWRAK5fNreHRUkqQKzVW3A Date: Mon, 9 Dec 2019 21:29:26 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=decui@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2019-11-26T03:28:33.6092091Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=031a46c2-06e0-43e1-b061-7477b96c975c; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic authentication-results: spf=none (sender IP is ) smtp.mailfrom=decui@microsoft.com; x-originating-ip: [2001:4898:80e8:8:45a7:b8ef:74d6:b278] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ab93b54a-b2d1-4b72-aa9a-08d77ceede48 x-ms-traffictypediagnostic: HK0P153MB0162:|HK0P153MB0162: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1051; x-forefront-prvs: 02462830BE x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(376002)(136003)(396003)(366004)(346002)(54534003)(199004)(189003)(4326008)(8676002)(81156014)(81166006)(55016002)(9686003)(8936002)(71190400001)(316002)(186003)(66476007)(66556008)(64756008)(66446008)(229853002)(71200400001)(33656002)(7696005)(53546011)(305945005)(66946007)(76116006)(52536014)(2906002)(8990500004)(6506007)(5660300002)(86362001)(10290500003)(10090500001)(110136005)(478600001); DIR:OUT; SFP:1102; SCL:1; SRVR:HK0P153MB0162; H:HK0P153MB0148.APCP153.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 90hwVl3oNPUtkmK+xwITmTZLbij5uLOcHxawGQtm/uyLSMNG1X3nNITxzcd0CKhOD17vQV2A4nI1SHBNN+CUq4xFrK/4HD5iME0/7jT6dN+RB4v6RThYHgImHOAVxOXUR4c6XKPOqCPx2/A8AUdejq7HEW3LHUw7pWo9EBwb3H/XykNKBGKxWqY5f+1/hXOzHilJUGhkZt7vJytu9VFusqGw/JepbjWliw8bU0kEcRkiZJGG3F/2fIFChYS83Li2Rumm+a+ouglKzjqlf9762E0+hYIoT8n93hdxvZYuPq3rSWNSAyX0y7o93Z0CfdQDgTscbKbsyI7e70TXgqnJE5qcE210ljiu0ikSu+YQfIUjcwdHCVKtqtOhp1b5RQBjvBjzDH4mMDJFKuuWSa59f/SL424Xw1vbTrUvU55jifkfBI8a0qN9CTlL3Zok4yyarGVhpMMtmhpqoshTZ5gcpvrjM1LH7oe1XDuBjbNsq1Wg7hXUCNoFowRtDm+CblFR x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab93b54a-b2d1-4b72-aa9a-08d77ceede48 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2019 21:29:26.5591 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZQBRleECWGkktPMoxf+TBZca47PbIhpDPcW71YTrPvaQuc/uxLjTxd6ildHAVupBeeGWex0fyVOZ2A9MXFS+Rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0P153MB0162 X-Mailman-Approved-At: Thu, 12 Dec 2019 10:55:34 +0100 Subject: Re: [dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Dexuan Cui > Sent: Monday, November 25, 2019 7:29 PM > To: Stephen Hemminger ; dev@dpdk.org; > Donald_Lee@trendmicro.com > Cc: stable@dpdk.org > Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters >=20 > > From: Stephen Hemminger > > Sent: Monday, November 25, 2019 9:13 AM > > To: dev@dpdk.org > > Cc: Stephen Hemminger ; > stable@dpdk.org; > > Dexuan Cui > > > > In order to change RSS parameters, the host requires that RSS > > is disable first. > > > > Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") > > Cc: stable@dpdk.org > > Signed-off-by: Dexuan Cui > > Signed-off-by: Stephen Hemminger > > --- > > drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/net/netvsc/hn_ethdev.c > b/drivers/net/netvsc/hn_ethdev.c > > index 164e9ad174a7..575780ee5f26 100644 > > --- a/drivers/net/netvsc/hn_ethdev.c > > +++ b/drivers/net/netvsc/hn_ethdev.c > > @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev > > *dev, > > hv->rss_ind[i] =3D reta_conf[idx].reta[shift]; > > } > > > > + err =3D hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); > > + if (err) { > > + PMD_DRV_LOG(NOTICE, > > + "rss disable failed"); > > + return err; > > + } > > + > > err =3D hn_rndis_conf_rss(hv, 0); > > if (err) { > > PMD_DRV_LOG(NOTICE, > > @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev > > *dev) > > return err; > > } > > > > + err =3D hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); > > + if (err) { > > + PMD_DRV_LOG(NOTICE, > > + "rss disable failed"); > > + return err; > > + } > > + > > err =3D hn_rndis_conf_rss(hv, 0); > > if (err) { > > PMD_DRV_LOG(NOTICE, > > -- > > 2.20.1 >=20 > Hi, Stephen, > I think the patch originally came from Donald Lee (I added him to "To"). >=20 > IMO Donald's Signed-off-by should be added. >=20 > And, can you please change my Signed-off-by to Tested-by? >=20 > Thanks, > -- Dexuan Hi Donald, Since you originally made the patch, can you please confirm that your Signed-off-by=20 "Signed-off-by: Donald Lee " can be added into the patch's changelog?=20 Thanks, -- Dexuan