From: "Wu, Wenjun1" <wenjun1.wu@intel.com>
To: fengchengwen <fengchengwen@huawei.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "Su, Simei" <simei.su@intel.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v1 2/2] examples/multi_process: fix memory leak
Date: Thu, 6 Jul 2023 05:10:39 +0000 [thread overview]
Message-ID: <IA0PR11MB795543AC9A1A7F6936A7AD6CDF2CA@IA0PR11MB7955.namprd11.prod.outlook.com> (raw)
In-Reply-To: <d80dcf21-0eef-02f3-e5bd-0aa336e7d9a8@huawei.com>
Hi Chengwen,
Thanks for reviewing.
The memory leak occurs similar as what mentioned in https://patches.dpdk.org/project/dpdk/patch/20230705092511.362484-2-wenjun1.wu@intel.com/.
I will perfect the commit description in V2 version.
Thanks,
Wenjun
> -----Original Message-----
> From: fengchengwen <fengchengwen@huawei.com>
> Sent: Thursday, July 6, 2023 9:02 AM
> To: Wu, Wenjun1 <wenjun1.wu@intel.com>; dev@dpdk.org; Burakov,
> Anatoly <anatoly.burakov@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: Su, Simei <simei.su@intel.com>; stable@dpdk.org
> Subject: Re: [PATCH v1 2/2] examples/multi_process: fix memory leak
>
> On 2023/7/5 17:25, Wenjun Wu wrote:
> > The device should be detached before quit, otherwise it will cause
> > memory leak.
>
> Which memory will leak?
>
> For mp, if secondary process quit, it only needs to properly handle the
> memory shared with other process.
>
> >
> > Fixes: 05f1d6842fc3 ("examples/multi_process: add hotplug sample")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> > ---
> > examples/multi_process/hotplug_mp/commands.c | 22
> > ++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
> >
> > diff --git a/examples/multi_process/hotplug_mp/commands.c
> > b/examples/multi_process/hotplug_mp/commands.c
> > index 88f44e00a0..143d57eeb6 100644
> > --- a/examples/multi_process/hotplug_mp/commands.c
> > +++ b/examples/multi_process/hotplug_mp/commands.c
> > @@ -52,6 +52,28 @@ static void cmd_quit_parsed(__rte_unused void
> *parsed_result,
> > struct cmdline *cl,
> > __rte_unused void *data)
> > {
> > + uint16_t port_id;
> > + char dev_name[RTE_DEV_NAME_MAX_LEN];
> > + struct rte_devargs da;
> > +
> > + RTE_ETH_FOREACH_DEV(port_id) {
> > + rte_eth_dev_get_name_by_port(port_id, dev_name);
> > + memset(&da, 0, sizeof(da));
> > +
> > + if (rte_devargs_parsef(&da, "%s", dev_name)) {
> > + cmdline_printf(cl,
> > + "cannot parse devargs for device %s\n",
> > + dev_name);
> > + }
> > + printf("detaching before quit...\n");
> > + if (!rte_eal_hotplug_remove(rte_bus_name(da.bus),
> da.name))
> > + cmdline_printf(cl, "detached device %s\n",
> > + da.name);
> > + else
> > + cmdline_printf(cl, "failed to detach device %s\n",
> > + da.name);
> > +
> > + }
> > cmdline_quit(cl);
> > }
> >
> >
prev parent reply other threads:[~2023-07-06 5:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 9:25 [PATCH v1 0/2] " Wenjun Wu
2023-07-05 9:25 ` [PATCH v1 1/2] bus/vdev: " Wenjun Wu
2023-07-06 0:48 ` fengchengwen
2023-07-05 9:25 ` [PATCH v1 2/2] examples/multi_process: " Wenjun Wu
2023-07-06 1:02 ` fengchengwen
2023-07-06 5:10 ` Wu, Wenjun1 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA0PR11MB795543AC9A1A7F6936A7AD6CDF2CA@IA0PR11MB7955.namprd11.prod.outlook.com \
--to=wenjun1.wu@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=qi.z.zhang@intel.com \
--cc=simei.su@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).