From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDE6F43837; Fri, 5 Jan 2024 07:02:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 996C0402E4; Fri, 5 Jan 2024 07:02:58 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 0D6A1402E0 for ; Fri, 5 Jan 2024 07:02:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704434576; x=1735970576; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=OjLLhWJCVrEmyeuOLZW0yz1+NIRnH27sFIKXm8LKj8s=; b=DftietYr7YHs+DLS/vs4E745AwqL3WiM8jqtHcqfV9K6N3EM4KtfUmcs NyLrp5vis9I1cxDf6qCUS5uJSX4rvwuhdWAQ5XzDN5wjNdf3aDGr4Fl54 t8GNjzHRCWCpOHyBxBBmUbROwpjYdhrBl50VJ5LLdBpL8S3OzhPj0WfS4 xsm+NTy5IJZES8olLmTHun2rGHDhpXZ+6boFg3ltonn5AWD6mE8+xEaWy SZdFXbtEpZ4ZtUMzTUk1ArqHGWWwTNgM8mgSOKLmOAPuPcIVYbBsHrniW snhlDG8r7IUgzttS4hZhdjJnds53+f2e73737ETIwzog7DeL4tBTFvNm7 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10943"; a="377592565" X-IronPort-AV: E=Sophos;i="6.04,332,1695711600"; d="scan'208";a="377592565" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2024 22:02:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,332,1695711600"; d="scan'208";a="22746296" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Jan 2024 22:02:51 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 4 Jan 2024 22:02:50 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 4 Jan 2024 22:02:50 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 4 Jan 2024 22:02:50 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 4 Jan 2024 22:02:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VPvaKk7aAonDLVlYj+4yVBTVxkiYlTzAuU7xizuTRsmh3cR3XZuagwNDNmCPlFZkcI7XKCR0Id2EElE/K44o3MaZ44ZLxyjIGajgg0DnQ/cpDf4M/3mQTKeCEcXus4fMx/LFRy4XBx3E3ydXPu5qTPwC5yZ0vbPtrelIKu3RgR5bkkbdInev5H6X2N2vrA2QM184iIlbsbi9V3PLY25YNzGqeiCgnEMiVJ+jQAOyw6tngvsugTidIK/pvxTmT5VSKSuf9108aJWH2xpF4AOASNiyaxkw14WKTIK1TVMMOzKcX730d8aoWjtvixKcEeCJc305Sl4k9u6GvyRtnSHeGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iClGZZZUIYPdg441LMvAs2yHV7z7CORgU62aWOkR2c4=; b=daEcj2y8SVBELpzU2vNIMqYEI5o/b0oq39cdEqZKYEhAAaeKqnZz0WrOgqKp2hAXkv1osOpUXprAki6mXpSu4oMYFI3cBh2sg8iT7mj/+G+sA0+d1Szx3TxYzh1HMvqL7n3VnbV8XhGBQz9lj0+w4Dbz1GWmR7SpYr+0qHZOycMxtOPqANt5ptAphoW2WWf+Mqm1natKWFdVxXSLtNDT2Dmd1aGDK/MicVaBV/ma6BTbVjmzH3N4ELBBIXbs8peBqP9kWgSgleXKIz0Me/LQJRXjIFraEknavb1nQ9NAQI2hdI2EtcWfmeUIB0tlIGXJVr8krSJ3CKsrj2qg0M7tbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from IA0PR11MB7955.namprd11.prod.outlook.com (2603:10b6:208:3dd::6) by CH0PR11MB5378.namprd11.prod.outlook.com (2603:10b6:610:b9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.15; Fri, 5 Jan 2024 06:02:42 +0000 Received: from IA0PR11MB7955.namprd11.prod.outlook.com ([fe80::1ec3:e3e7:c7e7:b89c]) by IA0PR11MB7955.namprd11.prod.outlook.com ([fe80::1ec3:e3e7:c7e7:b89c%7]) with mapi id 15.20.7159.015; Fri, 5 Jan 2024 06:02:42 +0000 From: "Wu, Wenjun1" To: "Zhang, Qi Z" , "Yang, Qiming" CC: "dev@dpdk.org" Subject: RE: [PATCH] net/ice: refine queue start stop Thread-Topic: [PATCH] net/ice: refine queue start stop Thread-Index: AQHaP5VlKcEXlhBGrUWT6pbFooB50LDKudZw Date: Fri, 5 Jan 2024 06:02:42 +0000 Message-ID: References: <20240105133705.360750-1-qi.z.zhang@intel.com> In-Reply-To: <20240105133705.360750-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA0PR11MB7955:EE_|CH0PR11MB5378:EE_ x-ms-office365-filtering-correlation-id: 188c8ba9-afef-4308-432e-08dc0db3ee43 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lMZaCDB5ZMgaBiLsEaCYPGva2Gj6lZzRT1OeMe+PyB1R/qiEUdHCkmpaTYIvKq2UF9v/mOaPOt6iJoKBkJtYI+MhAiNMYwPjTyMH0xH5UyaJiRYJAb5mZSsM1+d1gGbLF6kLRscCox9puZKCodSixvATAiZANSDVxeROgq9R6MKbMHZpztnnJiy/C0vbJWdorQMnmC51/B406y8oNIFoxTaN2tN5Eb+6B/B2WfMQTqXx9lk8rhPmx6QI5ja+emSiHOeZGkZitlMUz+X6982hhXRV76xV744X0acssZVEg0DuApGFd0dUcRnjuuqDxFcsX5EJEXOGL8llX3p0YVUOqBwUBVscOKpJFVcs5dMWV8ZAmLZEhyBB7d7qb5A5BEABG7cE9X6Xb0Mij/QHhkOotfDf+LZQ90khycKkGGfadel1mW6oct0QEulbXp441CJ233BZqQlPvwMBAiO3rAqg8JDwZn0fHcsiwR0pJxAb52Re+x7GbkXVnbXvq4NJySqxg9xjlj8li9b22R7eGsvBM+zhEicQAKdYuospZZ79HIiX7caeNu2EhRvqcnk0fD9lufJ5SAPd8sA0EgY3tWLL2+Aa+YosPv63XyExB1yuyYqYuXcfACb/lJQmQhwoKLZc x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA0PR11MB7955.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(136003)(396003)(376002)(39860400002)(346002)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(5660300002)(8676002)(8936002)(52536014)(4326008)(38070700009)(2906002)(41300700001)(7696005)(86362001)(55016003)(82960400001)(9686003)(53546011)(6506007)(71200400001)(478600001)(33656002)(83380400001)(38100700002)(26005)(122000001)(110136005)(66446008)(6636002)(76116006)(66946007)(66556008)(66476007)(64756008)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7Kux+0LYL5uamQqV6uhRpbeJXEki4ie3+OOT7TDTxllJSPrHK7WasV4mKyC8?= =?us-ascii?Q?gTd7cgI5eJhNYA6/g2xpRk4fobeP67IrR1Neb2IvQmENIEyE4pquYhld1xFH?= =?us-ascii?Q?MXJjHPGf4ygevUFOGtYpnVr9Vrpk3FXJja1qGUltWRrCz/km+ehLavSm1Pmr?= =?us-ascii?Q?rhtK1HTjZfHfokgHwFakrqPKPVkjlcRyl9+M08ZdcjPuQZRjHrQX7U13Zifd?= =?us-ascii?Q?kToKgWocaVgkqjOjAodG86glsEOKCVbBU00oM6u0GHvn1j42O0g+6YOj2JYx?= =?us-ascii?Q?mcz9AkjFlsKu9/92Rh9Uj0BBvhq57O6xd9Htjqh8RObaEOsbPDy+VRR3q9qE?= =?us-ascii?Q?Fml7iKK0f9BWR+5yGJgfiTHVq9BGtDKvVL4mqQZGIT55UUA6Ovw3gOu+2xg/?= =?us-ascii?Q?6RhHgrmZyToE2kSpn71Of5Ndj4Cl274vXm4acD5cgfzXRl5aRzUeK+OvJAJ1?= =?us-ascii?Q?Z9m0R7fqslxOZx09W4eQ8hDbSVxDmIY+yfxzYUZRHAaDHT48zswY5++nW/z9?= =?us-ascii?Q?vDdlYH+Yu6A213UGggzi7mukdwierfCaDlx/zGeORSUFS+gHbqSIfgnupVkq?= =?us-ascii?Q?08lRvtsckebhCYJ4I03Qp4GEMk7qaMBIZ/HPp9bByGHfhzF/wA5bwpMjeiCL?= =?us-ascii?Q?cXE1NcFSn8RmxLYiVzlFMuYWPEO7aMVD1UuGXSgC9lN3s3AgBubaRMkd789d?= =?us-ascii?Q?PN+Dx8liSM9umywFCAyAF3ncQZ4fnomic1/oRC+03VYS+t51CbU4sc4mn3ub?= =?us-ascii?Q?QwbspfgEo8tzwh9Pi6DGDsZhl8t4M7EV36e4Cu4UsYx/7L+3rRaISRMVW0Fv?= =?us-ascii?Q?fh7NsVOU7NL/d51ZRAyjrDHf+nnr3KUvPjwFWKiTlxeJ0WowfRA3bUIynUsJ?= =?us-ascii?Q?sZAvHuMqVtfjJq84W1XSGhVqZr/vM8L6XRbA/WowlKttZkSmWfq4TPRW630Z?= =?us-ascii?Q?fGiet445qJkMixqjFR2KzsGv8FGWA2b6jZjp6BII5jueNqED7mznFKJ1zHD8?= =?us-ascii?Q?T780VAovEJ42Lhyx1ttXRKmzkwaKt1vs8Osetkj4OOtvMTZaGeFJV8QqpKXg?= =?us-ascii?Q?XZ/O4ihrKaBbI+UdaPmGzhz8LWy62RV7WcFbOfyaV1+iahHRw3ahwhQSOEH0?= =?us-ascii?Q?ndRFjexEFZOu6FJ+gZEOpL8YY+0ZdjsoIK6uKUMeEh15Mibln9kVsKzcpAnz?= =?us-ascii?Q?IBVnIu31tqZkCpgQqKFk0kNPD6LUo8MAz4DQhlXFoANZRiX4+k0Dha8hHJV7?= =?us-ascii?Q?M+8iyic1lvk7sG4WWy65KRzDTOYCq0Qmzxls3BLAGYhcII5tUw6IKjpSba1C?= =?us-ascii?Q?2+wMCAGtgB0lms9BovjgEpYKycecrk+z4BLrkMAup6dvFvl0n5fJm6tKxDJx?= =?us-ascii?Q?T99VlD/a76MJMLgs7ttGl04m28/lfSsxJ9QxqfMe/3jA0HUCHZpDMZEXpZgF?= =?us-ascii?Q?zsxjXT4PZBOcxXU2jAPkqJnxJ8Q+Hf10EFV28lgzs/eFgga6XlFq07eiXWmE?= =?us-ascii?Q?KIK5WXVyE7NYa/xr7vVdnqIr7QOBZ6MXL8lKoP563qNznyyUG93ig0PfonrK?= =?us-ascii?Q?jkFHePc7id+eYUZY6sC/v1olmZjdPKByndukNq1C?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA0PR11MB7955.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 188c8ba9-afef-4308-432e-08dc0db3ee43 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2024 06:02:42.7041 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5PELl3gU6x789DPFkoeA71jXxlGg2rn2CM5oLqlv15v4ndb1hXmAkglbj0UxpvQOauSBRy9270Kg1UF3Y4Bd7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5378 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Friday, January 5, 2024 9:37 PM > To: Yang, Qiming ; Wu, Wenjun1 > > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH] net/ice: refine queue start stop >=20 > Not necessary to return fail when starting or stopping a queue if the que= ue > was already at required state. >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/ice/ice_rxtx.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) >=20 > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c inde= x > 73e47ae92d..3286bb08fe 100644 > --- a/drivers/net/ice/ice_rxtx.c > +++ b/drivers/net/ice/ice_rxtx.c > @@ -673,6 +673,10 @@ ice_rx_queue_start(struct rte_eth_dev *dev, > uint16_t rx_queue_id) > return -EINVAL; > } >=20 > + if (dev->data->rx_queue_state[rx_queue_id] =3D=3D > + RTE_ETH_QUEUE_STATE_STARTED) > + return 0; > + > if (dev->data->dev_conf.rxmode.offloads & > RTE_ETH_RX_OFFLOAD_TIMESTAMP) > rxq->ts_enable =3D true; > err =3D ice_program_hw_rx_queue(rxq); > @@ -717,6 +721,10 @@ ice_rx_queue_stop(struct rte_eth_dev *dev, > uint16_t rx_queue_id) > if (rx_queue_id < dev->data->nb_rx_queues) { > rxq =3D dev->data->rx_queues[rx_queue_id]; >=20 > + if (dev->data->rx_queue_state[rx_queue_id] =3D=3D > + RTE_ETH_QUEUE_STATE_STOPPED) > + return 0; > + > err =3D ice_switch_rx_queue(hw, rxq->reg_idx, false); > if (err) { > PMD_DRV_LOG(ERR, "Failed to switch RX queue %u > off", @@ -758,6 +766,10 @@ ice_tx_queue_start(struct rte_eth_dev *dev, > uint16_t tx_queue_id) > return -EINVAL; > } >=20 > + if (dev->data->tx_queue_state[tx_queue_id] =3D=3D > + RTE_ETH_QUEUE_STATE_STARTED) > + return 0; > + > buf_len =3D ice_struct_size(txq_elem, txqs, 1); > txq_elem =3D ice_malloc(hw, buf_len); > if (!txq_elem) > @@ -1066,6 +1078,10 @@ ice_tx_queue_stop(struct rte_eth_dev *dev, > uint16_t tx_queue_id) > return -EINVAL; > } >=20 > + if (dev->data->tx_queue_state[tx_queue_id] =3D=3D > + RTE_ETH_QUEUE_STATE_STOPPED) > + return 0; > + > q_ids[0] =3D txq->reg_idx; > q_teids[0] =3D txq->q_teid; >=20 > -- > 2.31.1 Acked-by: Wenjun Wu