RE: [EXT] [PATCH v2] eventdev/timer: add API to get remaining ticks

["Carrillo, Erik G" <erik.g.carrillo@intel.com>]

<... snipped ...>

> > diff --git a/app/test/test_event_timer_adapter.c
> > b/app/test/test_event_timer_adapter.c
> > index 1a440dfd10..1a1fb48b24 100644
> > --- a/app/test/test_event_timer_adapter.c
> > +++ b/app/test/test_event_timer_adapter.c
> > @@ -1920,6 +1920,72 @@ adapter_create_max(void)
> >  	return TEST_SUCCESS;
> >  }
> >
> > +static inline int
> > +test_timer_ticks_remaining(void)
> > +{
> > +	uint64_t ticks_remaining = UINT64_MAX;
> > +	struct rte_event_timer *ev_tim;
> > +	struct rte_event ev;
> > +	int ret, i;
> > +	const struct rte_event_timer tim = {
> > +		.ev.op = RTE_EVENT_OP_NEW,
> > +		.ev.queue_id = 0,
> > +		.ev.sched_type = RTE_SCHED_TYPE_ATOMIC,
> > +		.ev.priority = RTE_EVENT_DEV_PRIORITY_NORMAL,
> > +		.ev.event_type =  RTE_EVENT_TYPE_TIMER,
> > +		.state = RTE_EVENT_TIMER_NOT_ARMED,
> > +	};
> > +
> > +	rte_mempool_get(eventdev_test_mempool, (void **)&ev_tim);
> > +	*ev_tim = tim;
> > +	ev_tim->ev.event_ptr = ev_tim;
> > +#define TEST_TICKS 5
> > +	ev_tim->timeout_ticks = CALC_TICKS(TEST_TICKS);
> > +
> > +	/* Test that unarmed timer returns error */
> > +	TEST_ASSERT_FAIL(rte_event_timer_get_remaining_ticks(timdev,
> > ev_tim,
> > +							     &ticks_remaining),
> > +			 "Didn't fail to get ticks for unarmed event timer");
> 
> Please handle ENOSUP case.
> 

Good catch - updated in v3.

Thanks,
Erik

<... snipped ...>