On Thu, Oct 17, 2024 at 1:43 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Mon, Sep 2, 2024 at 11:58 AM Anatoly Burakov
> <anatoly.burakov@intel.com> wrote:
> >
> > From: Jaroslaw Ilgiewicz <jaroslaw.ilgiewicz@intel.com>
> >
> > Time variables were designed for 32 bit and 64 bit variables are not
> > necessary. Changed all to 32 bit.
> >
> > Signed-off-by: Jaroslaw Ilgiewicz <jaroslaw.ilgiewicz@intel.com>
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
> >  drivers/net/i40e/base/i40e_common.c    | 2 +-
> >  drivers/net/i40e/base/i40e_nvm.c       | 6 +++---
> >  drivers/net/i40e/base/i40e_prototype.h | 2 +-
> >  3 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c
> > index 07e18deaea..a2cfafeda9 100644
> > --- a/drivers/net/i40e/base/i40e_common.c
> > +++ b/drivers/net/i40e/base/i40e_common.c
> > @@ -3596,7 +3596,7 @@ enum i40e_status_code i40e_aq_debug_write_register(struct i40e_hw *hw,
> >  enum i40e_status_code i40e_aq_request_resource(struct i40e_hw *hw,
> >                                 enum i40e_aq_resources_ids resource,
> >                                 enum i40e_aq_resource_access_type access,
> > -                               u8 sdp_number, u64 *timeout,
> > +                               u8 sdp_number, u32 *timeout,
> >                                 struct i40e_asq_cmd_details *cmd_details)
> >  {
> >         struct i40e_aq_desc desc;
> > diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c
> > index 2f6cd9eda5..185af67817 100644
> > --- a/drivers/net/i40e/base/i40e_nvm.c
> > +++ b/drivers/net/i40e/base/i40e_nvm.c
> > @@ -62,7 +62,7 @@ enum i40e_status_code i40e_acquire_nvm(struct i40e_hw *hw,
> >  {
> >         enum i40e_status_code ret_code = I40E_SUCCESS;
> >         u32 gtime, timeout;
> > -       u64 time_left = 0;
> > +       u32 time_left = 0;
>
> Some logs (a few lines below) needs updating:
>
>                 i40e_debug(hw, I40E_DEBUG_NVM,
>                            "NVM acquire type %d failed time_left=%"
> PRIu64 " ret=%d aq_err=%d\n",
>                            access, time_left, ret_code,
> hw->aq.asq_last_status);
>
> And
>                         i40e_debug(hw, I40E_DEBUG_NVM,
>                                    "NVM acquire timed out, wait %"
> PRIu64 " ms before trying again. status=%d aq_err=%d\n",
>                                    time_left, ret_code,
> hw->aq.asq_last_status);
>
> Afaiu, it should be PRIu32.
>
> This was raised by OBS CI:
> https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/dpdk/Debian_12/x86_64

Reminder, this was mentionned during the maintainers call yesterday.
Please send a fix.


Thanks.

--
David Marchand