RE: [V1] app/testpmd: restore VXLAN-GPE support

["Minggang(Gavin) Li" <gavinl@nvidia.com>]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Monday, July 22, 2024 10:44 PM
> To: Minggang(Gavin) Li <gavinl@nvidia.com>; Matan Azrad <matan@nvidia.com>;
> Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU-
> Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Aman Singh
> <aman.deep.singh@intel.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: Re: [V1] app/testpmd: restore VXLAN-GPE support
> 
> On 7/17/2024 8:11 AM, Gavin Li wrote:
> > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> > index a76b44bf39..51a8d4993e 100644
> > --- a/app/test-pmd/cmdline_flow.c
> > +++ b/app/test-pmd/cmdline_flow.c
> > @@ -423,6 +423,12 @@ enum index {
> >  	ITEM_GENEVE_VNI,
> >  	ITEM_GENEVE_PROTO,
> >  	ITEM_GENEVE_OPTLEN,
> > +	ITEM_VXLAN_GPE,
> > +	ITEM_VXLAN_GPE_VNI,
> > +	ITEM_VXLAN_GPE_PROTOCOL,
> > +	ITEM_VXLAN_GPE_FLAGS,
> > +	ITEM_VXLAN_GPE_RSVD0,
> > +	ITEM_VXLAN_GPE_RSVD1,
> >
> 
> With this addition we have both of following enum items, right?
> 'ITEM_VXLAN_GPE_PROTOCOL'
> 'ITEM_VXLAN_GPE_PROTO'
> 
> 'ITEM_VXLAN_GPE_PROTOCOL' is for the old usage, which was previously
> 'ITEM_VXLAN_GPE_PROTO'.
> 
> And 'ITEM_VXLAN_GPE_PROTO' is now for the new usage.
> 
> This is confusing, and looks like it may live with us for a while if we remove them
> on v25.11.
> 
> 
> Does it make sense to keep 'ITEM_VXLAN_GPE_PROTO' as it is, add new one with
> a name that is more obvious that it is for new VXLAN struct, and some more
> comment to explain the reasoning of this redundant enum items?
> 
> As these are testpmd internal, when old VXLAN structs removed, I assume we can
> easily rename new enum item back to 'ITEM_VXLAN_GPE_PROTO'. What do you
> think?
Sounds good. ACK