RE: [PATCH 1/2] common/mlx5: update log format after devx_general_cmd error

[Gregory Etelson <getelson@nvidia.com>]

Hello David,

> > +       if (rc || MLX5_FW_STATUS(out)) {
> > +               mlx5_devx_err_log(out, "read access", "NIC register", reg_id);
> > +               return MLX5_DEVX_ERR_RC(rc);
> 
> I went back in the mailing list archive to find this change.
> This patch makes the pmd spat some scary log messages...
> 
> I get this on a system with a CX5 nic (OVS dpdk-latest + 22.11-rc2) :
> 2022-11-08T12:26:09.218Z|00027|dpdk|ERR|mlx5_common: DevX read
> access
> NIC register=0X9055 failed errno=22 status=0 syndrome=0
> 
> Should I be scared?
> The system runs fine and nothing else changed in my setup (afaics), so
> I'd expect it continues working..

That failure is expected in MLX HBA before ConnectX-6
That it not a functional error in ConnectX-5 and can be ignored.

> 
> This specific change of level on the "read access" check breaks OVS
> system dpdk unit tests, as those tests fail on ERR level logs.
> If this is harmless, please send a patch to revert to debug level (and
> for other log messages that were updated in this patch if it was
> unneeded).
>

I'll send a patch that removes that error message.
 
> 
> Thanks.
> 
> --
> David Marchand