From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 875F943CFD; Wed, 20 Mar 2024 07:06:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D537A40EDB; Wed, 20 Mar 2024 07:06:14 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48]) by mails.dpdk.org (Postfix) with ESMTP id 65B5A40271; Wed, 20 Mar 2024 07:06:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cxc9DQIkZJJxaCWh1LjYWsb74lQmr0uJYkmG7GSaMm0Ija78hYCU6bJKCruTjREmS1qslODnAFlbqSBfK5MlXNvLdLkJTcvuNIBtmAe8m3k3V3PWHByGczLtYA0Gpvk7ZkRJYIxWhaMvn/nMZQEqT+JnpjfedQcAR+g0z+amYDsdckZANxKb9QAxmycdwmCVz/B7RrIw722PSyP7Dx0k6C1ecqtjdd5JhRxwHzYAtqA3VUgILh9/jZa8sM3egQZUd5EEfzjpsdGOkQ0F2111Er8PeKEDZTT1iJaPlrj8lofL/SB9z+Zq/PdR4d/ydtaBeq/NBEuwxg0jfhftaeAOsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/T0tY6AnUvaFZf4BE9bJan6JafNymEjucXRtIglUb5I=; b=k0vXlY740qLEuZasum250CQNfRMjZDZwyCDvhdV0cHUejImJtxBSyL6L+mywxn0V3nQFN9f7NDQKn/8+Z6tD2GQYxsmxrMxcGG9RqXOjpGmwqDh1l3oMxe45oBD4mD43W0RMllCZZ1/JExvshJEw/xV682PDsCW6RYVxuAp3Ea5GEw+kKfsQqljLPvKiR0TQLX0L4vG/T3aHX+1AyjXspiPZ/5jhKDpeolPanl3laBjwW3jB0wpe4sMSBF/owMebU8nJOR7DOp3JynMYZYdbMlaw6MFYNrqZ46fq8dTrKlGPXG3ZJDFHZrbfpMNY9ptHQkSMA5fYa2fw5Uw0tpetZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/T0tY6AnUvaFZf4BE9bJan6JafNymEjucXRtIglUb5I=; b=EqO9iQPP+f/kanJ0W5KNWXrCRa7H39GH4mteigrwXG3mUnUgMgUjMP6lNAeFB7oEmPtYkSB/EOAhIFe6M5dm9nKwHk30GxVBrU+1CjD24xJ4gL1aVLZhGArsSOafuhK9maZqHOSzs6V5VZlPKMwmahhfn3eyWjXxrIvmJzMpvAp+ANaEQbYVYNC4Y8M2zpr8ydEOy8PC0Nz8k/Wb6oXixWgt1nu2E5XXK7b9/IW4o7Y71ToGb/AGm5S3cyXi4bZVGXeR2rpmgwqe3lJMbKNh/3x20jYAmyoFMhetZODy7NnMKmJ7o/I2kUtAkC4f7BoOY0FdmORDzUV9ZCkCv6GJTw== Received: from IA1PR12MB6332.namprd12.prod.outlook.com (2603:10b6:208:3e2::13) by CH3PR12MB7524.namprd12.prod.outlook.com (2603:10b6:610:146::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.30; Wed, 20 Mar 2024 06:06:10 +0000 Received: from IA1PR12MB6332.namprd12.prod.outlook.com ([fe80::abca:c0e2:1a95:d6ab]) by IA1PR12MB6332.namprd12.prod.outlook.com ([fe80::abca:c0e2:1a95:d6ab%4]) with mapi id 15.20.7386.020; Wed, 20 Mar 2024 06:06:10 +0000 From: Gregory Etelson To: Ferruh Yigit , Shani Peretz , "dev@dpdk.org" CC: Maayan Kashani , Ori Kam , Aman Singh , Yuying Zhang , "ci@dpdk.org" Subject: Re: [PATCH] app/testpmd: fix auto completion for indirect list action Thread-Topic: [PATCH] app/testpmd: fix auto completion for indirect list action Thread-Index: AQHaeRWts5MFtI3UGU+ry2X7SeClerE/J6AAgAAKyICAAPA+Bw== Date: Wed, 20 Mar 2024 06:06:10 +0000 Message-ID: References: <20240318092109.87656-1-shperetz@nvidia.com> <62669854-8add-4fdd-b882-a63d78f0d6e8@amd.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB6332:EE_|CH3PR12MB7524:EE_ x-ms-office365-filtering-correlation-id: 3dbaf628-7810-4782-247f-08dc48a3d756 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SaScFJ/8lyDNapM273ejyMFvLiuGAYevf6b+sWJTMCzXlV5ZckeI/pNeVZ4fE5DmmfKgle4HK5tYaQPUG0EJHUf5Jn1zWtiAgs0+P8nRDP0Oh7ZEu1aERX8h78Tqx+JPC2+O6WhBe2nte6xqpINmlNFlScNdE6nshdlCQYkTS/qFGSq25Kcm5jjKrHaqH7PgVwhbaEYpcjBF/JnGi9lUldYl40lM9q2Cqlfmte+/SeNs7nlOHj4af+WyZiPJMOMWzT7frBo/xj7qA0SCaCBu8rrNul/jT99BdfhnRX+/hZfmPLP5UEDZJzfrS9nww+WczlmjjSn3vp39Z6mcoszCoxIsON7MYu95Q3tMyPRFHop4KuuJtdr7timj0iFYUrm4RFgVZh9LHfAE0s+C1U04wuSQyf6XZHvwepmu+6p3MgRHerK75HVTnXJdOiir8k7aFet+8YBFNez/yeqiSHNsVkpscd7sghGOPqw+XAu1uGLngZD6mYRm1XZpxJ6lqUn9GCZrHYWqTOZmyfazpegTBSuQQ6LVz+uPJpd3ToNFJhptEQwLldybNiRwq4ddJH0OsNyhJ41OwjhG4/TU1c79EAB0hJgsoiZV9Y58y0ZGuLbLx3CRg/hWmkuwD2dnz7o50uBikor9A4y5LsVCZAPtWlIoFgD1R4UbWKtgcIg3E283H5uooIWSjHpLnBmABHpk7VDoeK30LLk/c2g/ibPkrQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR12MB6332.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?gVGcO9OFdXRXq8gL2x3mjMdJsFd6PfpuKfawygZyMLAyWzLWw3oWVPlv8X?= =?iso-8859-1?Q?/Qe70WaKtIUu2lbmf2xbpB02Eo+/R6O6mKJRgAbc/Wx717s4vgQCYKDLhY?= =?iso-8859-1?Q?J9c7eVs08Z4BXU8b6UR1Pl7CAKiEK0PxuyzCwFAfnM/VvqSdWrfnSPw+/J?= =?iso-8859-1?Q?qjHFnmR4c8/8uDFlimQTnw/xnNxGYyfHVtsO1aMpMyJPS5aQozZ9eusGTL?= =?iso-8859-1?Q?gxunZlbntPSxbtBi5fCwuTYw2e4MZxqTQV9OSeRr+JtjjTDuUBuF/4Zt5J?= =?iso-8859-1?Q?Vu2VJR9bFCUu1/tdllNE7JlnQseNYtUKC1Maxgh71Z0w26C4xUuZ3ZTFrK?= =?iso-8859-1?Q?q+A4LzFbnMv+YoZGB7DB4+WbIDqyV4Jjqggum+Gz8wO9VzT05bUE+wdv2G?= =?iso-8859-1?Q?tjOJY+s5HhUGdgAK67iKvsvYOuAgoheq2jwLitwUV2YgpOXYLuAjAv2wJv?= =?iso-8859-1?Q?FQPQvMv9rH87qofYQrje3DzTOaya/5xup1lr3ucHeh4hqBpwJS+lN+YnBH?= =?iso-8859-1?Q?qscAOqW4lVtNNyoA4KpBsMPJkRzAmEBu0fbthnJpSdR1EasbUgdsJFvpD4?= =?iso-8859-1?Q?eTCEMetTt6jpv0hGHxEAcrX0CranD3CnxjyHcyyX1KSvGy7Vk6cPCdWNX4?= =?iso-8859-1?Q?dzfQ5bfo8SrKdwwvEleNRiys0qqgvcxWc+vfPHdqD6JGnJRlKxdB3oKb7S?= =?iso-8859-1?Q?+b5x5KAM+h9FFOM4plLKWwuJY++xqjsc+TDLv0BPhPJE4oM7B6gWPicw+I?= =?iso-8859-1?Q?UxfuQjEQXUvy4DNEPo+5gbBeF/oqyCzGm/YfO43A05WFlSrXpJdjt2D7v7?= =?iso-8859-1?Q?Cg6xh0lWHCXuIxRVFSlBREHESlSKNtSaCZynGY93xlpXTeURhzqDfSYCRQ?= =?iso-8859-1?Q?mgeJUfRRoKHc83MuroSUF4qSNHIdQsxJWWnW7LNs3tf1rS1ZI1j/xlKdNV?= =?iso-8859-1?Q?G4sGM/wImc8iOR5DC0rLNuXJeYIj6xmzHJS5ylZn5KMhezkIAz1uQ0JCGb?= =?iso-8859-1?Q?RNJW6sgG58evmAI6TprAD03xE+uDUaRU6e+pzIdXs7pzZtAihCuDTO/upC?= =?iso-8859-1?Q?qxYvBRVqkcU0fHFgL9dLzbR32va+MsXZJNnGBWDIQvyhNUg5VEg4cdYirD?= =?iso-8859-1?Q?erWkz5ozMEtd77MocmxXINffIGDZ/L920oIMeo09gR63Cmo40PTYfGTQzF?= =?iso-8859-1?Q?/uVmgZ7rPhdktbkQpbmM09uhuHimngYU6gorNdCd3vtGSZVh9qqJs//QL0?= =?iso-8859-1?Q?RLtxMHvlJkSQqYrIRGhnM2i1ujHYgVo4J6LhntqgpC+8GxwjhRG2Hyw1ky?= =?iso-8859-1?Q?5JUxal17opGLTT8mzqkH7NLtPahRMvMhezNxU3vj9IPOzdNFzm5RAilkzz?= =?iso-8859-1?Q?Ybz8WbASDqLZqYV6OW3pKF3z9i99UZvZKnuM6vfftQuapq9zwc3koDb5Ua?= =?iso-8859-1?Q?2BZRqqwjILgEBBj36BitUH6AlNfQHY7ifYRZXD5Zueib5k7FQq8/1qa/tS?= =?iso-8859-1?Q?TwpWW34z6zXTnKvWJqxv2/LR8zlqKdYruEXxP/eIQU17JYEL/GxaDbbg3q?= =?iso-8859-1?Q?21eRTk7QVfYvjW1sugvDBalhr4vm0Rd8YJ56E0/FpRQgcDrTulrpUUxJfU?= =?iso-8859-1?Q?s36bqxfXnKS6wVzJ+5gBLg9Dlh2DsnGpBu?= Content-Type: multipart/alternative; boundary="_000_IA1PR12MB6332EF009D02524E7961B788A5332IA1PR12MB6332namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6332.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3dbaf628-7810-4782-247f-08dc48a3d756 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2024 06:06:10.9086 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6FMlvYnPwPO/Jm1IzRsHb9KgqR8awbluwrVNyQy8hluYN3YKOBTcRi1IT4SarIgz89mIGzpnyWVjbMVSf3tEUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7524 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_IA1PR12MB6332EF009D02524E7961B788A5332IA1PR12MB6332namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hello Ferruh, >BUT overall how can we catch issues like this in the feature, we don't >have a good way to test testpmd flow commands. >@Ori, @Gregory, do you have any idea? >cc'ed CI mail list too. We have a tool for unit tests based on the testpmd. The tool details are here: https://drive.google.com/drive/folders/1cHrPwx4= fUJ6ibUCtHd4kNKsrmmvQvvOj?usp=3Ddrive_link. There's also a short description here: https://inbox.dpdk.org/ci/2a287ee7-c= da4-f2ab-a4e6-a47021f8573f@nvidia.com/ Consider an option when a code patch is accompanied with a short test scrip= t that validates that patch functionality. DPDK CI can run the script to verify that the patch functions correctly. Regards, Gregory --_000_IA1PR12MB6332EF009D02524E7961B788A5332IA1PR12MB6332namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
Hello Ferruh,

>BUT overall ho= w can we catch issues like this in the feature, we don't
>have a good way to test testpmd flow commands.
>@Ori, @Gregory, do you have any idea?
>cc'ed CI mail list too.

We have a tool for unit tests based on the testpmd.
The tool details are here:  h= ttps://drive.google.com/drive/folders/1cHrPwx4fUJ6ibUCtHd4kNKsrmmvQvvOj?usp= =3Ddrive_link.
There's also a short = description here: https://inbox.dpdk.org/ci/2a287ee7-cda4-f2ab-a4e6-a47021f8573f@nvidia.com/<= /a>

Consider an option wh= en a code patch is accompanied with a short test script that validates that= patch functionality.
DPDK CI can run the script to verify that the patch functions correctly.

Regards,
Gregory

--_000_IA1PR12MB6332EF009D02524E7961B788A5332IA1PR12MB6332namp_--