From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Raslan Darawsheh <rasland@nvidia.com>,
Michael Baum <michaelba@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
Hamdan Igbaria <hamdani@nvidia.com>
Subject: [INTERNAL]RE: [PATCH] net/mlx5/hws: fix ESP matching validation
Date: Thu, 18 Jan 2024 09:27:55 +0000 [thread overview]
Message-ID: <IA1PR12MB8078702D5A583B5DBD1FC346DF712@IA1PR12MB8078.namprd12.prod.outlook.com> (raw)
In-Reply-To: <MN0PR12MB60564952600AC3CCDCF14B44CF722@MN0PR12MB6056.namprd12.prod.outlook.com>
HWS guys claimed this check was needed to make sure matcher works well on ESP.
Are we sure we can remove this ?
> -----Original Message-----
> From: Raslan Darawsheh <rasland@nvidia.com>
> Sent: Wednesday, January 17, 2024 7:12 PM
> To: Michael Baum <michaelba@nvidia.com>; dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Ori
> Kam <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Hamdan
> Igbaria <hamdani@nvidia.com>; stable@dpdk.org
> Subject: RE: [PATCH] net/mlx5/hws: fix ESP matching validation
>
> Hi,
> > -----Original Message-----
> > From: Michael Baum <michaelba@nvidia.com>
> > Sent: Monday, January 15, 2024 2:10 PM
> > To: dev@dpdk.org
> > Cc: Matan Azrad <matan@nvidia.com>; Dariusz Sosnowski
> > <dsosnowski@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Slava
> > Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>;
> > Suanming Mou <suanmingm@nvidia.com>; Hamdan Igbaria
> > <hamdani@nvidia.com>; stable@dpdk.org
> > Subject: [PATCH] net/mlx5/hws: fix ESP matching validation
> >
> > The "mlx5dr_definer_conv_item_esp()" function validates first whether
> > "ipsec_offload" PRM flag is on, if the flag is off the function
> > returns error.
> >
> > The "ipsec_offload" PRM flag indicates whether IPsec encrypt/decrypt
> > is supported, IPsec matching may be supported even when this flag is off.
> >
> > This patch removes this validation.
> >
> > Fixes: 81cf20a25abf ("net/mlx5/hws: support match on ESP item")
> > Cc: hamdani@nvidia.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Michael Baum <michaelba@nvidia.com>
> > Acked-by: Hamdan Igbaria <hamdani@nvidia.com>
> > Acked-by: Matan Azrad <matan@nvidia.com>
> Patch applied to next-net-mlx,
>
> Kindest regards
> Raslan Darawsheh
prev parent reply other threads:[~2024-01-18 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 12:09 Michael Baum
2024-01-17 17:11 ` Raslan Darawsheh
2024-01-18 9:27 ` Slava Ovsiienko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA1PR12MB8078702D5A583B5DBD1FC346DF712@IA1PR12MB8078.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=hamdani@nvidia.com \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=suanmingm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).