From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79E3243AC4; Fri, 9 Feb 2024 12:04:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47E5840697; Fri, 9 Feb 2024 12:04:05 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2069.outbound.protection.outlook.com [40.107.220.69]) by mails.dpdk.org (Postfix) with ESMTP id 978954026A for ; Fri, 9 Feb 2024 12:04:03 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KzsZ46epH/ujI0JXZWneAqsvnHbz9GARv1I5kt4eIeiWnQ4mEvdxgZcX5lJdhfcJCCEPYwYvdIzKBqNuq677VBp+BqFiDJqAG7bGhr+/DMRH+/fscslsWScaNuGhjGcRBEYaj1NZSjUSEILF1odvR96xxiPFBZStH9dxbQNr6f5cKSsL7Z7M9uJKX61zh7y8LreMyzIo0+mL3CEiei+e9Q3H4X/jBG3YJpnN831rWyMTUKQo76VSUsWmZ69sRyAt1Kdb1XQqabLzVxFEta4U6bK7VYw33CUaLkbzvdy0Z1nIn4q6B/EqsbvS4QOiXa606xbhPlWgosQDtntF658+8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q4RZevC7sSlZtCLRD4Q2IZFm/c5poqfBx6Wd1A3gmyo=; b=EISLhn81q/pr2q6sQx2M00pbT2JwlMmPf2uzUDt3nsglwmpZxEcobpgBar3EEGxw0MXdQzRiIrjjRSCzM/OPb4lemNJmo2qQyBRnwpiSmTn/aTHtSMAX10M55I9Muj/9oia7x4KofLlFXrBnJSo33vKHGSG0CzYVR7Z0TLicjaGipVChB6nsl8/ftr5FTKA+77+gA4+WKxBbCHP28LgOOcy4xW/FbjRPWGkndKXTqAhHDQ3bVx096260toJLqjaP4vHF/ijpdm9d2huFWSaKDONAMrV57DL392MBgKXA4e4D7aW6Nj3Qf3wglV+mhT7Tr4H77wn7FARIVFcWL8sfww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q4RZevC7sSlZtCLRD4Q2IZFm/c5poqfBx6Wd1A3gmyo=; b=tOyqM7pjsvzyXMMlWqPXHOKYLR38Q3JhrIwVyO0LgkwbZc1Z257NJ5kULsi8thJO+sVoFIh7f4SPB/3UUxBMMr77P4Y2somE7BZJCSOx++EWY//jvbd3rNgXMc5BDmELA7rlyTmpUz7BxyJTz/nsyRePneOzlqhIbvk+T5p885jhzimyd3nB5pp4IbTfIN7dha9WZoAqA4eFfK6Sdx4ps4k1fhYH0v+BtcFBOvKRWNwYFa07HOfKYlhyi70a75vdMuTmF72gqqmiXnr+OtGrirUDfXNK/frHZfYLvJYdiBueKywFPdvDBpij89R2gOpXTbi9qQgdAyEfa2QQ3dOoxg== Received: from IA1PR12MB8311.namprd12.prod.outlook.com (2603:10b6:208:3fa::12) by MN2PR12MB4470.namprd12.prod.outlook.com (2603:10b6:208:260::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.24; Fri, 9 Feb 2024 11:03:59 +0000 Received: from IA1PR12MB8311.namprd12.prod.outlook.com ([fe80::708b:e498:d9c4:94]) by IA1PR12MB8311.namprd12.prod.outlook.com ([fe80::708b:e498:d9c4:94%4]) with mapi id 15.20.7270.016; Fri, 9 Feb 2024 11:03:59 +0000 From: Dariusz Sosnowski To: Gregory Etelson , "dev@dpdk.org" CC: Gregory Etelson , Maayan Kashani , Ori Kam , Aman Singh , Yuying Zhang Subject: RE: [PATCH] app/testpmd: add size parameter to raw_encap action Thread-Topic: [PATCH] app/testpmd: add size parameter to raw_encap action Thread-Index: AQHaB95yFpTRjn1mUUeFcawVmlQj97ECe8KA Date: Fri, 9 Feb 2024 11:03:59 +0000 Message-ID: References: <20231026073047.300888-1-getelson@nvidia.com> In-Reply-To: <20231026073047.300888-1-getelson@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB8311:EE_|MN2PR12MB4470:EE_ x-ms-office365-filtering-correlation-id: 26e439dd-5bc9-4980-1b5c-08dc295ed132 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 20rtZm56+teLbpZkJ1q0rDwhtfQja4L/KDPJ5A8N1WhCt/gBw7brJdm/BR+K7d3T1910HRP/saisjeBs9Cb0dvy+UatyTyu7WUken64fIYWGIFZDsSL5HFstxWkkUmr8urkqMIf2hVg3s2wJ8Zu1SKpt71/0Z8EYdtklaEFXyYQpF/AJ+S1nYQkJxi1geX8q6JvJCG+mnlEAOio7h9iGs+FgLTlfSFQFHe4QI/HwQLu2thU3uvoKAn9IvxvvNmRn516d6CsJYpqXF+SqqIA9XYt1n/Egx1wKddeXUq0xgk8sVwmN8TWExAlJVAwDETfKdqejQx+wlf6QkTT/t2UME4UIzvoffJYXjGxEQ/9WAslxrFEt7NPt5FmCBDjwu9WO7SSeM7r8GIydCap0IzVBdSl7vOvALDIF8mI1nlH5Jw+spachfsIcF3KmxRXp6vVGhxpu1GlCyOeGlFhqY1NGqdePQs+Zuxc1cBCbHjuPATs2vqmJVP69QbG8fkYBBLQrVT+fCXP8dDh57I51bO7j+5HJdrvViFNaw/Vcvgskis1NgtD7pxn6MFy2br2jCCsldNgKKJ9UYVyhKl4NnZAS4IpVWb6LZ3HlxczhtDLavec2zXPwLqyK8ZdS/lVsplND x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR12MB8311.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(366004)(346002)(376002)(136003)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(53546011)(41300700001)(38100700002)(110136005)(66946007)(2906002)(8676002)(5660300002)(8936002)(52536014)(4326008)(76116006)(33656002)(38070700009)(66446008)(64756008)(66476007)(7696005)(122000001)(9686003)(316002)(54906003)(86362001)(66556008)(55236004)(6506007)(71200400001)(83380400001)(478600001)(55016003)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3A11W27JyCUrPxBYdAhfwgwGMrjQ0gku3Rl5Pw1VbDDWr59itUgD9mvDFxwG?= =?us-ascii?Q?0oEajFKYyEPgIwbszh/oQjvTkg5Gc2exwRv+FDQ1iVGGwhZ9RJfWguCmf3c4?= =?us-ascii?Q?jeBJR6Kubdn5QlG/b33s6F0jkbBp22Kd1tbJjDjdepH1elTg9nHhvmuhJTAL?= =?us-ascii?Q?NvcnGjHwtWmVjOtM1fWg4ZYVpJxnSBJxM2IDJ5LsDY3sJWbLftf2kwsN7U52?= =?us-ascii?Q?UWV6kD7Lk9zRXb61Jsgdwl0Gj3SVeGrX6UnW9zdeA7bYTcyQEMwY5VqDK5Mm?= =?us-ascii?Q?gBtmxSd3BDxobUlPLvnNr7p3XDM9mgoADm/G2SxivYV4fhmBDGuCwOrqyccX?= =?us-ascii?Q?6FG7eVRH3KUWV7krJdkmFpARJMtUFu00TcLGUf6OE/tg1xJhEQq7g64OuyTf?= =?us-ascii?Q?FXTLtQ5tEB+6wU0VamoukhSVqSs0cjCccfZLyo1QOeYPqf33gJgBM29goKdq?= =?us-ascii?Q?364vlj3+QgrS6oWhbhentVLNb97LYfZzxdE3H1kTmern9lUEZMK+lhtdQKfL?= =?us-ascii?Q?mBSoQ4BnShRvxpE+jqMS5kJJb5Ku6O/eZJB8lQOM6dwBU4XM8+rMboqXiLy8?= =?us-ascii?Q?acKK/Yw2fGHpgbam5De++iSMKzhY106qAusb6c8NpUCCVp/SXgtldNLtdlaV?= =?us-ascii?Q?XpyFtpTHYT2Z8e8qr1FVMtETgkf2WfpjlHZmRmJ8ryoAv8RNy6qYsOv3LMle?= =?us-ascii?Q?k78M0/933VEnWUCFHR+I8ucWt4YjI8BCJrDjMVp6yYMASD56NhToYnZtIrI0?= =?us-ascii?Q?TqDSa6Smzd38z34JzbS01GkiUODnonpid51AUEalDZ2UYtCNRrwEvxbiuzFR?= =?us-ascii?Q?VGarFBUXaf2MmJZ4z0kKkW5RPHcBnr+FO0bg6n1y9G0GF7eFRzTP7EK1EGgF?= =?us-ascii?Q?aI9Uf8f2Uq2IbobgAXYtTjFY55PXEAuVgguGFLPgGYiGaSNNe64IsJRKBVSR?= =?us-ascii?Q?0IdnYdQSUZSUk7IdgwSQCKiLixb+T+2+C1v97b627agMEey2xFgPjyqPFJ5s?= =?us-ascii?Q?f+H1GWZsWduF/NJmQWlsQL28V0Zx/YUQczrZ7DZ9weOuk5XlZVCzfSM/Foxo?= =?us-ascii?Q?KfamCCeLvJbI85zDodePaOmq6cXKvlS2R4s04IZ6IEyvAv2YybwGhrOejl5m?= =?us-ascii?Q?gYJXbBsEXYQulbw+hA5Ag3N1D6mL4pCQKfVXfSsYMlK3q1OMeNepZJSeS9Sw?= =?us-ascii?Q?IXkAT4EYgCb0sVzHlM/0TZH2zwkaNu6+wzbf2A9Od8UMiFRJ0WCeORjLVCtL?= =?us-ascii?Q?K6Kw0BlxSMtSymTTWCm1lVpRq/LNcroXUltEWtqNaI2s/gfOcMjNZpSNe6HH?= =?us-ascii?Q?yU7z4Mhm9jTNPUlgHxg9lM084MY7MrUUg3G9dVQ3rSrq15bDZSZLOfqfIU0Z?= =?us-ascii?Q?2TWf9nn2zP8QxfB4UvHDCi241eONdcU2yTy1CFwynZHmj0nHRVLFYnDHUF5T?= =?us-ascii?Q?b1UJ3+e8oQpFA0OQBiqytywIJ3Im47YdqEJySf5WKHouKXQ52qpG/uqRCZWL?= =?us-ascii?Q?bj/ot8/Pd/Dcn9uywnYHcaNZUKauxfZvPKNcJBlv/Y0CEr3XyUR0uGE7yOqI?= =?us-ascii?Q?NqYLotJ/7MNXQXBg/qQE7ZmpUyXpCWY/ctUl/xgS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB8311.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26e439dd-5bc9-4980-1b5c-08dc295ed132 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2024 11:03:59.2749 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HAWwv9UK/PSRwpC3AdE7mA1C+q8KVJzMqdQkD32HalzSbINACM388pIeywA/P9o3WqcPAwy5wvIPpok97Iqv2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4470 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Gregory, > -----Original Message----- > From: Gregory Etelson > Sent: Thursday, October 26, 2023 09:31 > To: dev@dpdk.org > Cc: Gregory Etelson ; Maayan Kashani > ; Ori Kam ; Aman Singh > ; Yuying Zhang > Subject: [PATCH] app/testpmd: add size parameter to raw_encap action > > Testpmd always provides RAW_ENCAP flow action configuration with encap > buffer and the buffer size. > That implementation does not allow to create non-masked raw_encap action > in the template API actions template. >=20 > The patch adds the `size` parameter to testpmd `raw_encap` action > configuration. > Testpmd can create non-masked raw-encap action template and specify encap > buffer during flow creation. >=20 > Example: >=20 > # total data size is 50 > testpmd> set raw_encap 0 \ > eth src is 11:22:33:44:55:66 dst is aa:bb:cc:dd:01:aa / \ > ipv4 src is 31.31.31.31 dst is 63.63.63.1 / udp src is 1 / \ > vxlan vni is 1 / end_set >=20 > testpmd> flow actions_template 0 create ingress \ > actions_template_id 50 \ > template raw_encap size 50 / jump / end \ > mask raw_encap size 50 / jump / end \ >=20 > tstpmd> flow queue 0 create 0 template_table 0 \ > pattern_template 0 actions_template 0 postpone no \ > pattern ... end \ > actions raw_encap index 0 / jump group 1 / end >=20 > The new `size` parameter is mutually exclusive with the existing `index` > parameter. >=20 > Signed-off-by: Gregory Etelson The following sequence of commands results in "Bad arguments" error, but I = think it should be accepted.=20 testpmd> port stop all Stopping ports... Checking link statuses... Done testpmd> flow configure 0 queues_number 4 queues_size 64 Configure flows on port 0: number of queues 4 with 64 elements testpmd> port start all Port 0: B8:CE:F6:7B:D8:E0 Checking link statuses... Done testpmd> set raw_encap 0 eth src is 11:22:33:44:55:66 dst is aa:bb:cc:dd:01= :aa / ipv4 src is 31.31.31.31 dst is 63.63.63.1 / udp src is 1 / vxlan vni = is 1 / end_set testpmd> flow actions_template 0 create ingress actions_template_id 100 tem= plate raw_encap index 0 / jump / end mask raw_encap index 0 / jump / end Bad arguments Could you please take a look at that? Best regards, Dariusz Sosnowski