From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A70D43AB3; Fri, 9 Feb 2024 14:43:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 469D542E64; Fri, 9 Feb 2024 14:43:11 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2078.outbound.protection.outlook.com [40.107.223.78]) by mails.dpdk.org (Postfix) with ESMTP id 7ED9F40697 for ; Fri, 9 Feb 2024 14:43:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iEviF7gJPKpDag7fkd+uery93ikukuQESO7aKSypt03wtCnrIC3jYjk6xaQBFaoUyE/g13rgAmIuxYQjRRCF7Z4B418z39Z0ivU096oTWS5EQDpfYYQ+J641R7zejV/8mdgcH9nqOYeU3LbgtwSXFJPT/6CctmysB+D5eRy3aft6nRPUFDykqQGGahia+1SGD4721CsyafGLvrRX16VlOMREslIfn3FaOiI/ujD2YIMKvlfZoq+aKvlVbUdxt9XvbFbHGaYW6czVvmX0wW6wzm1fCll2VgkYxczboz7SVOgCXJWp1PNNUSLzl37gbuJGWMxWdatwHJsRmVOXYJkTuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QT70xzjGNNZNScE4SAzWcrN5XKqM6L4KdxkiVBmHBc0=; b=Iu0JMcXtebm4XBsFTs0+VK1b0/8DVTuiBdH8CCHQAN9gxkD9St4gBV3rakCQi5h7sWzht+Bc/yuXqi5oc+lAID0twUOF8/pYJ68Y1nzVRqQfA/pKcV5M2D4AFv7wVcw7gGpJeLEiSIT1m0c3iW1qOn20xT4gOOcD2wNGbQqne2XPfSolJ4ZNmMXZjqCMiTL3Nw4qjT1mVgjv2q0jc4QhS/INZ8ncrOzO1jrlLFx09iw7HbLbaxNRSBpHPEc2CUEMXp92V6WoDMeE2EKVS4OO6DUPWNz54mK+9KMHM+K/6IwQLkuBfvK0tFq1u5XsV4q3Fa/OqNLanrzap7LlQZtAzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QT70xzjGNNZNScE4SAzWcrN5XKqM6L4KdxkiVBmHBc0=; b=A6qCNmIakEYoWxhq9bp/fSRtKjKFkBAvyefJMGrncwuK+/AsW/zGZgIj+DeaZaaJkyXd7WxRzeXVE3ngptxQcg+VcA/n+hED/95DHpSX6d3VJW5GLdvk8uKmQjXdVipsB6ofvDQyIBnFmLO9LENN5gG3NHvaBtho6ezbw8XjPn6nOM8/kbkhqJzgtnwK8G4saY5KfZ0T2nbV9VvydT+f+HinlFvuVDOTKBbLbKTmJ2/VS5nvZE9Kw251Dq6Cl80N2dzuBC90MALOibYJlCHxroMItaDwgjNYjdOp1dex+0MBygc+s6Lf2zenRi2o8PZZV/asiwEUYg9NTFssXpP2fw== Received: from IA1PR12MB8311.namprd12.prod.outlook.com (2603:10b6:208:3fa::12) by BL1PR12MB5077.namprd12.prod.outlook.com (2603:10b6:208:310::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.11; Fri, 9 Feb 2024 13:43:03 +0000 Received: from IA1PR12MB8311.namprd12.prod.outlook.com ([fe80::708b:e498:d9c4:94]) by IA1PR12MB8311.namprd12.prod.outlook.com ([fe80::708b:e498:d9c4:94%4]) with mapi id 15.20.7270.016; Fri, 9 Feb 2024 13:43:03 +0000 From: Dariusz Sosnowski To: Gregory Etelson , "dev@dpdk.org" CC: Gregory Etelson , Maayan Kashani , Ori Kam , Aman Singh , Yuying Zhang Subject: RE: [PATCH] app/testpmd: add size parameter to raw_encap action Thread-Topic: [PATCH] app/testpmd: add size parameter to raw_encap action Thread-Index: AQHaB95yFpTRjn1mUUeFcawVmlQj97ECe8KAgAAqF1A= Date: Fri, 9 Feb 2024 13:43:03 +0000 Message-ID: References: <20231026073047.300888-1-getelson@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB8311:EE_|BL1PR12MB5077:EE_ x-ms-office365-filtering-correlation-id: 4d754723-495f-4af2-c4a4-08dc29750a16 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xlAodqbDlSt8LVP4B8Mznfc1h10x0f2/0d4v2jtCz5/dIjcUYAsnPPilp2ySvJPH8Sww7WNkTByWkXJVVJKItXRQh//cHRKDeadg2yWeXGBCPFy+Z64sKOVmlIGbWJIiRqKJePE8xkdrKJsnonU5j4xd55Bv18d+mNnHWNeI6OqCOCpe+gzhNJntvYT/tfP4aA46y//lwIb1Ak7VtSV9vyvpvDo3bCbBw+DESXIr4/zqTNaPDRZg170oS+EgCKoTOr2ah6qqhlGUY/KKYg0sQ/Z2m7qda+SjI+BJ48V/4R6DQCwytk3Mo7+tyPktzibufzT1KJF+N9PU2i4EuUk3B3oUBXgKw3GrtCz2ayl2os372Bf+hfrQL1hptBp4iNjYY/V7X35yYtEUOeSYFnCmLUJIPDuCBO9kFf1ntO2HUF/waDT24+QTNrZZu4MPGSdRszZOxCkS2U8sRwCvXfDvmFD2fao9rr/93a4y5E6vZh3EJHRcKQdVnRoK3QQbu7ZZTxgTxo112IMrfBHeWVgFKUbSizB/34cWaedzmIK2iHm9F3fIKWSgW0kOi0nl+f+Nw2ZPU+l+cH2F1+wpQmANGhllHd+3m51ki2157zGDN3yJMG5TdoLFlx4Y5v99Ze5B x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR12MB8311.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(376002)(346002)(136003)(39860400002)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(38100700002)(2906002)(52536014)(8676002)(8936002)(5660300002)(4326008)(33656002)(66946007)(26005)(9686003)(2940100002)(38070700009)(83380400001)(110136005)(76116006)(66556008)(66446008)(64756008)(316002)(66476007)(54906003)(122000001)(71200400001)(7696005)(55236004)(6506007)(53546011)(478600001)(86362001)(55016003)(41300700001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ifh2qt5CN88Ru0cKdlWpJ0EgdUhhZ0LfhWlNG4QcYWxyf8iKa4nQtL5kkjoK?= =?us-ascii?Q?bK82+SZg0v2A1FyVM2Yhs2errc9BH2IAtuK7ygFh49pQjpIoAW64ez5EfUDJ?= =?us-ascii?Q?apKDwgFdPbnr1CudQg5s22kwC1LyoiMVCU8uYuIxArBxaBEcCyN382qCQSSQ?= =?us-ascii?Q?O0jqZaPI+l30oZZ5mG2vI2S64l9l8xQ1jcwElhCUfJ00Kwc3+TIMbfwTDtdN?= =?us-ascii?Q?Fa65T6Pm3jfn3aXBZVMl3j5E8htr+zNfwyMuTK16ZwNwAS/G3CJ8DwnhqlHi?= =?us-ascii?Q?igDRIm4R1nlPeuBTPMamZLVC+/ozyYuQYuy9Z/oo/7YeGavR9sLs50BG7lat?= =?us-ascii?Q?XSBh2hvolYu+nYIt/FQV0Z38syox6f34qT74noVHhzThLNEWySBWT+HdAW4Y?= =?us-ascii?Q?DmrDjXwGzWfVL93y3U8vxRgURWyleTR+/44VytSHpZ1ar566TW3Gf4Ttyygw?= =?us-ascii?Q?7zCm64vdw8ob7PikfKhvV9oc4CfAEhTibbTIPv/E819fv/Nl27XzCXzxaBRI?= =?us-ascii?Q?QnbhIOrqBmn1QbnmMGzVlHGzjlfHx7owKNxHV7x/9VFMvPaeVGE3UpIFce1y?= =?us-ascii?Q?O/ja6sGGyDY3uwPZbA1Pc3Qs7W3a8A3dYnrPi4S5+EZW/X9zl+qj5tiC6hls?= =?us-ascii?Q?h+qWBNUMU52uXynGEqAW/Q8Gr0FVw/Zxe7LgGeddU06VqIUXybEKwCCTW6sb?= =?us-ascii?Q?zlPfQwKSDVem4ViZXbFaz3YvEnKnUTOF828etYzbdcO0WZxkfm5lPP9bh2N/?= =?us-ascii?Q?83R4wB5iw8MMN9e+EQ+w+PIxJIuEVWI3XBu3jdCGhMdek/OROEmTYr/6KfVb?= =?us-ascii?Q?6PH2cgpG5exQzsVOoG1Ry1JxtYoMBadjAg9ZS1Tjw0WZJw/LMBa+kGX/Wjz2?= =?us-ascii?Q?dq8DKkAjnnzVTVADgaGAKeTyVCUXFKgPAOx7PTUXZuhTU0K59c94UXLcT3l2?= =?us-ascii?Q?28khtr3fqf7vcI1ToNqO7yyWZt0BIIfqxAfG3+mbcqx4oEg36YYbqgrTDpCH?= =?us-ascii?Q?NFDaACrbmXfKvNzl5d3KOEEJL206qYDAF7JIdJ55UHLXbRdMqG5pk+NUGE5f?= =?us-ascii?Q?MeLycZA8Jc2l4YVal/3C4lmm7QvCwbXUGMsdV6wjjUqVjZnE5vTJku2wzdOv?= =?us-ascii?Q?q12pxYhTi3/2zz+MwIbeX9+NvaLUM9oiAq9yCGnC09ufMK2dbg1FA+dbGG7d?= =?us-ascii?Q?Z4ql4JyRUYOIq5TVX2UIFKU+p6dZk85v1AsdTDwrw0IiVAT26RW2RIn/mbTt?= =?us-ascii?Q?+VVNmxMHlM/LIgQ/W/GmG40c73xPaWzyHgM8ctX8TVO0E7Vh/E+B7B5vhuwu?= =?us-ascii?Q?jxSplcDg4nbKZfJ0GATieZzCQXhqDRqizo43EOml97hSMJxFXUrlUCC62nJ4?= =?us-ascii?Q?pk9yRQ7tDkBjcbmE0qoNbr/JHNmEmVSJYKHySGEe4BXaZ6xis5FR4p9QNAfc?= =?us-ascii?Q?Q0xt3qyoZgpN3wR2bg8CLlUyDKdY8q3fOfeoa8PIAKXCDyPMgiHV3XPkHdMC?= =?us-ascii?Q?kDfZ/u/39dPF3xpurLkmh+qmgb2vlAS5aMEkNKOZCQKCfRoKY4+TK4Hu2Fhz?= =?us-ascii?Q?YjxhdUmoIE0AEuzkGg9EFchYdPl3q2qIVvUuUMGb?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB8311.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d754723-495f-4af2-c4a4-08dc29750a16 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2024 13:43:03.6748 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NTZlda/zl6b5r951zKXvRAncJj6TjkLqv6atxchiy9zk7HM2GMG0ZfsChZAwwKwLP/2t4BTcqGz0Cd9kTtCuxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5077 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Dariusz Sosnowski > Sent: Friday, February 9, 2024 12:04 > To: Gregory Etelson ; dev@dpdk.org > Cc: Gregory Etelson ; Maayan Kashani > ; Ori Kam ; Aman Singh > ; Yuying Zhang > Subject: RE: [PATCH] app/testpmd: add size parameter to raw_encap action >=20 > Hi Gregory, >=20 > > -----Original Message----- > > From: Gregory Etelson > > Sent: Thursday, October 26, 2023 09:31 > > To: dev@dpdk.org > > Cc: Gregory Etelson ; Maayan Kashani > > ; Ori Kam ; Aman Singh > > ; Yuying Zhang > > Subject: [PATCH] app/testpmd: add size parameter to raw_encap action > > > > Testpmd always provides RAW_ENCAP flow action configuration with encap > > buffer and the buffer size. > > That implementation does not allow to create non-masked raw_encap > > action in the template API actions template. > > > > The patch adds the `size` parameter to testpmd `raw_encap` action > > configuration. > > Testpmd can create non-masked raw-encap action template and specify > > encap buffer during flow creation. > > > > Example: > > > > # total data size is 50 > > testpmd> set raw_encap 0 \ > > eth src is 11:22:33:44:55:66 dst is aa:bb:cc:dd:01:aa / \ > > ipv4 src is 31.31.31.31 dst is 63.63.63.1 / udp src is 1 / \ > > vxlan vni is 1 / end_set > > > > testpmd> flow actions_template 0 create ingress \ > > actions_template_id 50 \ > > template raw_encap size 50 / jump / end \ > > mask raw_encap size 50 / jump / end \ > > > > tstpmd> flow queue 0 create 0 template_table 0 \ > > pattern_template 0 actions_template 0 postpone no \ > > pattern ... end \ > > actions raw_encap index 0 / jump group 1 / end > > > > The new `size` parameter is mutually exclusive with the existing > > `index` parameter. > > > > Signed-off-by: Gregory Etelson >=20 > The following sequence of commands results in "Bad arguments" error, but = I > think it should be accepted. >=20 > testpmd> port stop all > Stopping ports... > Checking link statuses... > Done > testpmd> flow configure 0 queues_number 4 queues_size 64 > Configure flows on port 0: number of queues 4 with 64 elements > testpmd> port start all > Port 0: B8:CE:F6:7B:D8:E0 > Checking link statuses... > Done > testpmd> set raw_encap 0 eth src is 11:22:33:44:55:66 dst is > testpmd> aa:bb:cc:dd:01:aa / ipv4 src is 31.31.31.31 dst is 63.63.63.1 / > testpmd> udp src is 1 / vxlan vni is 1 / end_set flow actions_template 0 > testpmd> create ingress actions_template_id 100 template raw_encap index > testpmd> 0 / jump / end mask raw_encap index 0 / jump / end > Bad arguments I bisected the tree, and it appears that this issue is not caused by this c= ommit, but it's an existing problem in testpmd. The root cause of "Bad arguments" is the fact that when parsing function fo= r raw_encap index is called, parse_int() is called with size =3D=3D 0, but raw_encap index size is sizeo= f(size_t). This causes a failure in validation introduced in commit 913b919906da ("app= /testpmd: add size validation to token parsers"). The same issue appears for other cases where parse_int() is called with siz= e =3D=3D 0 e.g., parsing RSS queues in RSS flow action. I'll provide a patch for testpmd which addresses that. Best regards, Dariusz Sosnowski