From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBDE743A28; Mon, 5 Feb 2024 20:18:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8746040ECF; Mon, 5 Feb 2024 20:18:30 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2068.outbound.protection.outlook.com [40.107.93.68]) by mails.dpdk.org (Postfix) with ESMTP id 8FFA440A6E for ; Mon, 5 Feb 2024 20:18:28 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iGfrlWBdnnTIE+d2vqiMOgmGpXWMyKLLEQCddPUaxQi8Sqwlso70aPQHK8BRMNIEHBRbo81S2XbeDhjzmdOcpP+nbqP8XDBWobiJMAXkQvBARXO37O1no8b0tkU/ZINWecLSzOYNCz/Bpm/5YOFQ/topLZbidYoDUkexD5emOyQcdwKLcbmdNy7XQFGql3k8TdBYcorvon+tzuT3P1yHSVd2j7W5G7ot9U6L681zCxYMi8g5YN/8/R5hNw+YLvasvfWcWcm0G5ZpzNl7MAhhetmGnTr1Q7UKXGXWHYuTn63ABJ3yp/h+eoOBU70cfcXoIUPJUy+6XK01hJZCgt54HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cMJpDPIvVlS/CkXJsReFj8FmblDELLT0C7wz4WuntLQ=; b=oL4c6tdM5nxsRgIybh4c0zgl8PsIzOBuS9CgmRWx3Ub2OafKbTljdg2ejAO/HHAWtOxD2cOHhFwCpLSWzpFxVG+EnGxwQ5U57Z694pRRO7MSqCHA/39h9QnzOcbPCEo2xDgzrSElRkE1rYqaXhi02rWwLyS7cWEG65iRpo+7tdgFHtecCRUTihmELQ3w0Lmvy6KXbnumD98ohlBwvVBpSJ7rJBr+8jOMU+bkaaJFzB203Xv26owrdlVvNbyqKf9fTFaSVtd2TwWkqywzDGY644a1kNEeJnqHfpkI6K5MTh4jGSNP9efAq9jQp7HDxmmF5Qp/gjA2dbVOSVXuPNqAZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cMJpDPIvVlS/CkXJsReFj8FmblDELLT0C7wz4WuntLQ=; b=eKjwqFHw3JegSPCB0/VJXbyzoQ7nePPaFmAqRgVD67rPtgDrPWaIlPzabGjqW37+EwXBHnli4L9GO8fjXN9l5Qkh3kvoYJ1wYGkYTbSO8L0fdAy9tl+GwX7vFhHhTkqv9SxctJW5oDIK+aKTkfRSVDXauAi+wiUSKswxrvf+QDQGqDvn8yuHni+qwzH/Sradp0k40JaYk6NmEHCWBTntDR8xVYZR4E7eAqjXnrAAvW1yiKT38hr8iyF1vVKxldhNDVoJ2ZYLreMpRT1/hyHecOPe2MJbAjLwUGg6Ve4uqUTcCjKSMpOU025qjmLMcnVjVml5x3vqWLEFPbj6QjErdw== Received: from IA1PR12MB8311.namprd12.prod.outlook.com (2603:10b6:208:3fa::12) by DM4PR12MB7717.namprd12.prod.outlook.com (2603:10b6:8:103::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.14; Mon, 5 Feb 2024 19:18:26 +0000 Received: from IA1PR12MB8311.namprd12.prod.outlook.com ([fe80::708b:e498:d9c4:94]) by IA1PR12MB8311.namprd12.prod.outlook.com ([fe80::708b:e498:d9c4:94%4]) with mapi id 15.20.7270.016; Mon, 5 Feb 2024 19:18:26 +0000 From: Dariusz Sosnowski To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "mko-plv@napatech.com" , "ckm@napatech.com" , Oleksandr Kolomeiets CC: "aman.deep.singh@intel.com" , "yuying.zhang@intel.com" , "dev@dpdk.org" , Ori Kam Subject: RE: [PATCH v2] app/testpmd: support updating flow rule actions Thread-Topic: [PATCH v2] app/testpmd: support updating flow rule actions Thread-Index: AQHaVPVcgr0CvvOVikWr3GKn8rN2abD20fkAgAVLegA= Date: Mon, 5 Feb 2024 19:18:26 +0000 Message-ID: References: <20240126132142.2649250-1-okl-plv@napatech.com> <20240201095907.3564286-1-okl-plv@napatech.com> <2800280.mvXUDI8C0e@thomas> In-Reply-To: <2800280.mvXUDI8C0e@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB8311:EE_|DM4PR12MB7717:EE_ x-ms-office365-filtering-correlation-id: 3a059b3c-2803-4444-c868-08dc267f3a58 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KmfLp7sDw2B7FAoGMji0zj1LjBnV/9IPalVl4A327K3b6gWrWdlCfHSmFe3sOAIMowiqe6k92aeas614SHhaTXlIu4faI5LNfiJ8kFXpGqKZuV+BpfLPFUxI5yRbWgu9MZGaLH3r268YPlharHCU+ePSANbPIactSqYa15u6Sl4F/h17W9AJWrQFiLJuPa8meqEzUV/5Z3QeIzR2hRuaZZ111EzVblerBfg7P1L6bU6DWv+e/WDvj2yHK5D+AtGChcjNfLK6srVRil2rfvvu2IcFgoBI9OtOL3GzLzZf3S291+x6o/Tuij4PRkLSjYM2h22X+FJa/C08M7cOy5/6LRDZ3XGHUxyBZpjk/8FBuZWzTLCuDYkZ1vZcU8pQC0J0tAZuUi7CSTWWimbW4aeV2XKzbNFxF+lyZhlG8rJpEJbkaEdkDI8BedjEe2Kogpf62yejJgMkL56LTzw0H9Nhdv5yGFNsKD9oF4FD2fWwtZoYKosxbvE3m+8ofyuEUDDnnoxlxskH1YREaF1XDmO/8CrE5etk80LtBtxkYoxNHXfqfN1o8SS5KFbPTIhkjwWO1uttplqR8/64MYsabIXb03Kq4A0vjqgAB9HBYrx5z+fkXUW8oHxVW2H1zv0h9vM6 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR12MB8311.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(346002)(396003)(366004)(136003)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(107886003)(55016003)(41300700001)(122000001)(38070700009)(86362001)(38100700002)(55236004)(83380400001)(26005)(478600001)(9686003)(53546011)(6506007)(7696005)(71200400001)(2906002)(66446008)(64756008)(66476007)(110136005)(54906003)(316002)(8936002)(66556008)(4326008)(76116006)(52536014)(66946007)(33656002)(8676002)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NQYFSL5IFh//+M6Parp70LOgQ+2x3kk/Zuohuwlmmu+c9iAXX0FNes6UTCMc?= =?us-ascii?Q?o/COliNZpFawNMWZG0rnFSnKqDkByLOhnSzp8VK5SAQ6FovFR2JG8XhFeTZy?= =?us-ascii?Q?15+4yZlYyBs+WMS54VvbGUkl5B0JPk6CWhs4ZoJysJMKrTguoRpDjQXMpn7F?= =?us-ascii?Q?F5KPb9bvXS/w6pRGALMRRoytbszX/tGm6HmueYyx3LU8+kOrY80xme/xc+0O?= =?us-ascii?Q?w1W2msqaEjI7SBSQPNBe0YV2V9tv6QcOaJ3zynFP+bVoTPb3SboEY2UqBDoJ?= =?us-ascii?Q?uBojXwHJJ5tzjA3hRvmFvEcSCmbPe/wZ9v5YFTbKNO5H1pgkQx8exhdS9aP6?= =?us-ascii?Q?QYWpTVj971mnMEpJQ0wAan5oLi6Qa4pzS4qWyCzfvpSqFdK1nimLAjdXQxe7?= =?us-ascii?Q?CCmoX0/YFSKRcOI1g1+qLBVSDUdfGut8e0S7FBbSQ5XYHn8ABxZE2RAz2tnQ?= =?us-ascii?Q?dvoPzkrbf8hNrTNywyqT+paj9qHBdPnDTJEEL06luxh6BtY7j3Bh05f8nH/o?= =?us-ascii?Q?/l/x6PNzJ26DqrYJZsyu7xkeH1uYJPh/IK57xVo3kxsRp7BaKw7LV5J5j85S?= =?us-ascii?Q?cHNTaBrevd1RUUL+69WWYZIrD9SYaasOI+DtD4qlZQlAeSMH7BwZgTnt57h+?= =?us-ascii?Q?SveA4cgNiS84ku6KG7WRFKQEZfwWy6Fjz1LhKODkqXKvsKBueZL856Kw8sFG?= =?us-ascii?Q?fepXPfCEHF2XYF4EcMsMDJI8kXsuesavb1QDbCL/yXQnB8OdsMx20E7WF+fH?= =?us-ascii?Q?8Vi24xZnoNyUw+XWVEhgJoi5BdgzS/GacEGcS+FGsQK8WhjqFw9Ko3ioyDJk?= =?us-ascii?Q?n2a0kmFxWvf2CDsyIoDa+kl2mPTQcZnEewuqc/kJF0p/P+gGH+bnIiGlq8Ab?= =?us-ascii?Q?vHJ1tb+q7SxhDlzIFNQ47k6zJK6fUnFcVUn54Tu+ncTxH5dG6VBfz+/O4rpz?= =?us-ascii?Q?qUqLu7nK8rwfzYG9+fFO3kvr1CWLYlHko5Qc0yzsYV8Pdz+6wyH90byHnQ8b?= =?us-ascii?Q?1azcaY6f8+BcReOx+V3FuoFlQbq0xhIZGegrZK6WwbS8xALJ04QnV9D6+ib6?= =?us-ascii?Q?I7DCRq32pRo1Uecp4qGLxGpZyj0fvyNBHRwb5Kb1zY3XBSefUOhTW1d1VbYb?= =?us-ascii?Q?VcsJaySK0TGoGijdTff+CxFnjdJ6Vzq79X+thlcDtNa2O/35s/b0cKnvZLLK?= =?us-ascii?Q?Bxba6P0emTq7GnaPs6q646Zxgd4rsVHc1a9wlgRL3Bj6iZUwEcnzheu3AQrY?= =?us-ascii?Q?fIeqaBsXVN6KYGUw+tofAsdwBiSO79o4TlgmguH4uEpW4Zs7mwTI5NGsgIGf?= =?us-ascii?Q?Z4cYkzw//mj1FMCeiYd2JaemUY/P7RiYqkguyifCHVjkJbjunc/J5OEaeMfe?= =?us-ascii?Q?Y2OWdl+203S6UPmJvtcKsu5T4+yZV7P8tJlI/gPdv8SrR5+f0yWQeDBoufXd?= =?us-ascii?Q?hC9e3cAM8A3/h4Y3PIYjWvC+R9q78Rr9d5nFLkLw6xtxTvtFh3atFKZolEsD?= =?us-ascii?Q?d4KH9J5Y2xbp/WYUa/dEOTzCvfPEAfuUhiVsDCQvT9xPmNNLKyhaAVhp288P?= =?us-ascii?Q?uJezUKqZmWjJ7/JrNIQY6zS+G1wFqUEPQEtNuzBU?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB8311.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a059b3c-2803-4444-c868-08dc267f3a58 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2024 19:18:26.1193 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /PftGH71Kx455TJWhP8+fkBR4Duq2+rMZoBNjNn7j3FBAcqYBxVC243so9hrksydn3mkFWZoF4JKJ3Lx3yA2tQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7717 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, February 2, 2024 10:55 > To: mko-plv@napatech.com; ckm@napatech.com; Oleksandr Kolomeiets > > Cc: aman.deep.singh@intel.com; yuying.zhang@intel.com; dev@dpdk.org; > Ori Kam ; Dariusz Sosnowski > Subject: Re: [PATCH v2] app/testpmd: support updating flow rule actions >=20 > 01/02/2024 10:59, Oleksandr Kolomeiets: > > "flow actions_update" updates a flow rule specified by a rule ID with > > a new action list by making a call to "rte_flow_actions_update()": > > > > flow actions_update {port_id} {rule_id} > > actions {action} [/ {action} [...]] / end [user_id] > > > > Creating, updating and destroying a flow rule: > > > > testpmd> flow create 0 group 1 pattern eth / end actions drop / end > > Flow rule #0 created > > testpmd> flow actions_update 0 0 actions queue index 1 / end > > Flow rule #0 updated with new actions > > testpmd> flow destroy 0 rule 0 > > Flow rule #0 destroyed >=20 > Why not a simple "flow update" command name? +1. This would also make it consistent with async version of this command -= "flow queue {port_id} update ...".