From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3C2F439A7; Tue, 23 Jan 2024 12:37:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B22A8402E6; Tue, 23 Jan 2024 12:37:07 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2040.outbound.protection.outlook.com [40.107.212.40]) by mails.dpdk.org (Postfix) with ESMTP id 7914E402B0 for ; Tue, 23 Jan 2024 12:37:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PLl3L4vzWUos6I46x+LiMxDkm8sY+SxIRe6Zb8Fx9qQHZlhwbs772gHewBapYMoAIsy2LfQpiEalVReOWUyvkMQ1C3wGa6g8l8JbdcSUdlbtOgAxpMmMajMJBqalCS34GJa1O1Fre8fpPjBhIxoJOCH14wWazBAfIiCuZfmaTflQ4a6ydpqGOEoIYs5HgWGDd562UNJ1XFdsC9OhpaHsCtS4dczrG7SDzz9ta0FR+jA0OlrsXExOungIVG0d82NwPykCYNLnsFWkkT+TFvS2HDz4o+I0VNq6ob6sO7HmKDxFlQyFKOHcYP6wQHK/+bMy+n0p9OJLlFhdqQEpLn4AgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2LwtugBERBoWfzF7Z7brhEKLPIe/HMO5VW4up2Khf4Y=; b=k5I2RkMJ686f73j+1HJt91vWgWxawducVORc8Nn3V31XKr66DoBwnypk06BaLOadDhMkqhXaGD87aKrjZgFh7KDYTvhS3rWye98btm5iPfi3xn6SM5QC7V0OaRqRG255jUm4tfT5sp6RubGT1/RVdbQE3BmycohM1sgaK9WhQs803MLGIOZzWe0jGIx+tKoGidkSlcs4a6mwf2AM5IQzzDIcURpLRyehv7S08/nxfVmUM3J+dcNtuh/gi2E9LWOw4NyjEZnJL3yYNFfh/ceHw6iByeIVsXwhFry2mcHBPrrJYNm2mkbXSlnyF1AquimiRIAv1dNk87vEIyW8D3DHag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2LwtugBERBoWfzF7Z7brhEKLPIe/HMO5VW4up2Khf4Y=; b=q+Eh3Ao+ZW+TQy3wpTMOrGkTgauChalMvkopQfgP7W9jCGMHusTbxHCx3InTb/bJhNSbAkIvZjQ+uvt0Ev+rwCl4MmnfXpcwofc8ZX/bIusCTaKQH2oXv1iMRAFxaYsWrlawsaYU6MEZocnPLQQSo4Pjh91Ypymid/Km/9I/bu+Gega+BMsvOZ84QU44oNL7Ux65Hbgkus+AcREyV4BZsyMrASpopYglNuEWCCQ9IXbkhLPy7rVFUzPj4T3mF4vB2SOC8O+9SJFyf7dcqr4knfJFLOPrq8BKL5OI6q4TeGTFV+wGDa4bNiRsBXz5LKOpIYuwu7TF+Uq/wLVugtUbEA== Received: from IA1PR12MB8311.namprd12.prod.outlook.com (2603:10b6:208:3fa::12) by SJ0PR12MB7036.namprd12.prod.outlook.com (2603:10b6:a03:483::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.24; Tue, 23 Jan 2024 11:37:03 +0000 Received: from IA1PR12MB8311.namprd12.prod.outlook.com ([fe80::708b:e498:d9c4:94]) by IA1PR12MB8311.namprd12.prod.outlook.com ([fe80::708b:e498:d9c4:94%4]) with mapi id 15.20.7202.031; Tue, 23 Jan 2024 11:37:03 +0000 From: Dariusz Sosnowski To: Stephen Hemminger CC: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Ferruh Yigit , Andrew Rybchenko , Ori Kam , "dev@dpdk.org" Subject: RE: [RFC] ethdev: fast path async flow API Thread-Topic: [RFC] ethdev: fast path async flow API Thread-Index: AQHaOLOJMBiGV3bi0EOK9su1qim887C+8euAgAl5pJCAAHfyAIAeiClg Date: Tue, 23 Jan 2024 11:37:02 +0000 Message-ID: References: <20231227105709.1951231-1-dsosnowski@nvidia.com> <20231228091657.14769682@hermes.local> <20240103170758.119e99d4@hermes.local> In-Reply-To: <20240103170758.119e99d4@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB8311:EE_|SJ0PR12MB7036:EE_ x-ms-office365-filtering-correlation-id: e97d0c9d-7395-429a-abb5-08dc1c079e85 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wbqeP2Ag1GffzaAd/RTyTYYmUU9/8oS2J05P1176KIpbQHDIpxh61jD2kOoDut21DlTDTfd35nWGob1oRzwPREBHWvCnQeqfHgqHeda/BTND9DJrRL0oHFhuaKfb+1Xms7xT1onKTzd+sOh8WZfFCr0eA7KamMMOKfeEjpo75zkcPWDBSB5UNsd6enK+hyprtU7Ly+X3aMtbHlR1EnwvFvhr1WOjsbM2/ybWSxGfJC1I1bCxACsIGxz4X+w2wUoIjH63n0tx1TcmSkn3lAesU41c5r1bromhvcxqqo9iEou9Y+Tf38TpYUZ8Aw001WS3VXEe7FeBbJ6Z2HP6iSIiTb1f8XJSibGypAmY8xrrRu7EutOuMVY2WLzox2zTr//wYLhbtPAJsOA4dsh61FWc0W+YeS0OosdKey72tNgrxskRI8K/guEXzVw+cW3Jjddr1dnHyKymY/S8WkcVhXH/jR3xLxwY2vsfbC10ST5a1PmuMbAYM3jPm1Tz9JRQc1MEILd2c+9TrQ14PIQAtm/OEC65BWMfrX68QPAARl5iw8jbAyHpOdeZsirNgiVzMhgJauE8+9oxzn/c6wv6Gst34f6G1H22ohvOiIkyFhL7UlVjmiV1o6zHaoVdqYeKF1Jp x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR12MB8311.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(396003)(376002)(39860400002)(366004)(230922051799003)(451199024)(64100799003)(1800799012)(186009)(9686003)(55236004)(55016003)(6506007)(7696005)(26005)(71200400001)(4326008)(8676002)(83380400001)(316002)(8936002)(6916009)(86362001)(52536014)(76116006)(66446008)(66556008)(54906003)(64756008)(122000001)(66476007)(38100700002)(478600001)(41300700001)(66946007)(33656002)(2906002)(5660300002)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/sfuMulnyZo1bUwY/tk/q9Mj9al5pFChS5q5OS6hw7BZ7y6RNiKrjJDrRxj7?= =?us-ascii?Q?kEy8jpJLlnSCMKgbY/QEbvcQ1vBFiBzqcAVQh5MFLXEPDnuTvTbGW+kn29oO?= =?us-ascii?Q?HTvfjaQz5x1YY1ZfbUfzxqO4oJkdBd3YYqfjohZ0P+cKlPU1AOO5Zoscha3Y?= =?us-ascii?Q?yvRGDM4Wv8K3iC3IEyWOR+CFg+PY9nPoVsiDFlEodazVxNJCf33tYyywaKeH?= =?us-ascii?Q?7qvZYkT+mK1qOIIOJ3ifAyU1Nxm77TtoiUqlMS1LFU1AGQvAzyM/eV6q71Co?= =?us-ascii?Q?/AtJejgU2FKb2FO6cfRMQbbSOcGbmCeh60cjHl4W2rgZ43uFTs0wZ2G+0GdN?= =?us-ascii?Q?wBij4V4LYpI/1p7pLsEDLP3RAX0muBE+kAOk52b3P/1mLonba8t1b53sQW4G?= =?us-ascii?Q?EItfBL+I2C17Fd89ENIFKkZwwJHN7vbpnh1NZtCgknTryyKKTJ5p9XOkWJRG?= =?us-ascii?Q?hsPwuRMktvGncTMWqFp8EZU0cC+GqXhUijwZMCI4NblfqL21DhHidGam8kfh?= =?us-ascii?Q?7gs5JduSHMlwFa1OLvyAJKlLEj8/yRhqSGvzBDQ+CPVsiuvnP/DaebFbfSf0?= =?us-ascii?Q?ZsCqXDKhfLkuF4QWakKwIf0dp7lB5D9L7/wK6LitzlVz6DJitfnNTAR/T9n7?= =?us-ascii?Q?WOfLjg4wiYNRXiqfiA+PIxGLoHzV/GiHYl2uzzwHowXMR6xYcM/MzSJhehu3?= =?us-ascii?Q?iI8igUW1QASNQ/+avglRsP/CTSjEAPW6YqUYFGHGyNCy6+9tBoMEyEq2V6rW?= =?us-ascii?Q?AY2grDsM7UumwvixoxURXzed4q1nZZXCo1L4NROpf7AtKAalT5ali3HG+G0G?= =?us-ascii?Q?eoSw+3yBfpXOgUUYngqjeguYbu49cBwbrWrp4NZ4W14Ovyo2JO2yKsPQyY9D?= =?us-ascii?Q?znXO5iXCLqUT84Yj27UWNvna1uofV7sNtFsSVZxy+zESQNtm3lwjz3tgnEHH?= =?us-ascii?Q?TyGJhFXlYSGub3e66XwxZhWUlVwJfOp+0KqlPvlw87nhLM7UtGWrkZeDp1sR?= =?us-ascii?Q?7PdwhL84CAQ4l3pdbzgQCEdi3ZbWb/lrQqFKv2xyTSuV1jMlTjYrvcvsukYb?= =?us-ascii?Q?vj+9yXB8Ktww/AuL8gVviDTqsKdCY4vAHOmphRWlr3WbBUtWEKbUsiHtnDzu?= =?us-ascii?Q?b39L2vOuOJ3XJ4pTP3zLDLRrNcwYIAc04wCifYelme7E1IEiw8bUiyJDte3P?= =?us-ascii?Q?y3DiUAkX6ChSi8EI3ZfqaRGrzCMgefrS9ap4OveA7+Tel1a78UquFqCQXh/j?= =?us-ascii?Q?h63Sbs8lLg7a7e1kPGngwIM3UC9qbUfEUAVOzzMFplbce8zhfbPg9yXtETN3?= =?us-ascii?Q?dwaz1DtpNte/xTbbfStlCvDz8r/2tkQ+eXMJ37wFY0Pz/uQyK2O/evOPAbu7?= =?us-ascii?Q?gJyHGGXbKvlCGuFY1M5hI9P4zITm4uq8p07melatVnDCK3Ynewc/rVhos6LP?= =?us-ascii?Q?aj68welT55cSFLUtxGWI4SppaowfQxd4hSeL4CpOhE8f1Kecu9YF/2X79JnY?= =?us-ascii?Q?0a8cuCuNg7/YPrl79XxcGgTXxixvGM975XK7jtVBSTfFO8YebDv+Hk/IOT73?= =?us-ascii?Q?+h4psZbB1ecVfKqIoji+59w5K/sa3jhsOcbIvY+9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB8311.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e97d0c9d-7395-429a-abb5-08dc1c079e85 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2024 11:37:02.8927 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kAP+zOOCVaZeynwJ/RFale4eDUQFFy7wWOOa7BNdhRdTOrVWHpxO5isMf1ZE7LzzuOb2j0dwqDc9/nM8lzgYVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7036 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen, Sorry for such a late response. From: Stephen Hemminger Sent: Thursday, January 4, 2024 02:08 > On Wed, 3 Jan 2024 19:14:49 +0000 > Dariusz Sosnowski wrote: > > In summary, in my opinion extending the async flow API with bulking > capabilities or exposing the queue directly to the application is not des= irable. > > This proposal aims to reduce the I-cache overhead in async flow API by > reusing the existing design pattern in DPDK - fast path functions are inl= ined to > the application code and they call cached PMD callbacks. >=20 > Inline needs to more discouraged in DPDK, because it only works if applic= ation > ends up building with DPDK from source. > It doesn't work for the Linux distro packaging model and symbol versionin= g, > etc. I understand the problem. In that case, I have a proposal. I had a chat with Thomas regarding this RFC, and he noticed that there are = 2 separate changes proposed here: 1. Per-port callbacks for async flow API. - Moves specified callbacks to rte_flow_fp_ops struct and allow PMDs to= register them dynamically. - Removes indirection at API level - no need to call rte_flow_ops_get()= . - Removes checking if callbacks are defined - either the default DPDK c= allback is used or the one provided by PMD. 2. Make async flow API functions inlineable. Change (1) won't break ABI (existing callbacks in rte_flow_ops can be marke= d as deprecated for now and phased out later) and in my opinion is less con= troversial compared to change (2). I'll rerun the benchmarks for both changes separately to compare their bene= fits in isolation. This would allow us to decide if change (2) is worth the drawbacks it intro= duces. What do you think? Best regards, Dariusz Sosnowski