Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

[Dylan Schneider <schneide@qti.qualcomm.com>]

[-- Attachment #1: Type: text/plain, Size: 2169 bytes --]

Hey Thomas,
In DPDK test cases, I agree that nothing other than Ethernet link types are currently used. However, when using DPDK Rawdev, the protocol is not usually Ethernet. In my case, I am trying to create PCAP files based on custom PCI-e traffic. The DPDK pcapng library currently hardcodes the metadata to be Ethernet, which cannot be read properly by Wireshark. Allowing the user to specify the protocol link type, the user can ensure the pcapng metadata matches the traffic data.
Dylan
________________________________
From: Thomas Monjalon <thomas@monjalon.net>
Sent: Saturday, September 27, 2025 3:28 AM
To: Dylan Schneider <schneide@qti.qualcomm.com>
Cc: dev@dpdk.org <dev@dpdk.org>; Reshma Pattan <reshma.pattan@intel.com>; Jerin Jacob <jerinj@marvell.com>; Kiran Kumar K <kirankumark@marvell.com>; Nithin Dabilpuram <ndabilpuram@marvell.com>; Zhirun Yan <yanzhirun_163@163.com>; Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.

26/09/2025 02:04, Stephen Hemminger:
> On Wed, 27 Aug 2025 16:32:15 -0600
> Schneide <schneide@qti.qualcomm.com> wrote:
>
> >
> > +* pcapng: Changed the API for adding interfaces to include a link type argument.
> > +  The link type was previously hardcoded to the ethernet link type in the API.
> > +  This argument is added to ``rte_pcapng_add_interface``.
> > +  These functions are versioned to retain binary compatibility until the next LTS release.
>
> Since link connector is now merged, and that wording might overlap and
> be confusing. Would be could to add reference to pcap-linktype.7 man
> page.

I'm not sure it overlaps.
RTE_ETH_LINK_CONNECTOR is about Ethernet cables while
pcap link type will be simply Ethernet type.

This being said, I don't understand the immediate benefit of this commit.
Why pcap link type would not be always Ethernet in DPDK case?
I think the only benefit is for future if other link types are added.
Is there something else I'm missing?



[-- Attachment #2: Type: text/html, Size: 3694 bytes --]