From: "Hyong Youb Kim (hyonkim)" <hyonkim@cisco.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "John Daley (johndale)" <johndale@cisco.com>
Subject: RE: [PATCH] net/enic: make local variable static
Date: Thu, 16 Oct 2025 04:46:28 +0000 [thread overview]
Message-ID: <IA3PR11MB89873567EBB9C96D86B21BEABFE9A@IA3PR11MB8987.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20251015231106.876172-1-stephen@networkplumber.org>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Thursday, October 16, 2025 8:11 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; John Daley
> (johndale) <johndale@cisco.com>; Hyong Youb Kim (hyonkim)
> <hyonkim@cisco.com>
> Subject: [PATCH] net/enic: make local variable static
>
> Avoid global variable name conflicts.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Hyong Youb Kim <hyonkim@cisco.com>
> ---
> drivers/net/enic/enic_sriov.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/enic/enic_sriov.c b/drivers/net/enic/enic_sriov.c
> index 43072a2287..29faa31512 100644
> --- a/drivers/net/enic/enic_sriov.c
> +++ b/drivers/net/enic/enic_sriov.c
> @@ -13,7 +13,7 @@ static int enic_check_chan_capability(struct enic *enic);
> static int enic_register_vf(struct enic *enic);
> static void enic_unregister_vf(struct enic *enic);
>
> -const char *msg_type_str[ENIC_MBOX_MAX] = {
> +static const char *msg_type_str[ENIC_MBOX_MAX] = {
> "VF_CAPABILITY_REQUEST",
> "VF_CAPABILITY_REPLY",
> "VF_REGISTER_REQUEST",
> --
> 2.47.3
prev parent reply other threads:[~2025-10-16 4:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 23:11 Stephen Hemminger
2025-10-16 4:46 ` Hyong Youb Kim (hyonkim) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA3PR11MB89873567EBB9C96D86B21BEABFE9A@IA3PR11MB8987.namprd11.prod.outlook.com \
--to=hyonkim@cisco.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).