* [PATCH] net/enic: make local variable static
@ 2025-10-15 23:11 Stephen Hemminger
2025-10-16 4:46 ` Hyong Youb Kim (hyonkim)
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2025-10-15 23:11 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, John Daley, Hyong Youb Kim
Avoid global variable name conflicts.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/enic/enic_sriov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/enic/enic_sriov.c b/drivers/net/enic/enic_sriov.c
index 43072a2287..29faa31512 100644
--- a/drivers/net/enic/enic_sriov.c
+++ b/drivers/net/enic/enic_sriov.c
@@ -13,7 +13,7 @@ static int enic_check_chan_capability(struct enic *enic);
static int enic_register_vf(struct enic *enic);
static void enic_unregister_vf(struct enic *enic);
-const char *msg_type_str[ENIC_MBOX_MAX] = {
+static const char *msg_type_str[ENIC_MBOX_MAX] = {
"VF_CAPABILITY_REQUEST",
"VF_CAPABILITY_REPLY",
"VF_REGISTER_REQUEST",
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] net/enic: make local variable static
2025-10-15 23:11 [PATCH] net/enic: make local variable static Stephen Hemminger
@ 2025-10-16 4:46 ` Hyong Youb Kim (hyonkim)
0 siblings, 0 replies; 2+ messages in thread
From: Hyong Youb Kim (hyonkim) @ 2025-10-16 4:46 UTC (permalink / raw)
To: Stephen Hemminger, dev; +Cc: John Daley (johndale)
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Thursday, October 16, 2025 8:11 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; John Daley
> (johndale) <johndale@cisco.com>; Hyong Youb Kim (hyonkim)
> <hyonkim@cisco.com>
> Subject: [PATCH] net/enic: make local variable static
>
> Avoid global variable name conflicts.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Hyong Youb Kim <hyonkim@cisco.com>
> ---
> drivers/net/enic/enic_sriov.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/enic/enic_sriov.c b/drivers/net/enic/enic_sriov.c
> index 43072a2287..29faa31512 100644
> --- a/drivers/net/enic/enic_sriov.c
> +++ b/drivers/net/enic/enic_sriov.c
> @@ -13,7 +13,7 @@ static int enic_check_chan_capability(struct enic *enic);
> static int enic_register_vf(struct enic *enic);
> static void enic_unregister_vf(struct enic *enic);
>
> -const char *msg_type_str[ENIC_MBOX_MAX] = {
> +static const char *msg_type_str[ENIC_MBOX_MAX] = {
> "VF_CAPABILITY_REQUEST",
> "VF_CAPABILITY_REPLY",
> "VF_REGISTER_REQUEST",
> --
> 2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-16 4:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-15 23:11 [PATCH] net/enic: make local variable static Stephen Hemminger
2025-10-16 4:46 ` Hyong Youb Kim (hyonkim)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).