RE: [PATCH 2/2] net/ice: count drop- all filter stats in Rx stats

["Wani, Shaiq" <shaiq.wani@intel.com>]

-----Original Message-----
From: Ivan Malov <ivan.malov@arknetworks.am> 
Sent: Thursday, July 31, 2025 11:14 AM
To: Wani, Shaiq <shaiq.wani@intel.com>
Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; Singh, Aman Deep <aman.deep.singh@intel.com>; Shaw, Jeffrey B <jeffrey.b.shaw@intel.com>
Subject: Re: [PATCH 2/2] net/ice: count drop- all filter stats in Rx stats

Hi,

On Thu, 31 Jul 2025, Shaiq Wani wrote:

> Packets dropped in the receive direction are counted as 
> "rx_unknown_protocol" (GLSWID_RUPP),these packets need to be added to 
> the "ipackets" and the GLV_GORCH/GLV_GORCL counters need to be added 
> to rx_bytes.
>
> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> ---
> drivers/net/intel/ice/ice_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/intel/ice/ice_ethdev.c 
> b/drivers/net/intel/ice/ice_ethdev.c
> index 513777e372..0ebe58f858 100644
> --- a/drivers/net/intel/ice/ice_ethdev.c
> +++ b/drivers/net/intel/ice/ice_ethdev.c
> @@ -6383,12 +6383,13 @@ ice_stats_get(struct rte_eth_dev *dev, struct 
> rte_eth_stats *stats)
>
> 	stats->ipackets = pf->main_vsi->eth_stats.rx_unicast +
> 			  pf->main_vsi->eth_stats.rx_multicast +
> +			  ns->eth.rx_unknown_protocol +

I may be wrong, but shan't drops and discards contribute to 'imissed' instead?
According to [1], 'ipackets' is 'Total number of successfully received packets', and per-queue version of 'ipackets' also exists, hinting at the host Rx nature.

[1] https://doc.dpdk.org/api-25.07/structrte__eth__stats.html#ac14b69830000494630c8897b70c5fc54

And if, say, they contribute to 'imissed', then no update to the 'ibytes'?
Please correct me if I'm wrong, -- I really prefer just to clarify this.

Thank you.

Hi,

To clarify - the packets we're accounting for were dropped intentionally due to user-defined "drop" rules (intentional) not due to errors.
Since the drop is deliberate, not due to resource issues or errors, we account them in ipackets and ibytes, not imissed.

Thanks.


> 			  pf->main_vsi->eth_stats.rx_broadcast -
> 			  pf->main_vsi->eth_stats.rx_discards;
> 	stats->opackets = ns->eth.tx_unicast +
> 			  ns->eth.tx_multicast +
> 			  ns->eth.tx_broadcast;
> -	stats->ibytes   = pf->main_vsi->eth_stats.rx_bytes;
> +	stats->ibytes   = ns->eth.rx_bytes;
> 	stats->obytes   = ns->eth.tx_bytes;
> 	stats->oerrors  = ns->eth.tx_errors +
> 			  pf->main_vsi->eth_stats.tx_errors;
> --
> 2.34.1
>
>