Hi,
5.
Contributing Code to DPDK — Data Plane Development Kit 16.04.0 documentation
Please refer to this link. And about the description, I think it would be good to describe that the real issue is missing to set the proper value in the error branch.
From: Yang Xu <xu.yang3@zte.com.cn>
Sent: Monday, November 17, 2025 5:12 PM
To: NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Dariusz Sosnowski <dsosnowski@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Matan
Azrad <matan@nvidia.com>; xu.yang3@zte.com.cn; yao.chenghu@zte.com.cn
Cc: dev@dpdk.org
Subject: [PATCH v2 1/1] net/mlx5: fix set port down if detect anomaly
|
External email: Use caution opening links or attachments
|
MLX network interface card link detection will set the
interface to a down state upon detecting an anomaly.
Fixes: 1256805 ("move linux-specific functions")
Signed-off-by: Yang Xu <xu.yang3@zte.com.cn>
---
.mailmap | 1 +
drivers/net/mlx5/linux/mlx5_ethdev_os.c | 1 +
test.eml | 21 +++++++++++++++++++++
3 files changed, 23 insertions(+)
create mode 100644 test.eml
diff --git a/.mailmap b/.mailmap
index 34a99f93a1..14d6ee93dd 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1891,3 +1891,4 @@ Zoltan Kiss <zoltan.kiss@schaman.hu> <zoltan.kiss@linaro.org>
Zorik Machulsky <zorik@amazon.com>
Zyta Szpak <zyta@marvell.com> <zr@semihalf.com>
Zyta Szpak <zyta@marvell.com> <zyta.szpak@semihalf.com>
+Yang Xu <xu.yang3@zte.com.cn>
diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
index 9daeda5435..03531ae879 100644
--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
@@ -504,6 +504,7 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete)
return -rte_errno;
}
} else if (ret < 0) {
+ dev->data->dev_link = {0};
return ret;
}
} while (wait_to_complete || retry-- > 0);
diff --git a/test.eml b/test.eml
new file mode 100644
index 0000000000..f30ef5dc8a
--- /dev/null
+++ b/test.eml
@@ -0,0 +1,21 @@
+./../dpdk-patch/0001-net-mlx5-fix-set-port-down-if-detect-anomaly.patch
+(mbox) Adding cc: Yang Xu <xu.yang3@zte.com.cn> from line 'From: Yang Xu <xu.yang3@zte.com.cn>'
+(body) Adding cc: Yang Xu <xu.yang3@zte.com.cn> from line 'Signed-off-by: Yang Xu <xu.yang3@zte.com.cn>'
+Dry-OK. Log says:
+Server: 10.5.231.43
+MAIL FROM:<xu.yang3@zte.com.cn>
+RCPT TO:<y>
+RCPT TO:<xu.yang3@zte.com.cn>
+From: Yang Xu <xu.yang3@zte.com.cn>
+To: y
+Cc: Yang Xu <xu.yang3@zte.com.cn>
+Subject: [PATCH v2 1/1] net/mlx5: fix set port down if detect anomaly
+Date: Fri, 14 Nov 2025 10:14:11 +0800
+Message-Id: <20251114021411.3606817-1-xu.yang3@zte.com.cn>
+X-Mailer: git-send-email 2.27.0
+In-Reply-To: <y>
+References: <y>
+MIME-Version: 1.0
+Content-Transfer-Encoding: 8bit
+
+Result: OK
--
2.27.0