From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00436A0542; Fri, 18 Nov 2022 08:05:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E438A4067B; Fri, 18 Nov 2022 08:05:09 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id B728B4021F for ; Fri, 18 Nov 2022 08:05:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668755107; x=1700291107; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8fW5maxE3MyjkwVd9AktOdUbVDmBLcc8q5g/FBVnUhs=; b=Cp5GNSde+BIVydJrBPqRkrMCYEq3iiKNZ1mR/45QHkfuSMYXcplKFx83 24UjEiZ4MKqM0Hzaki3xvLlHFvqC6BlWTu4iKhwh6vRxf/zV9lwGeNE7n KRQKanKjTOOe4aD7lgWtCd6kRu5RxQRDM9MJavOPsmos8O64/uu7gS0Kc sZPjKuKln/hGXiGrKFkGXyZBnL6f3Kh0EbwtQYnMpNhalpGVhnAOlbkkU 2C4pVQYBevx3AvBXdorsO0bJYUyiRjhiAV2g9f+4Lx7+rzwp2MubT6RKz UbG4nUPEsboKnnc9iyZ5QFlYBX8txgTlXoHGCrK0S+fn21AUO5UmkhvLs A==; X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="375206808" X-IronPort-AV: E=Sophos;i="5.96,173,1665471600"; d="scan'208";a="375206808" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2022 23:05:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="640112485" X-IronPort-AV: E=Sophos;i="5.96,173,1665471600"; d="scan'208";a="640112485" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 17 Nov 2022 23:05:06 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 17 Nov 2022 23:05:06 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 17 Nov 2022 23:05:06 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 17 Nov 2022 23:05:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g0EwdXo9s7QP4eczvjVgL6KN1NBA7CvwZ+VZs7miLaZyqoT1c2H7hSHUfQt5GtM7ZGvu/ZpJmX7JcF7Vj5M8DIANssTuHjRQiG2Wru1uE/h0eKhXwi2LEJ7PIE/XXXvPHNR/WJGLVgil3Nc2TBAAzPRNJM0DBlUtS5RGamla1l00y0fZwkmmrpj+9uRizhQJ0TE9y3lu/qANy8GEnHlcjJurwh9DHs7avlivcjAte9iS8/gqAVs0m6/jy2Df0Ry8TZnDAjJZd9GilpUbzOT4B48dDJS2Tt7eCwwnuLfawKbFu1p3XWphflUKL2BOVXs9UAFgY7J6YgF+ZyO3Z2kj0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=132tE1yLGDNXpdUCGr9woy0KpKexU1CWnJq4OIS5nZg=; b=aIKddDBLXClOLO9gY56FGhxFScoH4dGoezABCq4OWFGhUoyVbKW5pOqJRGMSDfn2j+LfrnvC/XY3i2hw/N47fmUjdCLRkaYENefFsZWUP9zWBXAKrrxs8CZnLyPyIW+E5iuUihpb5DIGwjeIvkU+rSsqv0TK28BmRoH8d+BHg3J89pj1ZRklMIcyadSz612bLoqivKDnD5f1qAa6r75kQq9wIOLu3CvH4YXtetZW0AkvjKOaKVZ8Jp6nZ4Vvb2B8YoUIlkEvYIFyBB3bfxkoZtv3Gh+xdTsZW6aEhLAlrz7g8QvftMcmMjLb1fsEr3AcVaxfcVLajOv+CkZiIdgQrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from LV2PR11MB5997.namprd11.prod.outlook.com (2603:10b6:408:17f::10) by IA1PR11MB7269.namprd11.prod.outlook.com (2603:10b6:208:42b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 07:05:04 +0000 Received: from LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::32df:d284:c205:3164]) by LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::32df:d284:c205:3164%9]) with mapi id 15.20.5813.017; Fri, 18 Nov 2022 07:05:04 +0000 From: "Xing, Beilei" To: "Wu, Jingjing" CC: "dev@dpdk.org" , "Peng, Yuan" Subject: RE: [PATCH v2] net/idpf: fix crash when launching l3fwd Thread-Topic: [PATCH v2] net/idpf: fix crash when launching l3fwd Thread-Index: AQHY+m2CkHlxh2KNvkyDPOpDNvMe265EN/OAgAAKyhA= Date: Fri, 18 Nov 2022 07:05:04 +0000 Message-ID: References: <20221117100054.13836-1-beilei.xing@intel.com> <20221117101509.14472-1-beilei.xing@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV2PR11MB5997:EE_|IA1PR11MB7269:EE_ x-ms-office365-filtering-correlation-id: a70d0065-7032-49af-97d0-08dac93337f6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mV1XUDZApCUpLbnIvMKfg/mboSuELyXIrg4ND4VvdnwSLWdilUB6n8jQ/bBa6DoBuGXuPc+DGK4k08iWJYxZdFQBJhlhrGbbSHxXrvfHkwWdNpmPUKJVmtyi9770dIkwRSIHCvBScl0OvFq3+5Q+B6/5Qkk5FhPrVBHD6YrzLt9yFf6ECtG5/aYM5mbJF8wFxwPBqPBOoHH98LYDDUrkSRlYAg4QNerYaHu9bcQuqrmGgjM6fGsBmHMqVxOXjUwI57PGEAhGE6e/C0LaT3ArD1ZlpZDCmEthmNPLITp0xoj5OZip+6AztxTiaqxlG/QYPMeFGkyv3IxBeJJZXGSldm2dg1cHkNsPaeDJDYn9lOsMgrnpMGwXdv8L72CabVe0e1Q/ENTMLzKki07GEUNj0ihTqjedoAyFMpBI1vNUG+J5Z8FXmax5TBrNAa1oZW64SB6jZJYmCf75BZHzikxUrh1oiKMnyoIBGiJBS83MJ0MvfiXMJlM1VncYZEC2Ouu3qZ2Vob67+LkuViORpJU9YzA1UWQ6UOTOhuyDckUvFqdB9QCTxEn66Qlav3+NG2M6JSXtVdjPdMHKWf3pNBjaMZ9r7uLAwMo0gzhu+sd+XX7mAy9tgAyrybuZ+AJ/jz/3jHSu0wZrZ/IN7p0PHXEZtZ3nfpgsb3HT26RipgkLcjZUcgO8ERLWaI1+zf/RDNGL3NYM8rXSAqpaBLEvXtFhXAWnuxWL543Ew5R68XTzTjg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV2PR11MB5997.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(39860400002)(346002)(366004)(396003)(376002)(451199015)(66899015)(33656002)(122000001)(38070700005)(38100700002)(52536014)(82960400001)(4744005)(2906002)(83380400001)(86362001)(8676002)(4326008)(316002)(66556008)(76116006)(66946007)(64756008)(66476007)(66446008)(26005)(186003)(53546011)(9686003)(54906003)(71200400001)(6636002)(5660300002)(8936002)(6862004)(41300700001)(478600001)(7696005)(6506007)(107886003)(55016003)(32563001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3RYolKwIyjWB+J8HiXix8Hi9LwB9eKfLWKaQLLpUZpkLdJKPwapXfQ3j6/A9?= =?us-ascii?Q?YIFLzcOT1Ab04v4KwtfOI9wfytcUSLdo1kjQeMDKZNesNdEcQH5foRR1/amG?= =?us-ascii?Q?M/nGqqHsoyHBKkF14YKfhIV3aMM4eK6Ts7HjeUoEmH9nUwe7B6TmWmrfnUZ6?= =?us-ascii?Q?9aMx2ZoUE3pf6bf00/DNqunhtQcAT1v2gW/rnPw71rgLSYewlGgZ3QWk63/K?= =?us-ascii?Q?Lat8YVgu1OV0dTg8Rxo5TQeWYaC84HqiT//dXl3xGp3ewDX21GFZD68KHurW?= =?us-ascii?Q?ZvaH0LgX+OsbpCI94FchnrylaNFoYKyqVM9foA54MBN0KjuXQAjz3DR9SCEK?= =?us-ascii?Q?pCbOdewc54TSq7bDLL3N8ghk863H4F78tNq/eRmWQFu7XeVjbLdc5rtS6aY9?= =?us-ascii?Q?pG+iwJd8F/2MtdPGI7yg8itGco+naY/XMhmVRqOwo5GQrTAJ/IC59R/zd+zV?= =?us-ascii?Q?W1ku7xsyC78WXcVD+0WZgPGaHTq7hBe/ePUb+5+nC5ou4qtim7+ZYsWNOQL8?= =?us-ascii?Q?mnv0ZDaP6Bm7pTMJEW4CGbncCDg+nliu6gEJJ5exZ8OSMvwoWxE4QFPCRklf?= =?us-ascii?Q?k/dOvEaWMqEvlnk+9Y6PQE50PRiueMqUn8637vCV6dfn4lLBkGmdL+faLnL0?= =?us-ascii?Q?piPiTcY9KtHfeJT5UjcamNmoBplaMd7VDm3fV/9d764pgW3kqAiSZN7ISJ4B?= =?us-ascii?Q?eD06cX5Rx+r2Vyr+WnDN+pqaDyiaUQipW4kjcVHEbY3KsxXV647+QtqNUSBU?= =?us-ascii?Q?JQMaKyqDQbNUFjCEqFxY/FjOfy6HQLNY3efCHkNdSdOghS2GtiJnSuI4s7Tj?= =?us-ascii?Q?Dm0EVz+jvtPyrAEVH4Prdli4zMEAzNR8udInJnh0wZUOLnuo5xby3P43ce20?= =?us-ascii?Q?lzhycHoNVu5DpuISZ4y/4mivlh3Vb4DSAtovDJNAHiPRMNsVnfDEQdCgVqtL?= =?us-ascii?Q?lCLppdTeuwoRGZPCcbvy9XgMNHlcC1rwOgQlicw5uNV2WA5tA3DFBZsEdLcx?= =?us-ascii?Q?6zeL8OCRTwgtrbk5ie/b5h9oDSDAFIxzK/ezOh0y30XrmaUq7W4pXexCSbBa?= =?us-ascii?Q?LoQMhr3DB5nR5DD2utAjJDZ+/2eHC4B1m7GUQSfpY1CRKep+3ll/WMN9Gs1G?= =?us-ascii?Q?dTE/9zWA+0d0rd4DF9Y24QbP5nvdM8BBkAxJFslpSA6wofcLLsHperExLIFb?= =?us-ascii?Q?FKfewkdynPR/X+PDeXPdZysaoRpPU9gLX2zZQrAw3eg0v49SBJiPp90ZBUAo?= =?us-ascii?Q?fT+wMGLdbZ/+4mg+F1i48i5fNltki+ywyW/TalQfXaGfnJEv3VaxMn7GuGm/?= =?us-ascii?Q?923A34y4bnaG8QSer98pcYFf8XH9boEtT0Fz1JpwJZ3evTa8c5mOfROQ7grH?= =?us-ascii?Q?FKMcoV92PGvJkB0F+rpsqgAOLTKlqqQLZjC2+6UrmQOUg77JGKHh9KiedO7g?= =?us-ascii?Q?ufR/0zm7LyjMGVOK15rrHsN60ArCRYyvBiWZr81jWT0xw5WlbtLOUGM8rsFu?= =?us-ascii?Q?CAUek9IfYa/5KKqfCpGhfIUOWvFf1yWqTlztdPlV/XK2cMf/+OB36DP6YgZV?= =?us-ascii?Q?1d2hYV/uWjNjoSOIFAG/Z6TFIG7nS/KPvjlD8Lhm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV2PR11MB5997.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a70d0065-7032-49af-97d0-08dac93337f6 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2022 07:05:04.5300 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Qy5Mfg/1H67BtkzOk/5ONcZPql0SqTRcidyldPNtrawX5NSPKKtv+35usEMiZIjI7qhoMQ8Q2F2FBkkTmQXDtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7269 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wu, Jingjing > Sent: Friday, November 18, 2022 2:24 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Peng, Yuan > Subject: RE: [PATCH v2] net/idpf: fix crash when launching l3fwd >=20 > > - > > if (conf->txmode.mq_mode !=3D RTE_ETH_MQ_TX_NONE) { > > PMD_INIT_LOG(ERR, "Multi-queue TX mode %d is not > supported", > > conf->txmode.mq_mode); > > diff --git a/drivers/net/idpf/idpf_vchnl.c > > b/drivers/net/idpf/idpf_vchnl.c index ac6486d4ef..88770447f8 100644 > > --- a/drivers/net/idpf/idpf_vchnl.c > > +++ b/drivers/net/idpf/idpf_vchnl.c > > @@ -1197,6 +1197,9 @@ idpf_vc_dealloc_vectors(struct idpf_vport *vport) > > int err, len; > > > > alloc_vec =3D vport->recv_vectors; > > + if (alloc_vec =3D=3D NULL) > > + return -EINVAL; > > + > Would it be better to check before idpf_vc_dealloc_vectors? Make sense, will update in next version.