From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4241F43150; Thu, 12 Oct 2023 09:42:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15EE9402BA; Thu, 12 Oct 2023 09:42:16 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 77DBA4028C for ; Thu, 12 Oct 2023 09:42:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697096534; x=1728632534; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Nlhkl7s6KouheUCPvE1dSerqt8KDRX+9xZk67NocwN4=; b=U6Ml1u2Hc4aTDp1qdd+scNNurY4D1H5veJmJ6NImP8bEmgcUkVaBUlCx 5aJKRs8UkPytl4+IbzqprXyk2uOREVCUiGQwuFBCfc4sJuuABhZ/yjUv4 ZCDEpC3PqQLWYblqZame76jNI/nbSR7CPHJ/pGsRG3Y8NH/YWwPnS+PoP ovdTMrl5fvOL5HexS1cTR4kzvyHeWFgB9g2eA4ByysPhKnQJazx71kHYe h5z3GcfUp3MRAmSfBmLKTb0Ro7ATFpdg2AFHlT+7Dv68SfWrMKINyb9L0 bQ+u7s0I62S7KayoIkYNckQ0v47SHo/2F+uK/2rgel1xYo1OKZyYLY0n8 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="365130876" X-IronPort-AV: E=Sophos;i="6.03,218,1694761200"; d="scan'208";a="365130876" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2023 00:42:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="754146402" X-IronPort-AV: E=Sophos;i="6.03,218,1694761200"; d="scan'208";a="754146402" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Oct 2023 00:42:12 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 12 Oct 2023 00:42:12 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 12 Oct 2023 00:42:12 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Thu, 12 Oct 2023 00:42:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ii3T7VnNKzQCPD6/nVG5kiq0HQXJQs+2wLc4hpxfBNyKatf3mGGQiRJ+g4hXq7Pzuq1wID6P1Yr12vrsTH/PDua+PRYj3/AIi5GGbW7kOIFebPWsF3jaGZgGSK0/86exH3dIvy4VAlzmDPW6fnNbZDAS52qAZuNqdTPk2kh71jXK1SBs+b7F0vaJxtQmQmNFnyYOS0863PlaO88ChCSt3d+jsyGy+m5yk50/woDPgWvvQLS1aPkCBB9OiWV/uFcXYmtfgKSd+vZKqrXjew/evocbPqy+rhqclyMluLr5ixHqxvueboPspOuN/Ljtsu+W00ly78iEO7h/GD16mru9wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b0Xui3aXmzP+QwVXQ7RzcGnPb6t0331QU3lfsog1JR4=; b=Iqn8rL728yfMgD1YnO33xzT0QaFOcrR4Qu2y6jnKY2UprdVAzciafqz8XHOv6rcxUAdJMkiVW0plEh5IjFaxdOfbvMMssMInCmqhejJFghrRG8RHtlgW09MHiBcG+e2z1Vot6G6PUy2rCZSHT1dqCQ+CHgV/b/F1rzSZIzSj9IUEkLXaMGluPA+v+8O/5ULT7Tkq6EeZPh7hga/3dwMxvYjDTxSItq1X4Sy4UDowDPfx0WZTqS7NBS0deaYyNg5Vnnl71873QO4JZWCu1QiUXQZJl2AQsiU4Gc3RTWO6yi3gnohvUX5OrLKdnkJRZVFig/ZdGe13BApdYB68oydHhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from LV2PR11MB5997.namprd11.prod.outlook.com (2603:10b6:408:17f::10) by IA1PR11MB7775.namprd11.prod.outlook.com (2603:10b6:208:3f3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Thu, 12 Oct 2023 07:42:11 +0000 Received: from LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::f14c:380b:cbbf:a014]) by LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::f14c:380b:cbbf:a014%4]) with mapi id 15.20.6838.040; Thu, 12 Oct 2023 07:42:11 +0000 From: "Xing, Beilei" To: "Wu, Jingjing" CC: "dev@dpdk.org" Subject: RE: [PATCH] net/cpfl: reset devargs during the first probe Thread-Topic: [PATCH] net/cpfl: reset devargs during the first probe Thread-Index: AQHZ/BzCHpKOkQHn+kqLpFzASatefLBFuY8AgAAJ/SA= Date: Thu, 12 Oct 2023 07:42:11 +0000 Message-ID: References: <20231011164720.418246-1-beilei.xing@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV2PR11MB5997:EE_|IA1PR11MB7775:EE_ x-ms-office365-filtering-correlation-id: 5e3bff26-12bd-43ca-eda2-08dbcaf6beaa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xM53QoFCYNX9ZUXa81zL7qiqPFVtAyLYqNuYO/2oGU8ewZFr2+G90lCbiUHDFw1QSviEJ9h0U/3IYQt0WI7dOfeOdlqxw60JzjFoWg1dREYDFJfus+0I1xcssFPsfinnaTzWtcf3W8posM6UEs/l6IBA+orSTVY+Ofvxtw7NzjGHAs0H9qm0JVxCmcyLnqdLQL3qOHaWi0yvPRSPu2MC2jIs9FTrmogqir8STRCEa9U9NG/KtOngLXpyau+Dbmkn03lOWo8W65ruQvhikDYezi7+remVezCx8m5myXIlXXkz6ofjIuOq25zZKFo8w20fo3AqGUhjpwneaZzxIoRE7dj0PEVOLrvpTRvUk8uNmzHg0iFyGjzWCA4kv2BoSuX2VPTODjmtg9+g+FTtALmZ4W4hhF59yPbYsz+YAXQpYH1UDLutf8rsSvpJgdL4Gdjo0BdViqQS/YftG6HIdh7OVgcD9vrimr4SIMawg1I+Z3GVKNFyBFIziKU1s79+dHYhME6DJFklj/xT8o6ZbDWA7Y5OAxO8J2uOLKzszlfKssYmyVWSkXsX8EwEgZX+BLR6Dg8Wh1+WmYx3R088ThbJL32zxWFUE1CDB9PkmJgYlzovDVY9MXkAGUalOIjtUAiy x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV2PR11MB5997.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(39860400002)(376002)(346002)(136003)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(86362001)(82960400001)(122000001)(38070700005)(38100700002)(33656002)(55016003)(9686003)(6862004)(41300700001)(4326008)(7696005)(8676002)(8936002)(6506007)(478600001)(5660300002)(71200400001)(2906002)(52536014)(26005)(64756008)(66476007)(6636002)(66556008)(316002)(66446008)(53546011)(83380400001)(66946007)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eOQkoeTDW8eEjLXqACDTbsFKPt2/3hfMFsiRfJsKKLKlD8/3wNuisYHTmg6Z?= =?us-ascii?Q?5rTnkBZC3SZASRWKyOJcrWg4ITLN4DwPC25tU/Tq8MQiGyglBp1x55KnMpn1?= =?us-ascii?Q?A5TWr7DZDANMhQ8lQtjcYYXiHk2hsXlMsP0lYxxz/lGypbSR8K8oYNkYS7Rl?= =?us-ascii?Q?brA96BtRYxDQWCDeX9lzQmpxmrO85mKK+IpUphf8owZwgEgeN8JW4OJzw1SZ?= =?us-ascii?Q?SmAiUtl/DGFsVg/PBlBRe0FygPo3pxO0RrHJjtdTOL0vV/dNPtOKxPKFjR/s?= =?us-ascii?Q?tMT2CNHRg7eGwL9TXRXGa2Xw5JmYf2SUIoB+wUrzEBgf3cBIGGH1rykIFnee?= =?us-ascii?Q?csp8hGhXsAymRx6ZDyMh7qDo0itfQM/ysOM0gIgROBneheqQ0SofcLHalLEx?= =?us-ascii?Q?xvAzyL0Co+LB04atcxNDYpjiG1m5Ztxa2vC3RsvPtig7FtUk1oizc7pzFYvE?= =?us-ascii?Q?MWelBTBrqxIEwMWxIc4sqHEsxyTdQNRqq0ZYHcpHmGFaTSJmeOdaVfczTfB8?= =?us-ascii?Q?lM+TKFOBdVtxiOAFlrH/7Nv2FLeyTxYbV0N9RxviIpMrz7LzXPwKCqWJjYuX?= =?us-ascii?Q?MxeV+pM7eQZkc8dm7HG7whCj/ic3WMYWJzaKqXakittRvdDdJJqIE6V/NQBo?= =?us-ascii?Q?A1tp04Ve9lx5Drpbu6v9wmmUR1y+IJQO5xKZdmZjn3shBguRx1+4pGv0wLEe?= =?us-ascii?Q?zRZO0QXzC05USi21+5wKypXvFT4NfDJJwjtTdqqGPdmpk1K11DWanfAREODa?= =?us-ascii?Q?b/VmhfyT8/NDlE/HLfEXYm5xF+W2ATL9wboRA7AOhIaQVoHwxX3pW5BwnJNX?= =?us-ascii?Q?fPTj+yDTHHyMHaGu+rTC/koutir2SwVopTRdTfu8QnYkLWbU7xvKnQYe/4p0?= =?us-ascii?Q?qW3vHH7ozzqW+MfoAdyEsMTglOjIbyJVJaKxtzGJNgMzEOVVEu/D/dXftWrx?= =?us-ascii?Q?1G93lp9R1ZiucaprWYBsJEdewPohulFXbkA2641lhEYahSRMMAnNQAK2Cerp?= =?us-ascii?Q?FoTp+ejFvtz8GKPa0MrbVOosvpk3jIHuidePfyiWcIMobeN7qls9DPITypKm?= =?us-ascii?Q?m6fasSLJ0S0otxLFlV8WPpi4bG94l63lD2rfS/GxmI5XY0jWSJo5hVTVToX6?= =?us-ascii?Q?cR2U0uunI3/VyHHyPEWa3LCUXA6W1Lpf74trG5mzFURiSJtUsIpk0OLyVXjW?= =?us-ascii?Q?0dnIMBPbXWLjksoUeFaJvBuJeHyM64x6+PSf+AV1NV8MK5wDK9sPHAK46bRf?= =?us-ascii?Q?8CbGih/xkyb5m2vEz/r0OWrFao4d/2xwoNe1j9Pcud0+ndDMKTUAf0azWKPn?= =?us-ascii?Q?8RPmoTwNUhyreJukXrm6CmvzrSQco8g+jhE6v7tIDKD95hTgTIs1lwk5Qw4b?= =?us-ascii?Q?jGhmSXRxvAdnUqc+wV5RDtMkVSYUDreCPCxudBAgIJudrRJoNHXXdnZkvFcO?= =?us-ascii?Q?IzBX9JnaldVAJRPH5V7oRI8CjDLEhnu7MZx7n0CJLzYhg6WSTJkB4FqCQqc8?= =?us-ascii?Q?TH4b9DCMM5mbS+tJQFDlIYMUnLuDT9q7qj7TzdFY2ozkuTv6icT3C3BkzPh0?= =?us-ascii?Q?E4GYt0QH7DnbKajN8X+CKu6bCZ+8yX1XUiS1NUG7?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV2PR11MB5997.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e3bff26-12bd-43ca-eda2-08dbcaf6beaa X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2023 07:42:11.2330 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Jh2dQ+rAJRo6y9DtSbCA3lWuwXfCgbvPZ5TYUEsZ8n1ZXnifQQf8nyJj3pjPY6hj+nZyO7x1ubinYl36Lw4QcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7775 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wu, Jingjing > Sent: Thursday, October 12, 2023 2:54 PM > To: Xing, Beilei > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/cpfl: reset devargs during the first probe >=20 >=20 >=20 > > -----Original Message----- > > From: Xing, Beilei > > Sent: Thursday, October 12, 2023 12:47 AM > > To: Wu, Jingjing > > Cc: dev@dpdk.org; Xing, Beilei > > Subject: [PATCH] net/cpfl: reset devargs during the first probe > > > > From: Beilei Xing >=20 > > Reset devargs during the first probe. Otherwise, probe again will be > > affected. > > > > Fixes: a607312291b3 ("net/cpfl: support probe again") > > > > Signed-off-by: Beilei Xing > > --- > > drivers/net/cpfl/cpfl_ethdev.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/cpfl/cpfl_ethdev.c > > b/drivers/net/cpfl/cpfl_ethdev.c index 762fbddfe6..890a027a1d 100644 > > --- a/drivers/net/cpfl/cpfl_ethdev.c > > +++ b/drivers/net/cpfl/cpfl_ethdev.c > > @@ -1611,11 +1611,12 @@ cpfl_parse_devargs(struct rte_pci_device > > *pci_dev, struct cpfl_adapter_ext *adap > > struct rte_kvargs *kvlist; > > int ret; > > > > - cpfl_args->req_vport_nb =3D 0; > > - > > if (devargs =3D=3D NULL) > > return 0; > > > > + if (first) > > + memset(cpfl_args, 0, sizeof(struct cpfl_devargs)); > > + > adapter is allocated by rte_zmalloc. It should be zero already. > If I understand correctly, memset to 0 should be happened when first prob= e is > done or before probe again but not at the beginning when first probe. But 'struct cpfl_devargs devargs' is the member of adapter, if 'memset to 0= ' happens before probe again, adapter->devargs will only save the last deva= rgs.