From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62F9A429FF; Wed, 26 Apr 2023 08:45:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5509C410DC; Wed, 26 Apr 2023 08:45:41 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 0A25440DDA for ; Wed, 26 Apr 2023 08:45:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682491539; x=1714027539; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TTe1692MswT2ihUFM5cgXJffk+yc7GOlChvE59ifyoI=; b=n4yD39KNG7PDuEqQibBYxaeodUnSQEI6/+S3QUsWQwQvuHQIiSx6AwaI +Xc1rct4drFMTyr52zNZNJ8dH5SDfOblon4v1y2F1D2qNDlR7FY7h2HfT l0kJGh0LrrynzAiZ6H+xAlc6ecsxkU0SRQHQjyXunvAzjEp3pzDm3fgHs k7XpCccfnjBFlmKA3JzVjubBP5qkt0lxqag6y4XV5CAw4B9bNgvAVX4OY n9TM9mJxlvssxoZRn8E+KbgNngYaWmGgQgFLaTL/r5wGLQKcx/hoptKYH t4gLLmw3mPnYyp+oSQH4lCpvPXZdMfxzcRiLCZBPUUtuNDuCfbLeMllK2 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="374968789" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="374968789" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 23:45:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="763181614" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="763181614" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP; 25 Apr 2023 23:45:38 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 25 Apr 2023 23:45:37 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 25 Apr 2023 23:45:37 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 25 Apr 2023 23:45:37 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 25 Apr 2023 23:45:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A4WHCFqvttVrjbCjGi7kMFrcvsOS0zAnfFSbpXYGBCYLJu/nFNBa9HTVVetmdPwPbqn9fMrr6Z7aosE+mNQLEK+hrkZrm+V4YWg/s/1ma1JIR7M/qJM5IOIW9GgDE9KQr6jg5BpfvlE5tvxaHmOEWbJrEbhhbpd/4PzG2gGgvx620Hkw4SBb1/g34UVvcjn9308P64xwWRu7k7sVGW4G0wiGWXeLqvisfq+AQy8aysm8wcMuPKZW/E8rJsu7BvlRaxPWoa4ddFUOxPQ7Eg6SWLJUGLZGX2yKRNz3rdDk7B/yFDUXoPS8xuvsLOD2caKgN6HzYdKhVUlGzZ05B6lmOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9ApaVkyqw6SdNkYlJUrJZGkTIfiz2+IDhX8m/e2knXE=; b=GXCKi/uqW/XdiwnxIZ3rqI0JVjc5Xq0vxXgpajzmyPzmlqdNA0XOfU4LX09wBMhQLDbU5Bf/0G0bGvc7F3tcqdK0OuduyGYu7aTa5vJxF8L664UylMcSmARlNBKHgbuWdfIFoK9QS6uX33Mgt06ACjh7n0BUPk9GjgOVfLFVlPpS/Xn3uDzYfUkbfeRiQgpv+7GZVa3R8Miq/+JDAwWmxJ6x+4+FmjLblss/oEd0jktPyX9Cg2seAu2fzNr/Gernui8ISZI/2cP3HoR3RX4OSVzOIN3G1WX1xH9diveeiAs39bfLe8xzE1CNFY+/k1dpWGsCLp9jmzWFJR8uA2Mnjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from LV2PR11MB5997.namprd11.prod.outlook.com (2603:10b6:408:17f::10) by DS0PR11MB7529.namprd11.prod.outlook.com (2603:10b6:8:141::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Wed, 26 Apr 2023 06:45:35 +0000 Received: from LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::a1be:2406:376c:612a]) by LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::a1be:2406:376c:612a%7]) with mapi id 15.20.6340.021; Wed, 26 Apr 2023 06:45:35 +0000 From: "Xing, Beilei" To: "Zhang, Qi Z" CC: "dev@dpdk.org" Subject: RE: [PATCH] common/idpf: remove unnecessary field in vport Thread-Topic: [PATCH] common/idpf: remove unnecessary field in vport Thread-Index: AQHZc15ddT9kjTzTIECe6jYxdjKDZK89LaTA Date: Wed, 26 Apr 2023 06:45:35 +0000 Message-ID: References: <20230420162038.637079-1-qi.z.zhang@intel.com> In-Reply-To: <20230420162038.637079-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV2PR11MB5997:EE_|DS0PR11MB7529:EE_ x-ms-office365-filtering-correlation-id: 8efbe854-1ef9-48c9-d159-08db4621d6e0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xp8Hg7B70+qj7J0ESZJSqu+u+HAa9a7Qo5OSq4atPyzn+HWy3Zba8xMgoibGy+ieiaWfPkX6Fd8VTYEVqYYkUQQgU1JowGbSgWJWzQsRuLpxVeUllar4V9lOtBTuLqYax2tpjgiSNej8rS50TCu5LEf4DzKkWK+kmrKOjG0r0R0Qkz3glkKd4CUGmCw1/KXCiMigESQLT44nqara4I50gAZ9Q2OvQNBtRNlrqZq9NcDRRFJM5qZ8SDsHRFu5Ay6QfcRiJqlqoNFcSL0mT8PkEupQZg/0nGQwvrySl9BCAFXOipkxt1O+N6r0nDFXXt5/qz5n0a3gPi4WBTtAk/5J74RiXR5CywpjJ1/DM5sa3G0D89DZ5GU7hMbXS5H4APj1kUdGIzH7v4dqNAA1e2bsiDdqAY5cUxVaGji3T+fd5+YP4xirxCedHcGWo2FlORYAEooXoV4fQ5PkHTmhMFUvnZlqYrxMy4+vy3WvPtuvdWxOE9B1ME4aTql6TVi9plCijLkZn4X4sUhdfJv32eV3AenKS976q83xlLe3KO4IZv8jsGfJ5HdRpN8g7X82cqi4wzFU+0o+Yf4iezVHe5jaEQUL/MPXKvkU/F44ML8ZAs+1sUlP5PFi3URbrMhA4zpX x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV2PR11MB5997.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(376002)(136003)(39860400002)(396003)(366004)(451199021)(8676002)(66556008)(66446008)(66476007)(6636002)(64756008)(6862004)(8936002)(76116006)(38100700002)(122000001)(66946007)(478600001)(86362001)(2906002)(41300700001)(33656002)(316002)(4326008)(52536014)(5660300002)(71200400001)(7696005)(38070700005)(53546011)(9686003)(26005)(6506007)(186003)(82960400001)(55016003)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?13vRnxETe/TWuXSOxFon6gIA3l3REjqw0uszqmAZTNaf8iuKgdxi3UrvVWrB?= =?us-ascii?Q?pAY0V77tNj3bsBiOGEUjPuc9SaS7doJuHBOkoasQV3TVYSO83PnOLu6qpkbw?= =?us-ascii?Q?eSZWFTuEwzettvdD0HNZCGS1HuGFsi0vQJ+BjRq27TazvxGvJlBTMSAfXJJ8?= =?us-ascii?Q?GKr4blY3cf8sCkp0OvcGU4ygOlYx5y9gZo5+WmeEV6cgjIT14MvCDgYT+Azc?= =?us-ascii?Q?vzl3lOgZsYHbPCqLGwJ18X2YmqxNwvPBY4wvDqU1BsCGT1WpY6/Z9fR4RFeq?= =?us-ascii?Q?vhrkOqYAVpw/CFU5MaQMr6A3NX3Alq9HivWcr9WjeEj48c54WqxSNM6jsDdZ?= =?us-ascii?Q?b+aiXciuFMzq8mF2p7RhvQV5jYmuigusv9u/PznmcPGlNUI07vMKj3OziyBx?= =?us-ascii?Q?zu1dcS7ig0+sU4J87Xe+yDvS+Or+CUnKRd/xbdMejo3LCrI3wkN+ZQwRLH/k?= =?us-ascii?Q?fl5/n+AKGs0kQBTcfTl41V/8HljNItBH/o/pali6gsEn0Ik82gZyTkwg8l6V?= =?us-ascii?Q?tnBqfQqEQt18F57AKLPwTi593hSoSoThTkGWMXR4v9ROCoysOOQDqTUo46U0?= =?us-ascii?Q?3yzCQT3/PVxEYzH1A5ZitnuYd+l+/N2gD8NGnsWeslzrNG38U0HVYu8obyWo?= =?us-ascii?Q?TvN6g3ailoTRKtAEkH3sfUxYBOLLDhW+5yAauKLWpFhFXxklTOpusSVF/1SZ?= =?us-ascii?Q?+BrkvGflUbWvwocUf4e/U1bAln64fx3pyWyNImLuOxG80Cw2lVFLHjMsTyvY?= =?us-ascii?Q?lLDQBRjhuPiMjxzp6hXCOJ15K7BynCC6TmKavhCPMyEQ5rphNZ68K9gLZhoe?= =?us-ascii?Q?B6O8qu7lRvCGb4zVSRgjHUf6KeU1r2wDrcbp3Co2WWVTKN/+FQ599yi8K4HC?= =?us-ascii?Q?6doc8HwezDQ1PDIG0UB8QLxJezEQwewPjRfIqXFVbEIE7tIeY0LboLsqdpb7?= =?us-ascii?Q?rGkLYlgTYeqELlqjTEMH2dX5lRHlt28aDGHWyffeMpf4YUA0IINzETlCzQjW?= =?us-ascii?Q?+0SA3i6ubgm8p5gUWH06c8PHFJEtgkgZ9HfFB1Uek7wi3ZUmO/vMv8vDYB4Y?= =?us-ascii?Q?m3guUolC7h3UyOGnY5HeEVVOIG+FM/mqAH+23arYyB7DJwiYwEIMtMAgC5SC?= =?us-ascii?Q?5wacammZ2h7lj0IbALdBqNbWwyJ4Its6P9ydq+x2pi4LE+5j1xtTX1MZEqAg?= =?us-ascii?Q?dWAZo/9CS62YEE4gAAQq2lEPZOkwaAH1+28AS0ngAuzmi/JTX+1hWtvP01fu?= =?us-ascii?Q?24bHEEFTccQSiuK3RCoeqF1F8iDTMZzRHzwoZc8Aa7HKJbt/MAAairmSJKfg?= =?us-ascii?Q?EC6oXVGqi82V0lpnHVBKg3yXyL/1iTKdfaFFlFgAlE2309rMcVYyogj2RExf?= =?us-ascii?Q?RhUS653ku3B+u8r7AVyUBMFyfvNFyVy04m6xP/+RePE4Om0/DM1OlMR8vZmK?= =?us-ascii?Q?1KvTtYZw5uEK9pssyHDHkjIYOw7F7aWODDbCvbWNK9LKCHY/j53bmKmp15zg?= =?us-ascii?Q?UvRycr9rGMjWhaWl1TM/HkrNWh2xx0MfxjbyhMSxgdVLXN0tk6JJxCjMI5/3?= =?us-ascii?Q?N8qqt1+Pnuuh9qi7vrwxMD/LhFM90Q5VhPYxHYZr?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV2PR11MB5997.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8efbe854-1ef9-48c9-d159-08db4621d6e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2023 06:45:35.5754 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fm63G6eZEsmlyVEb4u78ndUrrv1LHUaUNfBxJTsQBJssy96UGim9SztT8L4Yn+BPGVARQgy7Oa89MW0C0hPT8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7529 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Friday, April 21, 2023 12:21 AM > To: Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH] common/idpf: remove unnecessary field in vport >=20 > Remove the pointer to rte_eth_dev instance, as 1. there is already a poin= ter to > rte_eth_dev_data. > 2. a pointer to rte_eth_dev will break multi-process usage. Basically it's OK for me, do we need to add fix line? >=20 > Signed-off-by: Qi Zhang > --- > drivers/common/idpf/idpf_common_device.h | 1 - > drivers/net/cpfl/cpfl_ethdev.c | 4 ++-- > drivers/net/idpf/idpf_ethdev.c | 4 ++-- > 3 files changed, 4 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/common/idpf/idpf_common_device.h > b/drivers/common/idpf/idpf_common_device.h > index 7a54f7c937..d29bcc71ab 100644 > --- a/drivers/common/idpf/idpf_common_device.h > +++ b/drivers/common/idpf/idpf_common_device.h > @@ -117,7 +117,6 @@ struct idpf_vport { >=20 > struct virtchnl2_vport_stats eth_stats_offset; >=20 > - void *dev; > /* Event from ipf */ > bool link_up; > uint32_t link_speed; > diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethde= v.c > index f1d4425ce2..680c2326ec 100644 > --- a/drivers/net/cpfl/cpfl_ethdev.c > +++ b/drivers/net/cpfl/cpfl_ethdev.c > @@ -1061,7 +1061,8 @@ static void > cpfl_handle_event_msg(struct idpf_vport *vport, uint8_t *msg, uint16_t > msglen) { > struct virtchnl2_event *vc_event =3D (struct virtchnl2_event *)msg; > - struct rte_eth_dev *dev =3D (struct rte_eth_dev *)vport->dev; > + struct rte_eth_dev_data *data =3D vport->dev_data; > + struct rte_eth_dev *dev =3D &rte_eth_devices[data->port_id]; >=20 > if (msglen < sizeof(struct virtchnl2_event)) { > PMD_DRV_LOG(ERR, "Error event"); > @@ -1245,7 +1246,6 @@ cpfl_dev_vport_init(struct rte_eth_dev *dev, void > *init_params) > vport->adapter =3D &adapter->base; > vport->sw_idx =3D param->idx; > vport->devarg_id =3D param->devarg_id; > - vport->dev =3D dev; >=20 > memset(&create_vport_info, 0, sizeof(create_vport_info)); > ret =3D idpf_vport_info_init(vport, &create_vport_info); diff --git > a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c index > e01eb3a2ec..38ad4e7ac0 100644 > --- a/drivers/net/idpf/idpf_ethdev.c > +++ b/drivers/net/idpf/idpf_ethdev.c > @@ -1024,7 +1024,8 @@ static void > idpf_handle_event_msg(struct idpf_vport *vport, uint8_t *msg, uint16_t > msglen) { > struct virtchnl2_event *vc_event =3D (struct virtchnl2_event *)msg; > - struct rte_eth_dev *dev =3D (struct rte_eth_dev *)vport->dev; > + struct rte_eth_dev_data *data =3D vport->dev_data; > + struct rte_eth_dev *dev =3D &rte_eth_devices[data->port_id]; >=20 > if (msglen < sizeof(struct virtchnl2_event)) { > PMD_DRV_LOG(ERR, "Error event"); > @@ -1235,7 +1236,6 @@ idpf_dev_vport_init(struct rte_eth_dev *dev, void > *init_params) > vport->adapter =3D &adapter->base; > vport->sw_idx =3D param->idx; > vport->devarg_id =3D param->devarg_id; > - vport->dev =3D dev; >=20 > memset(&create_vport_info, 0, sizeof(create_vport_info)); > ret =3D idpf_vport_info_init(vport, &create_vport_info); > -- > 2.31.1