From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C89CA45B12; Fri, 11 Oct 2024 11:28:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 183E24028E; Fri, 11 Oct 2024 11:28:25 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 68FD04028B for ; Fri, 11 Oct 2024 11:28:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728638904; x=1760174904; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vACL/+NRYzHcVFHLXxeLQCcU1a85OOpCU+sKhfPK1BM=; b=LM1XJ5Wxr29+R+dfH31W+5dGrG8b+i6SpgiQ/hrqe39nPvOEbqRxDKzK XE/K/v/FlAoyfrhVEQ2xsebbXapktPBGILjL9NsWfv6qFb0QYfTnrDkhD ipo/tLPQl2SwqtSw3jLsG6fcPcqHGj3cnTa9oxr2l8xc3u/KzJveMhLv2 Ac8neJR0h/4tavqdlkDrJZaUIHIkDDtbrubCNa5U06Nk4yYd7vs8jdan1 tTmeYUhbwEHMjO1OP/+q7IEChhv0lxYShc6dQQp4rtrfrPD68fsEY4IGj dQ1WXcT4N7RB03iJN6QSbOUiYJdHXSLXk0i8WqDBTbfQE1BIju2Q6XzQt w==; X-CSE-ConnectionGUID: kQqx7voaQN6EsBxCfOs/9Q== X-CSE-MsgGUID: 8I7Ua/WgRImaUpX+qZR57g== X-IronPort-AV: E=McAfee;i="6700,10204,11221"; a="45508893" X-IronPort-AV: E=Sophos;i="6.11,195,1725346800"; d="scan'208";a="45508893" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2024 02:28:23 -0700 X-CSE-ConnectionGUID: Aqx8E602QFeyCP+WEjTRnw== X-CSE-MsgGUID: /qs33w++Q5OpQt5ezAKE3Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,195,1725346800"; d="scan'208";a="80864369" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Oct 2024 02:28:22 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 11 Oct 2024 02:28:21 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 11 Oct 2024 02:28:21 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 11 Oct 2024 02:28:21 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 11 Oct 2024 02:28:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c14B2mYBhKYq7+HBwmcx/+2B72foo2A2YwwAEdzSZHLTxAXmBf6gRjMfNSkHa5v56SUxW/Epjkk5inOtUeIjJ5yajmhHW/tatNbhLRiSGMtnC1cBMsPbROoEsL8yAqyMJVp0jT+y3EDbOT2uBY5ux05Hq6q1M3Ks2LdQkysjNY839RrefBHYW5nvhYBOftaQ9yZnYjFpkp3qCWyg2sXcGgx26W70DTa56uDD/CuWNluxHdGm+fHNoNJEJRk/4wZYwq4MxTvwTTfnRtU2qWQellJ7CPqmgBJztst+K1NsUVoOPRLRNLvBrUR26cdzQdqDZBnmJckjw5Yy1OgWEKbaSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C0k02L2NBGHGyRsOgcdDAgPLlGbYpzQhwdXzB8IEZOA=; b=K312hK5nBwy4eFrgd41rVBH8pAHIwiit6uyQkjxpbo7iWMF6rMfj50owKU2bMNmXcoSnT6Rpm6qO5gMuj7IstntwCFkIWBo+3tHYKPc8mrO5A4eT929LHpb8gg0hXWfc1Ei4NSmkuMk11Px6IOi6zPJ4LvRjHZPWVVuyJPtJNqNl9QLIS0xI2+mAZMEB6noFgFyWFyPi9XwHhofOiZ3JcqXTeFcW9Moau1nXOn3XfLdfCov30rMwYdzospjP5Q04ePq/BdWf5jvFu2YjmLZ+kJXaVNllS6h8m4VQ9pMNwZDZpAqxHm8KCa6D13zAM4qmP73EnAWBEWBzVVStuE8XbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from LV3PR11MB8601.namprd11.prod.outlook.com (2603:10b6:408:1b8::8) by PH7PR11MB6697.namprd11.prod.outlook.com (2603:10b6:510:1ab::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.18; Fri, 11 Oct 2024 09:28:18 +0000 Received: from LV3PR11MB8601.namprd11.prod.outlook.com ([fe80::7878:b054:82bf:b5b]) by LV3PR11MB8601.namprd11.prod.outlook.com ([fe80::7878:b054:82bf:b5b%5]) with mapi id 15.20.8048.017; Fri, 11 Oct 2024 09:28:18 +0000 From: "Ye, MingjinX" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "Su, Simei" Subject: RE: [PATCH v6 2/3] net/ice: add frequency adjustment support for PTP Thread-Topic: [PATCH v6 2/3] net/ice: add frequency adjustment support for PTP Thread-Index: AQHbG6rLkv4cMJo6akKSe5HUmLHSw7KBMIeAgAANeLA= Date: Fri, 11 Oct 2024 09:28:18 +0000 Message-ID: References: <20241011025332.1423395-1-mingjinx.ye@intel.com> <20241011063407.1427421-1-mingjinx.ye@intel.com> <20241011063407.1427421-3-mingjinx.ye@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV3PR11MB8601:EE_|PH7PR11MB6697:EE_ x-ms-office365-filtering-correlation-id: 23d6dfa3-39ca-4217-2ddf-08dce9d70a90 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?IhHuubH1f58s2MCYhXIlLTL3BnVDipONSY7I+jtR8f5IjA3RyR79ve8Htm0P?= =?us-ascii?Q?ec9I8Af73M8Mf1ZYq8A732mUIymNAkfzvXEcaqUTFYOIAgsJvDHAETY5hRcM?= =?us-ascii?Q?PbekuNMMkwvrrLiiPRWAuK2ejwlwDbYTxzzkxOpeDWeTPR3WCgFnV+eJY771?= =?us-ascii?Q?0aVqswns+U2sUCJxSLGJUv+Acdru8NgixSD4YOc1r4FIVaIxzy8dRBKjV/Xf?= =?us-ascii?Q?662vGc5+sZGyMSqR/PS8JJ9NVi5rTBAe8iBhjai6IUj3gTpzJvTeMJm9dkX2?= =?us-ascii?Q?p/uioPANdp6XW1dKObp15OODbHkBqXqeETBF4TbK09CfBKEKJryPMQiOHx1u?= =?us-ascii?Q?QoHtaqNiWaLEQeOEvw+cu4y6HgrwuEQlqvLRf5YlfDPnfZMeo0cZQw5s96GA?= =?us-ascii?Q?Lm3GlpmSuhumvybZol3sCLaDVFWGauR27sFh2Ds5AKdAIYpZKeXPrd1j3maY?= =?us-ascii?Q?jJ2wPS+ev1iim4YuWIn1iloi3sewRDFv0cSVmG2NcWrCd/DyGGC1b6AKuT3N?= =?us-ascii?Q?sBjTbaYfL434k8hmkcFMqYniTjGIzMsIbawqFJm92J+Fi2k0Q3ZfCUknkMaU?= =?us-ascii?Q?lNpetcozUefz6ziKTt7kNAStmHtNnuu0ofLyF9NyB1XNiC0Qpz29vIzzLdAv?= =?us-ascii?Q?FlpZJC3BAjwROUF6eGOV040lwOqiWX//Ky3PhkpveivOYASgCY9upCdebHIZ?= =?us-ascii?Q?30VGPif3zFqo+jcmVH6rIU8jGfPyuXpR65VmbcGjynlurZ9MGAudZs1jczQH?= =?us-ascii?Q?+ZfFA2TyTneCHfX81z1CbRBIJ34VQSjrOOlREgrNlBIMVky8BrlrB4hKy7b8?= =?us-ascii?Q?Gt6fkvRslrhW6pX3glcmoA+bsoFpYcDPZpd3DOhGwk9gEwd5Jc+5IC1tOFJu?= =?us-ascii?Q?KV3SAJW7Vdjs4TwmHuDNxwk81Vw17q7tJfBeW9aWe7Pe2AYY+4iZDz3jP4ki?= =?us-ascii?Q?Mpevtf54BZf15bzPlzdRu48WLvmZ9qsl/6I+XIWNuDgDcj5YTJ41H3hBWs+v?= =?us-ascii?Q?Z7fabAygpikT9zbTFrj+VGKKFMEKGunhWWeJufLQy4M16Xffa3YSmW+4o4T4?= =?us-ascii?Q?os5utbgoxgbCPXVqnRBYo2CazIOgmVmA7o+BelgxjmTrV4J14ND21YLSplev?= =?us-ascii?Q?rdBQQ8/EHm6A47AGqn+0mdihB8kfSjUDfOZT1HcSx8662KnHM9YCgws9dJrF?= =?us-ascii?Q?C+YqRvIhf0DfkDrUVfmVLHMPfKO2K3jETztaWALawb5FbdSE5xP84xs3n8Wx?= =?us-ascii?Q?wTwlwdnkcaaL3Rz+2S81naSH8rudOr3RJRA2rvAif4/rMnMdy0yZ35iXJKLn?= =?us-ascii?Q?uIliFPvsScEShl8hiLj2Y1Yob9hb9179W5YS9DVQEvZ7tg=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV3PR11MB8601.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0rTIakJE1ACt2JaQRV/1Cc8iWeibq4O6+NLhsW0fKxnZUMBQqb59rqKH+0oQ?= =?us-ascii?Q?RNBGGGdq9eHYZ+1eLqKfToIbORl1z92IJJlT8HidFJK4lwCj7UMekfDf2xJT?= =?us-ascii?Q?Thv0K73LA1soLbhRpckn0e9mOGwTatFzyPCUbisUY1WiQ6oPwUqWnPiYnv9w?= =?us-ascii?Q?jpb3KAcPTYQWOpusF4xAgaXAGR0IhasItcrpNccbKGrxSS1FKOM0H6I9d201?= =?us-ascii?Q?KJnngAYqQ2pclHYmN9+QmY+ffbZiLHCp/fvP6v/1kaf4PQhO/KJDxTk+IGs/?= =?us-ascii?Q?i5g+aR5P1FYBovZH/4bwIb9eRqCHM5RU7jKivTSslH64GpyPdqPwrDnxGfm7?= =?us-ascii?Q?U3q48xQx3UiOD4abCxkmaXqsrl5yi8eo8XpRWZJgBujRvK/R7m60n89OZfHw?= =?us-ascii?Q?2hILU6YfL9YUdc/jTSuBwUQQw34wqhnCKIBxzFsohobPwH2DKn1mUN14CnVA?= =?us-ascii?Q?2eXW7Ufm93Cyv5MT97jZj4SIiQMLoUAf50sU5agCAli82oHCQCnWvbD8jo/u?= =?us-ascii?Q?aEhxECeUYfPkhIU++lNK7YCyy3UERd6mff+f3NrDa1rLaW6RgfhBu5K5WVDd?= =?us-ascii?Q?9z7uj9eJUFbsu+w+EqHNm+C6KLhMjoyB0VeZINJ/bM7g1GWO6jdUJvvoek0O?= =?us-ascii?Q?xSNYs3WL9dpwydLYmCL1M2zKXZRVcHozgpdvDusl/V6tuvR/rYbpFpV46cz5?= =?us-ascii?Q?TcGdz+iuJKirtHmXUUFZJQQKArMYX9H9LfsH41EOYUg7WbADN3wG5+eEeWrC?= =?us-ascii?Q?ZR069utvA+fTO+hC6PdznRm0a2TKNF7Xm3RqA+PQKTstNZrjwQAP0FFNLYOA?= =?us-ascii?Q?0Lv1f2WutJilDXuCu/T0qs2tF2+H4RZyV6sAIJZ9qjK10UjhrMTkZc/yqcEK?= =?us-ascii?Q?9dvRNNn6t04Vmx2DV3XfZWLZ0aVA+UdJWT/oa2OOl63ZfQcE27g6gnAjiOmW?= =?us-ascii?Q?rc4oDpzjAm3BLIHpnwc/ezeJTWxOAjLfDTU5f+axbq1hvZ/Ncoos/4XcR5bl?= =?us-ascii?Q?W6TN3ejVul81+FH/ltqfH+qQsQ2JfGmFSJLmkgFPSYzUMdQQD+Um3Apkr61S?= =?us-ascii?Q?UwNbIpruQ+TrK273tLIQMGmzcSaXAZXndCSO3mlwTq/AeTFekfUdCi4qCx0d?= =?us-ascii?Q?Q1Pj7LBz0J0CxAPpBkAvCrjWZG1lz6Nt8owvN9vQsEuT+MAfwixJP2WKwVrH?= =?us-ascii?Q?AV9VJj+RQ+uef8DlZDdsuIpHWrc6sgt/6ido2l8ZrNL1FWjNzXpSFtWsKZNl?= =?us-ascii?Q?R4PMJ2oiQuY8AQS/KQnCnC4I/Ztd5nSPSWq6yOf28R6Xi+nGkyLUQ2v/FD34?= =?us-ascii?Q?XXUnuhhQhjayML/cDsNgaziPNIrNmUFj5qzqZyzw42KRliM1d8i5P6G+NHKF?= =?us-ascii?Q?63ccvcb8rrruSZ987mGOn9hRhSenNy6ENtK0lVONdUpgW0Nqns0/TdxGD90K?= =?us-ascii?Q?btSwgqf2aDH3JMpSa+ZdMQUbxStbm7jYTUBWZoyJ395cKpNIfyZlrztD8LwN?= =?us-ascii?Q?xv+6GrCoK8RIFHREv9ucw4QisxCqHeFOzmClmXvmTlZk0kwFcE3wmptJZGrG?= =?us-ascii?Q?6HulXWdWYwvaHTjL+qKHD/WGvDcMwZ9JfpYYy8KX?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8601.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23d6dfa3-39ca-4217-2ddf-08dce9d70a90 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2024 09:28:18.4195 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pwSGJopRdwgvOs/4DvmRZ8iwhStvd0qWrlidi5k7Zkncc0pDuAkNP3ej2mdTWkb/g7PcVZd/f1LA4ofGl9eK4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6697 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, October 11, 2024 4:03 PM > To: Ye, MingjinX > Cc: dev@dpdk.org; Su, Simei > Subject: Re: [PATCH v6 2/3] net/ice: add frequency adjustment support for > PTP >=20 > On Fri, Oct 11, 2024 at 06:34:06AM +0000, Mingjin Ye wrote: > > Add ice support for new ethdev API to adjust frequency for IEEE1588 > > PTP. Also, this patch reworks code for converting software update to > > hardware update. > > > > Signed-off-by: Simei Su > > Signed-off-by: Mingjin Ye > > --- > > doc/guides/nics/ice.rst | 16 ++++ > > drivers/net/ice/ice_ethdev.c | 176 ++++++++++++++++++++++++++------ > --- > > drivers/net/ice/ice_ethdev.h | 5 +- > > drivers/net/ice/ice_rxtx.c | 4 +- > > 4 files changed, 153 insertions(+), 48 deletions(-) > > > > diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index > > ae975d19ad..061c8c7a20 100644 > > --- a/doc/guides/nics/ice.rst > > +++ b/doc/guides/nics/ice.rst > > @@ -328,6 +328,22 @@ Forward Error Correction (FEC) > > > > Supports get/set FEC mode and get FEC capability. > > > > +Time Synchronisation > > +~~~~~~~~~~~~~~~~~~~~ > > + > > +The system operator can run a PTP (Precision Time Protocol) client > > +application to synchronise the time on the network card (and > > +optionally the time on the > > +system) to the PTP master. > > + > > +ICE PMD supports PTP client applications that use the DPDK IEEE1588 > > +API to communicate with the PTP master clock. Note that PTP client > > +application needs to run on PF and add the > > +``--force-max-simd-bitwidth=3D64`` startup parameter to disable vector > mode. > > + > > +.. code-block:: console > > + > > + examples/dpdk-ptpclient -c f -n 3 -a 0000:ec:00.1 > > + --force-max-simd-bitwidth=3D64 -- -T 1 -p 0x1 -c 1 > > + >=20 > It's a pity that the vector disabling doesn't happen automatically somewh= ere > and that we have to ask the user to pass in the flag. Maybe see if that c= an be > improved for RC2 or next release? Currently, hardware timestamping is enabled by marking RTE_MBUF_F_TX_IEEEE1= 588_TMST in mbuf->ol_flags. Therefore, automatic routing is not possible. There are no suitable uninstall flags to choose from when selecting the tx = path. This would be easily achieved by adding a macro of type 'RTE_ETH_TX_IEEEE15= 88_TMST' after lib/ethdev/rte_ethdev.h#1624. Is this feasible? Is the scope of the impact on the large side.